gpio: gpiolib-devprop: Check chip->parent pointer before dereferencing
authorThor Thayer <tthayer@opensource.altera.com>
Tue, 25 Oct 2016 16:31:23 +0000 (11:31 -0500)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 25 Oct 2016 18:23:19 +0000 (20:23 +0200)
Confirm the chip->parent is valid before dereferencing because
the parent parameter is optional.

Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib-devprop.c

index 17bfc41692ef68c300cff0b6fe98a9f808fba221..27f383bda7d9621322a3340d9def92354d21d7a3 100644 (file)
@@ -31,6 +31,11 @@ void devprop_gpiochip_set_names(struct gpio_chip *chip)
        const char **names;
        int ret, i;
 
+       if (!chip->parent) {
+               dev_warn(&gdev->dev, "GPIO chip parent is NULL\n");
+               return;
+       }
+
        ret = device_property_read_string_array(chip->parent, "gpio-line-names",
                                                NULL, 0);
        if (ret < 0)