regulator: Fix suspend to idle
authorMark Brown <broonie@kernel.org>
Tue, 30 Jan 2018 12:16:31 +0000 (12:16 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 30 Jan 2018 12:25:59 +0000 (12:25 +0000)
When suspending to idle with the new suspend mode configuration support
we go through the suspend callbacks with a state of PM_SUSPEND_TO_IDLE
which we don't have regulator constraints for, causing an error.  Avoid
this and similar errors by treating missing constraints as a noop.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c

index 42681c10cbe4fa9f7f001be90ff60dcdd3cf0db8..dd4708c58480d277e0346f9b287831b080f8af6b 100644 (file)
@@ -758,7 +758,7 @@ static int suspend_set_state(struct regulator_dev *rdev,
 
        rstate = regulator_get_suspend_state(rdev, state);
        if (rstate == NULL)
-               return -EINVAL;
+               return 0;
 
        /* If we have no suspend mode configration don't set anything;
         * only warn if the driver implements set_suspend_voltage or