drm/connector: Pass a drm_connector_state to ->atomic_commit()
authorBoris Brezillon <boris.brezillon@bootlin.com>
Tue, 3 Jul 2018 07:50:16 +0000 (09:50 +0200)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Sat, 7 Jul 2018 05:51:56 +0000 (07:51 +0200)
Other atomic hooks are passed state objects, let's change this one to
be consistent.

Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180703075022.15138-3-boris.brezillon@bootlin.com
drivers/gpu/drm/drm_atomic_helper.c
include/drm/drm_modeset_helper_vtables.h

index 7787e0e6bbc6b38f8b99c074433d0313096b00ca..47e84aa7b6e244349097f4f02cd5c7970fc08506 100644 (file)
@@ -1187,7 +1187,7 @@ static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,
 
                if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) {
                        WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK);
-                       funcs->atomic_commit(connector, new_conn_state->writeback_job);
+                       funcs->atomic_commit(connector, new_conn_state);
                }
        }
 }
index 3b289773297c29f04f33808beb7e020bbcd91c1d..fb841f44949cf7d35f29e23668aad7ef01f037bc 100644 (file)
@@ -980,11 +980,13 @@ struct drm_connector_helper_funcs {
         *
         * This hook is to be used by drivers implementing writeback connectors
         * that need a point when to commit the writeback job to the hardware.
+        * The writeback_job to commit is available in
+        * &drm_connector_state.writeback_job.
         *
         * This callback is used by the atomic modeset helpers.
         */
        void (*atomic_commit)(struct drm_connector *connector,
-                             struct drm_writeback_job *writeback_job);
+                             struct drm_connector_state *state);
 };
 
 /**