Input: sidewinder - make array seq static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Thu, 5 Sep 2019 19:01:30 +0000 (12:01 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 6 Sep 2019 00:56:33 +0000 (17:56 -0700)
Don't populate the array seq on the stack but instead make it
static const. Makes the object code smaller by 30 bytes.

Before:
   text    data     bss     dec     hex filename
  22284    3184       0   25468    637c drivers/input/joystick/sidewinder.o

After:
   text    data     bss     dec     hex filename
  22158    3280       0   25438    635e drivers/input/joystick/sidewinder.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/sidewinder.c

index 0284da874a2b85af3b5afabd40372a02a368c012..1777e68c9f0238487fe54b838148ded2d22aaa0a 100644 (file)
@@ -223,7 +223,7 @@ static __u64 sw_get_bits(unsigned char *buf, int pos, int num, char bits)
 
 static void sw_init_digital(struct gameport *gameport)
 {
 
 static void sw_init_digital(struct gameport *gameport)
 {
-       int seq[] = { 140, 140+725, 140+300, 0 };
+       static const int seq[] = { 140, 140+725, 140+300, 0 };
        unsigned long flags;
        int i, t;
 
        unsigned long flags;
        int i, t;