IB/cm: Fix device_create() return value check
authorJani Nikula <ext-jani.1.nikula@nokia.com>
Thu, 11 Mar 2010 16:17:28 +0000 (16:17 +0000)
committerRoland Dreier <rolandd@cisco.com>
Wed, 31 Mar 2010 21:26:52 +0000 (14:26 -0700)
Use IS_ERR() instead of comparing to NULL.

Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/core/cm.c

index 764787ebe8d80f661ba9e7edf0b0e98c38502bfc..c9730cb3f695f0dc3f58e460038e586a0e0c6368 100644 (file)
@@ -3693,7 +3693,7 @@ static void cm_add_one(struct ib_device *ib_device)
        cm_dev->device = device_create(&cm_class, &ib_device->dev,
                                       MKDEV(0, 0), NULL,
                                       "%s", ib_device->name);
        cm_dev->device = device_create(&cm_class, &ib_device->dev,
                                       MKDEV(0, 0), NULL,
                                       "%s", ib_device->name);
-       if (!cm_dev->device) {
+       if (IS_ERR(cm_dev->device)) {
                kfree(cm_dev);
                return;
        }
                kfree(cm_dev);
                return;
        }