md: only allow remove_and_add_spares when no sync_thread running.
authorNeilBrown <>
Fri, 2 Feb 2018 22:19:30 +0000 (09:19 +1100)
committerShaohua Li <>
Mon, 19 Feb 2018 17:40:01 +0000 (09:40 -0800)
The locking protocols in md assume that a device will
never be removed from an array during resync/recovery/reshape.
When that isn't happening, rcu or reconfig_mutex is needed
to protect an rdev pointer while taking a refcount.  When
it is happening, that protection isn't needed.

Unfortunately there are cases were remove_and_add_spares() is
called when recovery might be happening: is state_store(),
slot_store() and hot_remove_disk().
In each case, this is just an optimization, to try to expedite
removal from the personality so the device can be removed from
the array.  If resync etc is happening, we just have to wait
for md_check_recover to find a suitable time to call

This optimization and not essential so it doesn't
matter if it fails.
So change remove_and_add_spares() to abort early if
resync/recovery/reshape is happening, unless it is called
from md_check_recovery() as part of a newly started recovery.
The parameter "this" is only NULL when called from
md_check_recovery() so when it is NULL, there is no need to abort.

As this can result in a NULL dereference, the fix is suitable
for -stable.

cc: yuyufen <>
Cc: Tomasz Majchrzak <>
Fixes: 8430e7e0af9a ("md: disconnect device from personality before trying to remove it.")
Cc: (v4.8+)
Signed-off-by: NeilBrown <>
Signed-off-by: Shaohua Li <>

index 9b73cf139b800b266e170057d1744d37d894b3f0..ba152dddaaa339e8491e0d9e1bdf21f664369aab 100644 (file)
@@ -8595,6 +8595,10 @@ static int remove_and_add_spares(struct mddev *mddev,
        int removed = 0;
        bool remove_some = false;
+       if (this && test_bit(MD_RECOVERY_RUNNING, &mddev->recovery))
+               /* Mustn't remove devices when resync thread is running */
+               return 0;
        rdev_for_each(rdev, mddev) {
                if ((this == NULL || rdev == this) &&
                    rdev->raid_disk >= 0 &&