KEYS: return full count in keyring_read() if buffer is too small
authorEric Biggers <>
Thu, 2 Nov 2017 00:47:03 +0000 (00:47 +0000)
committerJames Morris <>
Thu, 2 Nov 2017 09:58:05 +0000 (20:58 +1100)
Commit e645016abc80 ("KEYS: fix writing past end of user-supplied buffer
in keyring_read()") made keyring_read() stop corrupting userspace memory
when the user-supplied buffer is too small.  However it also made the
return value in that case be the short buffer size rather than the size
required, yet keyctl_read() is actually documented to return the size
required.  Therefore, switch it over to the documented behavior.

Note that for now we continue to have it fill the short buffer, since it
did that before (pre-v3.13) and dump_key_tree_aux() in keyutils arguably
relies on it.

Fixes: e645016abc80 ("KEYS: fix writing past end of user-supplied buffer in keyring_read()")
Reported-by: Ben Hutchings <>
Cc: <> # v3.13+
Signed-off-by: Eric Biggers <>
Signed-off-by: David Howells <>
Reviewed-by: James Morris <>
Signed-off-by: James Morris <>

No differences found