media: vicodec: add missing v4l2_ctrl_request_hdl_put()
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 12 Aug 2020 10:30:33 +0000 (12:30 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 27 Aug 2020 07:30:20 +0000 (09:30 +0200)
The check for a required control in the request was missing a call to
v4l2_ctrl_request_hdl_put(), so the control request object was never
released.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 997deb811bf5 ("media: vicodec: Add support for stateless decoder.")
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/test-drivers/vicodec/vicodec-core.c

index 8941d73f6611db4a54cda773e0cadcedf0d5fcbd..71928e30dae809310fb7b8a4569194055258e657 100644 (file)
@@ -1994,6 +1994,7 @@ static int vicodec_request_validate(struct media_request *req)
        }
        ctrl = v4l2_ctrl_request_hdl_ctrl_find(hdl,
                                               vicodec_ctrl_stateless_state.id);
+       v4l2_ctrl_request_hdl_put(hdl);
        if (!ctrl) {
                v4l2_info(&ctx->dev->v4l2_dev,
                          "Missing required codec control\n");