ASoC: qcom: remove duplicate initializations of dma_ch and v
authorColin Ian King <colin.king@canonical.com>
Mon, 18 Sep 2017 09:26:03 +0000 (10:26 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 19 Sep 2017 11:57:06 +0000 (12:57 +0100)
dma_ch is being initialized to zero and then immediately afterwards
being updated again, so the first initialization is redundant and
can be remove.

Likewise, the pointer v is being initialized twice, so remove the second
duplicate initialization.

Cleans up two clang build warnings:
warning: Value stored to 'dma_ch' is never read
warning: Value stored to 'v' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass-platform.c

index e1945e1772cda976a1a9c689c5f36c750e5a3ff2..caf71aab8196bd0179114b70cf653bfcb56b4f8f 100644 (file)
@@ -74,7 +74,6 @@ static int lpass_platform_pcmops_open(struct snd_pcm_substream *substream)
        data->i2s_port = cpu_dai->driver->id;
        runtime->private_data = data;
 
-       dma_ch = 0;
        if (v->alloc_dma_channel)
                dma_ch = v->alloc_dma_channel(drvdata, dir);
        else
@@ -122,7 +121,6 @@ static int lpass_platform_pcmops_close(struct snd_pcm_substream *substream)
        struct lpass_pcm_data *data;
 
        data = runtime->private_data;
-       v = drvdata->variant;
        drvdata->substream[data->dma_ch] = NULL;
        if (v->free_dma_channel)
                v->free_dma_channel(drvdata, data->dma_ch);