[PATCH] zfcp: bugfix and compile fixes
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Sun, 28 Aug 2005 20:22:37 +0000 (13:22 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sun, 28 Aug 2005 20:53:48 +0000 (13:53 -0700)
Bugfix (usage of uninitialized pointer in zfcp_port_dequeue) and compile
fixes for the zfcp device driver.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/s390/scsi/zfcp_aux.c
drivers/s390/scsi/zfcp_ccw.c

index 6fed4a532ca3f6f097824f093f3e0e4c3c3e3874..bfe3ba73bc0f65310f58caa67e2b46412992d0c1 100644 (file)
@@ -1403,15 +1403,14 @@ zfcp_port_enqueue(struct zfcp_adapter *adapter, wwn_t wwpn, u32 status,
 void
 zfcp_port_dequeue(struct zfcp_port *port)
 {
-       struct fc_port *rport;
-
        zfcp_port_wait(port);
        write_lock_irq(&zfcp_data.config_lock);
        list_del(&port->list);
        port->adapter->ports--;
        write_unlock_irq(&zfcp_data.config_lock);
        if (port->rport)
-               fc_remote_port_delete(rport);
+               fc_remote_port_delete(port->rport);
+       port->rport = NULL;
        zfcp_adapter_put(port->adapter);
        zfcp_sysfs_port_remove_files(&port->sysfs_device,
                                     atomic_read(&port->status));
index 3c65aedaa97fab645645d5f85be2c821160d16ae..b30abab77da39841b8c0db3f37545fd3ae540b07 100644 (file)
@@ -203,7 +203,7 @@ zfcp_ccw_set_offline(struct ccw_device *ccw_device)
 {
        struct zfcp_adapter *adapter;
        struct zfcp_port *port;
-       struct fc_port *rport;
+       struct fc_rport *rport;
 
        down(&zfcp_data.config_sema);
        adapter = dev_get_drvdata(&ccw_device->dev);