btrfs: Fix possible softlock on single core machines
authorNikolay Borisov <>
Thu, 5 Apr 2018 07:40:15 +0000 (10:40 +0300)
committerDavid Sterba <>
Thu, 5 Apr 2018 17:22:35 +0000 (19:22 +0200)
do_chunk_alloc implements a loop checking whether there is a pending
chunk allocation and if so causes the caller do loop. Generally this
loop is executed only once, however testing with btrfs/072 on a single
core vm machines uncovered an extreme case where the system could loop
indefinitely. This is due to a missing cond_resched when loop which
doesn't give a chance to the previous chunk allocator finish its job.

The fix is to simply add the missing cond_resched.

Fixes: 6d74119f1a3e ("Btrfs: avoid taking the chunk_mutex in do_chunk_alloc")
Signed-off-by: Nikolay Borisov <>
Reviewed-by: David Sterba <>
Signed-off-by: David Sterba <>

index f30548d7e0d2ab663b189f9e37bafea993e55c1c..2caf9958f3e17937aa63cef22fe1c1085121dd7b 100644 (file)
@@ -4643,6 +4643,7 @@ again:
        if (wait_for_alloc) {
                wait_for_alloc = 0;
+               cond_resched();
                goto again;