net: hso: Fix -Wcast-function-type
authorPhong Tran <tranmanphong@gmail.com>
Tue, 26 Nov 2019 13:54:12 +0000 (20:54 +0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Nov 2019 22:03:58 +0000 (14:03 -0800)
correct usage prototype of callback in tasklet_init().
Report by https://github.com/KSPP/linux/issues/20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/hso.c

index 74849da031fab8f4944751b0fc78431fdfbbc8c8..ca827802f29179f3bfd28b80477122c21f41dd97 100644 (file)
@@ -1214,8 +1214,9 @@ static void hso_std_serial_read_bulk_callback(struct urb *urb)
  * This needs to be a tasklet otherwise we will
  * end up recursively calling this function.
  */
-static void hso_unthrottle_tasklet(struct hso_serial *serial)
+static void hso_unthrottle_tasklet(unsigned long data)
 {
+       struct hso_serial *serial = (struct hso_serial *)data;
        unsigned long flags;
 
        spin_lock_irqsave(&serial->serial_lock, flags);
@@ -1265,7 +1266,7 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)
                /* Force default termio settings */
                _hso_serial_set_termios(tty, NULL);
                tasklet_init(&serial->unthrottle_tasklet,
-                            (void (*)(unsigned long))hso_unthrottle_tasklet,
+                            hso_unthrottle_tasklet,
                             (unsigned long)serial);
                result = hso_start_serial_device(serial->parent, GFP_KERNEL);
                if (result) {