acer-wmi: fix regression in backlight detection
authorMichael Spang <>
Thu, 12 Mar 2009 21:31:34 +0000 (14:31 -0700)
committerLinus Torvalds <>
Thu, 12 Mar 2009 23:20:24 +0000 (16:20 -0700)
Currently we disable the Acer WMI backlight device if there is no ACPI
backlight device.  As a result, we end up with no backlight device at all.
 We should instead disable it if there is an ACPI device, as the other
laptop drivers do.  This regression was introduced in febf2d9 ("Acer-WMI:
fingers off backlight if video.ko is serving this functionality").

Each laptop driver with backlight support got a similar change around
febf2d9.  The changes to the other drivers look correct; see e.g.
a598c82f for a similar but correct change.  The regression is also in

Signed-off-by: Michael Spang <>
Acked-by: Thomas Renninger <>
Cc: Zhang Rui <>
Cc: Andi Kleen <>
Cc: Carlos Corbacho <>
Cc: Len Brown <>
Cc: "Rafael J. Wysocki" <>
Cc: <> [2.6.28.x]
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>

index 94c9f911824ef5b3279205a41a87dd169935f1db..6bcca616a70405bf057520b064a2a29dcf302078 100644 (file)
@@ -1297,7 +1297,7 @@ static int __init acer_wmi_init(void)
-       if (!acpi_video_backlight_support() && has_cap(ACER_CAP_BRIGHTNESS)) {
+       if (acpi_video_backlight_support() && has_cap(ACER_CAP_BRIGHTNESS)) {
                interface->capability &= ~ACER_CAP_BRIGHTNESS;
                printk(ACER_INFO "Brightness must be controlled by "
                       "generic video driver\n");