ASoC: dapm: Avoid creating kcontrol for params
authoranish kumar <yesanishhere@gmail.com>
Fri, 29 Sep 2017 04:52:39 +0000 (21:52 -0700)
committerMark Brown <broonie@kernel.org>
Thu, 5 Oct 2017 19:43:05 +0000 (20:43 +0100)
Currently in codec to codec dai link if there are multiple
params defined then dapm can use created kcontrol to
decide which param to apply at runtime.

However, in case there is only single param configuration
then there is no point in creating the kcontrol and also there
is no point in allocating memory for kcontrol.

In the snd_soc_dapm_new_pcm function, there is memory
allocation happening for kcontrol which is later used
or not used based on num_param. It is better to not
allocate memory when there is only a single configuration.
This change is to remedy that anomaly.

Signed-off-by: anish kumar <yesanishhere@gmail.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Tested-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c

index ba78a88d2af08270a827a8c4ef7252607b8a1a3c..44aed3383c62e4337276979bcfc6f7ae986221b5 100644 (file)
@@ -3778,18 +3778,27 @@ static int snd_soc_dapm_dai_link_put(struct snd_kcontrol *kcontrol,
        return 0;
 }
 
        return 0;
 }
 
-int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
-                        const struct snd_soc_pcm_stream *params,
-                        unsigned int num_params,
-                        struct snd_soc_dapm_widget *source,
-                        struct snd_soc_dapm_widget *sink)
+void
+snd_soc_dapm_free_kcontrol(struct snd_soc_card *card,
+                       unsigned long *private_value,
+                       int num_params,
+                       const char **w_param_text)
+{
+       int count;
+
+       devm_kfree(card->dev, (void *)*private_value);
+       for (count = 0 ; count < num_params; count++)
+               devm_kfree(card->dev, (void *)w_param_text[count]);
+       devm_kfree(card->dev, w_param_text);
+}
+
+static struct snd_kcontrol_new *
+snd_soc_dapm_alloc_kcontrol(struct snd_soc_card *card,
+                       char *link_name,
+                       const struct snd_soc_pcm_stream *params,
+                       int num_params, const char **w_param_text,
+                       unsigned long *private_value)
 {
 {
-       struct snd_soc_dapm_widget template;
-       struct snd_soc_dapm_widget *w;
-       char *link_name;
-       int ret, count;
-       unsigned long private_value;
-       const char **w_param_text;
        struct soc_enum w_param_enum[] = {
                SOC_ENUM_SINGLE(0, 0, 0, NULL),
        };
        struct soc_enum w_param_enum[] = {
                SOC_ENUM_SINGLE(0, 0, 0, NULL),
        };
@@ -3798,19 +3807,9 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
                             snd_soc_dapm_dai_link_get,
                             snd_soc_dapm_dai_link_put),
        };
                             snd_soc_dapm_dai_link_get,
                             snd_soc_dapm_dai_link_put),
        };
+       struct snd_kcontrol_new *kcontrol_news;
        const struct snd_soc_pcm_stream *config = params;
        const struct snd_soc_pcm_stream *config = params;
-
-       w_param_text = devm_kcalloc(card->dev, num_params,
-                                       sizeof(char *), GFP_KERNEL);
-       if (!w_param_text)
-               return -ENOMEM;
-
-       link_name = devm_kasprintf(card->dev, GFP_KERNEL, "%s-%s",
-                                  source->name, sink->name);
-       if (!link_name) {
-               ret = -ENOMEM;
-               goto outfree_w_param;
-       }
+       int count;
 
        for (count = 0 ; count < num_params; count++) {
                if (!config->stream_name) {
 
        for (count = 0 ; count < num_params; count++) {
                if (!config->stream_name) {
@@ -3827,47 +3826,86 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
                                                strlen(config->stream_name) + 1,
                                                GFP_KERNEL);
                }
                                                strlen(config->stream_name) + 1,
                                                GFP_KERNEL);
                }
-               if (!w_param_text[count]) {
-                       ret = -ENOMEM;
-                       goto outfree_link_name;
-               }
+               if (!w_param_text[count])
+                       goto outfree_w_param;
                config++;
        }
                config++;
        }
+
        w_param_enum[0].items = num_params;
        w_param_enum[0].texts = w_param_text;
 
        w_param_enum[0].items = num_params;
        w_param_enum[0].texts = w_param_text;
 
-       memset(&template, 0, sizeof(template));
-       template.reg = SND_SOC_NOPM;
-       template.id = snd_soc_dapm_dai_link;
-       template.name = link_name;
-       template.event = snd_soc_dai_link_event;
-       template.event_flags = SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU |
-               SND_SOC_DAPM_PRE_PMD;
-       template.num_kcontrols = 1;
-       /* duplicate w_param_enum on heap so that memory persists */
-       private_value =
+       *private_value =
                (unsigned long) devm_kmemdup(card->dev,
                        (void *)(kcontrol_dai_link[0].private_value),
                        sizeof(struct soc_enum), GFP_KERNEL);
                (unsigned long) devm_kmemdup(card->dev,
                        (void *)(kcontrol_dai_link[0].private_value),
                        sizeof(struct soc_enum), GFP_KERNEL);
-       if (!private_value) {
+       if (!*private_value) {
                dev_err(card->dev, "ASoC: Failed to create control for %s widget\n",
                        link_name);
                dev_err(card->dev, "ASoC: Failed to create control for %s widget\n",
                        link_name);
-               ret = -ENOMEM;
-               goto outfree_link_name;
+               goto outfree_w_param;
        }
        }
-       kcontrol_dai_link[0].private_value = private_value;
+       kcontrol_dai_link[0].private_value = *private_value;
        /* duplicate kcontrol_dai_link on heap so that memory persists */
        /* duplicate kcontrol_dai_link on heap so that memory persists */
-       template.kcontrol_news =
-                               devm_kmemdup(card->dev, &kcontrol_dai_link[0],
+       kcontrol_news = devm_kmemdup(card->dev, &kcontrol_dai_link[0],
                                        sizeof(struct snd_kcontrol_new),
                                        GFP_KERNEL);
                                        sizeof(struct snd_kcontrol_new),
                                        GFP_KERNEL);
-       if (!template.kcontrol_news) {
+       if (!kcontrol_news) {
                dev_err(card->dev, "ASoC: Failed to create control for %s widget\n",
                        link_name);
                dev_err(card->dev, "ASoC: Failed to create control for %s widget\n",
                        link_name);
-               ret = -ENOMEM;
-               goto outfree_private_value;
+               goto outfree_w_param;
        }
        }
+       return kcontrol_news;
 
 
+outfree_w_param:
+       snd_soc_dapm_free_kcontrol(card, private_value, num_params, w_param_text);
+       return NULL;
+}
+
+int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
+                        const struct snd_soc_pcm_stream *params,
+                        unsigned int num_params,
+                        struct snd_soc_dapm_widget *source,
+                        struct snd_soc_dapm_widget *sink)
+{
+       struct snd_soc_dapm_widget template;
+       struct snd_soc_dapm_widget *w;
+       const char **w_param_text;
+       unsigned long private_value;
+       char *link_name;
+       int ret;
+
+       link_name = devm_kasprintf(card->dev, GFP_KERNEL, "%s-%s",
+                                  source->name, sink->name);
+       if (!link_name)
+               return -ENOMEM;
+
+       memset(&template, 0, sizeof(template));
+       template.reg = SND_SOC_NOPM;
+       template.id = snd_soc_dapm_dai_link;
+       template.name = link_name;
+       template.event = snd_soc_dai_link_event;
+       template.event_flags = SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU |
+               SND_SOC_DAPM_PRE_PMD;
+       template.kcontrol_news = NULL;
+
+       /* allocate memory for control, only in case of multiple configs */
+       if (num_params > 1) {
+               w_param_text = devm_kcalloc(card->dev, num_params,
+                                       sizeof(char *), GFP_KERNEL);
+               if (!w_param_text) {
+                       ret = -ENOMEM;
+                       goto param_fail;
+               }
+
+               template.num_kcontrols = 1;
+               template.kcontrol_news =
+                                       snd_soc_dapm_alloc_kcontrol(card,
+                                               link_name, params, num_params,
+                                               w_param_text, &private_value);
+               if (!template.kcontrol_news) {
+                       ret = -ENOMEM;
+                       goto param_fail;
+               }
+       }
        dev_dbg(card->dev, "ASoC: adding %s widget\n", link_name);
 
        w = snd_soc_dapm_new_control_unlocked(&card->dapm, &template);
        dev_dbg(card->dev, "ASoC: adding %s widget\n", link_name);
 
        w = snd_soc_dapm_new_control_unlocked(&card->dapm, &template);
@@ -3899,15 +3937,9 @@ outfree_w:
        devm_kfree(card->dev, w);
 outfree_kcontrol_news:
        devm_kfree(card->dev, (void *)template.kcontrol_news);
        devm_kfree(card->dev, w);
 outfree_kcontrol_news:
        devm_kfree(card->dev, (void *)template.kcontrol_news);
-outfree_private_value:
-       devm_kfree(card->dev, (void *)private_value);
-outfree_link_name:
+       snd_soc_dapm_free_kcontrol(card, &private_value, num_params, w_param_text);
+param_fail:
        devm_kfree(card->dev, link_name);
        devm_kfree(card->dev, link_name);
-       for (count = 0 ; count < num_params; count++)
-               devm_kfree(card->dev, (void *)w_param_text[count]);
-outfree_w_param:
-       devm_kfree(card->dev, w_param_text);
-
        return ret;
 }
 
        return ret;
 }