Revert "driver core: add error handling for devtmpfs_create_node()"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2023 07:59:33 +0000 (08:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2023 08:01:30 +0000 (09:01 +0100)
This reverts commit 31b4b6730fd4f5d503c9f23619c920ce7b794754 as it is
reported to cause boot regressions.

Link: https://lore.kernel.org/r/Y+rSXg14z1Myd8Px@dev-arch.thelio-3990X
Reported-by: Nathan Chancellor <nathan@kernel.org>
Cc: Longlong Xia <xialonglong1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c

index 4fc6f27641bfca3871d3a7c1815c78fdcf6d2ffc..f9297c68214ae47db140860222f4bcf5e709d85f 100644 (file)
@@ -3602,9 +3602,7 @@ int device_add(struct device *dev)
                if (error)
                        goto SysEntryError;
 
-               error = devtmpfs_create_node(dev);
-               if (error)
-                       goto DevtmpfsError;
+               devtmpfs_create_node(dev);
        }
 
        /* Notify clients of device addition.  This call must come
@@ -3660,8 +3658,6 @@ int device_add(struct device *dev)
 done:
        put_device(dev);
        return error;
- DevtmpfsError:
-       device_remove_sys_dev_entry(dev);
  SysEntryError:
        if (MAJOR(dev->devt))
                device_remove_file(dev, &dev_attr_dev);