USB: typec: tcpm: create debugfs subdir for the driver
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Feb 2021 14:46:45 +0000 (15:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:37:16 +0000 (09:37 +0100)
The single debugfs file for this driver really is a log file, so make a
subdir and call it "log" to make it obvious this is what it is for.
This makes cleanup simpler as we just remove the whole directory, no
need to handle individual files anymore.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20210216144645.3813043-6-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpm.c

index 8469c37a59e17d6ba5022764e5a725238b4b4a75..16bda6cea7b889cf64cb37b79d699795a9fa77b3 100644 (file)
@@ -709,8 +709,9 @@ static void tcpm_debugfs_init(struct tcpm_port *port)
 
        mutex_init(&port->logbuffer_lock);
        snprintf(name, NAME_MAX, "tcpm-%s", dev_name(port->dev));
-       port->dentry = debugfs_create_file(name, S_IFREG | 0444, usb_debug_root,
-                                          port, &tcpm_debug_fops);
+       port->dentry = debugfs_create_dir(name, usb_debug_root);
+       debugfs_create_file("log", S_IFREG | 0444, port->dentry, port,
+                           &tcpm_debug_fops);
 }
 
 static void tcpm_debugfs_exit(struct tcpm_port *port)