x86/asm/entry: Zero EXTRA_REGS for stub32_execve() too
authorDenys Vlasenko <dvlasenk@redhat.com>
Tue, 7 Apr 2015 20:43:39 +0000 (22:43 +0200)
committerIngo Molnar <mingo@kernel.org>
Thu, 9 Apr 2015 08:31:24 +0000 (10:31 +0200)
The change which affected how execve clears EXTRA_REGS missed
32-bit execve syscalls.

Fix this by using 64-bit execve stub epilogue for them too.


Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Drewry <wad@chromium.org>
Link: http://lkml.kernel.org/r/1428439424-7258-3-git-send-email-dvlasenk@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

index 5d8f987a340dfa5d5efad24c99e3a585691b707a..a821b1cd4fa7a2748cce60ba986ef63d27efb131 100644 (file)
@@ -571,8 +571,6 @@ GLOBAL(\label)
        PTREGSCALL stub32_rt_sigreturn, sys32_rt_sigreturn
        PTREGSCALL stub32_sigreturn, sys32_sigreturn
-       PTREGSCALL stub32_execve, compat_sys_execve
-       PTREGSCALL stub32_execveat, compat_sys_execveat
        PTREGSCALL stub32_fork, sys_fork
        PTREGSCALL stub32_vfork, sys_vfork
index f7d9ba6f73a31ccec2e7839c4e7c86e22881c770..5380b3a8f3e574bcaf9124e2a67a185d828ab727 100644 (file)
@@ -538,6 +538,21 @@ ENTRY(stub_x32_execveat)
+       call    compat_sys_execve
+       jmp     return_from_execve
+       call    compat_sys_execveat
+       jmp     return_from_execve
  * sigreturn is special because it needs to restore all registers on return.
  * This cannot be done with SYSRET, so use the IRET return path instead.