media: rc: be less noisy when driver misbehaves
authorSean Young <sean@mess.org>
Tue, 26 Jun 2018 15:03:18 +0000 (11:03 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 27 Jun 2018 14:03:45 +0000 (10:03 -0400)
Since commit 48231f289e52 ("media: rc: drivers should produce alternate
pulse and space timing events"), on meson-ir we are regularly producing
errors. Reduce to warning level and only warn once to avoid flooding
the log.

A proper fix for meson-ir is going to be too large for v4.18.

Signed-off-by: Sean Young <sean@mess.org>
Cc: stable@vger.kernel.org # 4.17+
Tested-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/rc/rc-ir-raw.c

index 2e0066b1a31ce31cd46d11573fefbc65ccb89079..e7948908e78c80194cf40b194054afcfb13df46a 100644 (file)
@@ -30,13 +30,13 @@ static int ir_raw_event_thread(void *data)
                while (kfifo_out(&raw->kfifo, &ev, 1)) {
                        if (is_timing_event(ev)) {
                                if (ev.duration == 0)
-                                       dev_err(&dev->dev, "nonsensical timing event of duration 0");
+                                       dev_warn_once(&dev->dev, "nonsensical timing event of duration 0");
                                if (is_timing_event(raw->prev_ev) &&
                                    !is_transition(&ev, &raw->prev_ev))
-                                       dev_err(&dev->dev, "two consecutive events of type %s",
-                                               TO_STR(ev.pulse));
+                                       dev_warn_once(&dev->dev, "two consecutive events of type %s",
+                                                     TO_STR(ev.pulse));
                                if (raw->prev_ev.reset && ev.pulse == 0)
-                                       dev_err(&dev->dev, "timing event after reset should be pulse");
+                                       dev_warn_once(&dev->dev, "timing event after reset should be pulse");
                        }
                        list_for_each_entry(handler, &ir_raw_handler_list, list)
                                if (dev->enabled_protocols &