Input: adp5588-keys - do not explicitly set device as wakeup source
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 31 May 2022 21:08:40 +0000 (14:08 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 31 May 2022 21:09:43 +0000 (14:09 -0700)
I2C core will set up device as a wakeup source and will configure interrupt
as a wakeup interrupt if client is created with I2C_CLIENT_WAKE flag. Let's
rely on this facility and to not unconditionally set up the device as
wakeup device in the driver.

Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20220528045631.289821-4-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/adp5588-keys.c

index 1bd1ed66ee2a9784605cbd4035be5a4f3f608958..1a1a05d7cd4205deeb857bbfc6f5c85e6df0bc5b 100644 (file)
@@ -588,8 +588,6 @@ static int adp5588_probe(struct i2c_client *client,
        if (error)
                return error;
 
-       device_init_wakeup(&client->dev, 1);
-
        dev_info(&client->dev, "Rev.%d keypad, irq %d\n", revid, client->irq);
        return 0;
 }
@@ -608,9 +606,6 @@ static int __maybe_unused adp5588_suspend(struct device *dev)
 
        disable_irq(client->irq);
 
-       if (device_may_wakeup(&client->dev))
-               enable_irq_wake(client->irq);
-
        return 0;
 }
 
@@ -618,9 +613,6 @@ static int __maybe_unused adp5588_resume(struct device *dev)
 {
        struct i2c_client *client = to_i2c_client(dev);
 
-       if (device_may_wakeup(&client->dev))
-               disable_irq_wake(client->irq);
-
        enable_irq(client->irq);
 
        return 0;