ASoC: soc-core: Hold client_mutex around soc_init_dai_link()
authorRohit kumar <rohitkr@codeaurora.org>
Thu, 10 Jan 2019 09:02:41 +0000 (14:32 +0530)
committerMark Brown <broonie@kernel.org>
Thu, 10 Jan 2019 12:04:28 +0000 (12:04 +0000)
soc_init_dai_link() calls soc_find_component() which needs
to be within client_mutex lock. Add client_mutex lock around
soc_init_dai_link() in snd_soc_register_card() to avoid
lockdep warning.

Fixes: 8780cf1142a5 ("ASoC: soc-core: defer card probe until all component is added to list")
Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c

index eec92f17dd1596aa2b6f083bbc12507254769885..0934b36645b3eabe89e559f21b1fec986e998c1c 100644 (file)
@@ -1027,6 +1027,7 @@ static int snd_soc_init_platform(struct snd_soc_card *card,
                                 struct snd_soc_dai_link *dai_link)
 {
        struct snd_soc_dai_link_component *platform = dai_link->platform;
+
        /*
         * FIXME
         *
@@ -2754,15 +2755,18 @@ int snd_soc_register_card(struct snd_soc_card *card)
        if (!card->name || !card->dev)
                return -EINVAL;
 
+       mutex_lock(&client_mutex);
        for_each_card_prelinks(card, i, link) {
 
                ret = soc_init_dai_link(card, link);
                if (ret) {
                        dev_err(card->dev, "ASoC: failed to init link %s\n",
                                link->name);
+                       mutex_unlock(&client_mutex);
                        return ret;
                }
        }
+       mutex_unlock(&client_mutex);
 
        dev_set_drvdata(card->dev, card);