net: fix possible user-after-free in skb_ext_add()
authorPaolo Abeni <pabeni@redhat.com>
Fri, 21 Dec 2018 18:03:13 +0000 (19:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Dec 2018 18:24:54 +0000 (10:24 -0800)
commite94e50bd88f7ed2f2d40c32c06efd61c36c33ec8
tree1f55d0dc8ed86a0de8756571386ae6a9922bcbac
parent7fa4bd739fc0fa209fa5120383aab17f6e9600f7
net: fix possible user-after-free in skb_ext_add()

On cow we can free the old extension: we must avoid dereferencing
such extension after skb_ext_maybe_cow(). Since 'new' contents
are always equal to 'old' after the copy, we can fix the above
accessing the relevant data using 'new'.

Fixes: df5042f4c5b9 ("sk_buff: add skb extension infrastructure")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/skbuff.c