ALSA: PCM: check if ops are defined before suspending PCM
authorRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Fri, 8 Feb 2019 23:29:53 +0000 (17:29 -0600)
committerTakashi Iwai <tiwai@suse.de>
Mon, 11 Feb 2019 16:04:25 +0000 (17:04 +0100)
commitd9c0b2afe820fa3b3f8258a659daee2cc71ca3ef
tree165d2ab2cff3c31d3a3c91ea2a9c960810c2a185
parentbb580602f3924976d8bc36c171266de73e92cbf7
ALSA: PCM: check if ops are defined before suspending PCM

BE dai links only have internal PCM's and their substream ops may
not be set. Suspending these PCM's will result in their
 ops->trigger() being invoked and cause a kernel oops.
So skip suspending PCM's if their ops are NULL.

[ NOTE: this change is required now for following the recent PCM core
  change to get rid of snd_pcm_suspend() call.  Since DPCM BE takes
  the runtime carried from FE while keeping NULL ops, it can hit this
  bug.  See details at:
     https://github.com/thesofproject/linux/pull/582
  -- tiwai ]

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_native.c