random: move rand_initialize() earlier
authorKees Cook <keescook@chromium.org>
Sat, 20 Apr 2019 03:27:05 +0000 (23:27 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 20 Apr 2019 03:27:05 +0000 (23:27 -0400)
commitd55535232c3dbde9a523a9d10d68670f5fe5dec3
tree43265cdcfde71ed2fdbd562c17f034c28aab15bc
parenteb9d1bf079bb438d1a066d72337092935fc770f6
random: move rand_initialize() earlier

Right now rand_initialize() is run as an early_initcall(), but it only
depends on timekeeping_init() (for mixing ktime_get_real() into the
pools). However, the call to boot_init_stack_canary() for stack canary
initialization runs earlier, which triggers a warning at boot:

random: get_random_bytes called from start_kernel+0x357/0x548 with crng_init=0

Instead, this moves rand_initialize() to after timekeeping_init(), and moves
canary initialization here as well.

Note that this warning may still remain for machines that do not have
UEFI RNG support (which initializes the RNG pools during setup_arch()),
or for x86 machines without RDRAND (or booting without "random.trust=on"
or CONFIG_RANDOM_TRUST_CPU=y).

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
drivers/char/random.c
include/linux/random.h
init/main.c