scsi: hisi_sas: redefine hisi_sas_phy.phy_type as u32
authorJohn Garry <john.garry@huawei.com>
Mon, 26 Jun 2017 10:27:28 +0000 (18:27 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 26 Jun 2017 19:01:04 +0000 (15:01 -0400)
commitd0ef10c9a42ee2008a5106d04ed34a53b9c6e6c6
tree0de16ade2aa1f44f6ee2d7c67e406233fac390d6
parent6e9017feaaaaaaa02069cfb267b13f625f9cf6d7
scsi: hisi_sas: redefine hisi_sas_phy.phy_type as u32

Element phy_type is a bitmask and it only ever has 2 bits possibly set,
and it is overkill to define as a u64, so redefine as a u32.

This change resolves static code check complaint that "phy->phy_type &=
~PORT_TYPE_SAS;" would unintentionally clear the high 32 bits as well.

Structure hisi_sas_phy is also reordered to ensure packing efficiency.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas.h