ring_buffer: fix typing mistake
authorLai Jiangshan <laijs@cn.fujitsu.com>
Mon, 9 Feb 2009 06:21:14 +0000 (14:21 +0800)
committerSteven Rostedt <srostedt@redhat.com>
Tue, 10 Feb 2009 14:17:19 +0000 (09:17 -0500)
commitb85fa01ed958ca59523a2db3c2ee647b98745d6a
tree8afcb14110ff875e53a98f0df2c2f427389c2bf0
parent34cd4998d38f9bd04f34b78a7cb0c7f1bee00bd9
ring_buffer: fix typing mistake

Impact: Fix bug

I found several very very curious line.
It's so curious that it may be brought by typing mistake.

When (cpu_buffer->reader_page == cpu_buffer->commit_page):

1) We haven't copied it for bpage is changed:
   bpage = cpu_buffer->reader_page->page;
   memcpy(bpage->data, cpu_buffer->reader_page->page->data + read ... )
2) We need update cpu_buffer->reader_page->read, but
   "cpu_buffer->reader_page += read;" is not right.

[
  This bug was a typo. The commit->reader_page is a page pointer
  and not an index into the page. The line should have been
  commit->reader_page->read += read.  The other changes
  by Lai are nice clean ups to the code.  - SDR
]

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
kernel/trace/ring_buffer.c