usb: renesas_usbhs: gadget: fix unused-but-set-variable warning
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Fri, 28 Jul 2017 10:28:57 +0000 (19:28 +0900)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Thu, 3 Aug 2017 09:33:05 +0000 (12:33 +0300)
commitb7d44c36a6f6d956e1539e0dd42f98b26e5a4684
tree33a3e4b37c21ed3e0b37bbf363033519bfa04e08
parent2acecd58969897795cf015c9057ebd349a3fda8a
usb: renesas_usbhs: gadget: fix unused-but-set-variable warning

The commit b8b9c974afee ("usb: renesas_usbhs: gadget: disable all eps
when the driver stops") causes the unused-but-set-variable warning.
But, if the usbhsg_ep_disable() will return non-zero value, udc/core.c
doesn't clear the ep->enabled flag. So, this driver should not return
non-zero value, if the pipe is zero because this means the pipe is
already disabled. Otherwise, the ep->enabled flag is never cleared
when the usbhsg_ep_disable() is called by the renesas_usbhs driver first.

Fixes: b8b9c974afee ("usb: renesas_usbhs: gadget: disable all eps when the driver stops")
Fixes: 11432050f070 ("usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable()")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/renesas_usbhs/mod_gadget.c