ecryptfs: remove private bin2hex implementation
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Tue, 20 Sep 2016 23:17:24 +0000 (01:17 +0200)
committerTyler Hicks <tyhicks@canonical.com>
Sat, 4 Nov 2017 22:16:41 +0000 (22:16 +0000)
commitabbae6d560c1d562c5c0d10785469734784ef961
treeabf569213a03de67189195351d2edbf89f90c0e4
parent0996b67df6c1354f2df09c33ac652c37e2e2471f
ecryptfs: remove private bin2hex implementation

Calling sprintf in a loop is not very efficient, and in any case, we
already have an implementation of bin-to-hex conversion in lib/ which
we might as well use.

Note that ecryptfs_to_hex used to nul-terminate the destination (and
the kernel doc was wrong about the required output size), while
bin2hex doesn't. [All but one user of ecryptfs_to_hex explicitly
nul-terminates the result anyway.]

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
[tyhicks: Include <linux/kernel.h> in ecryptfs_kernel.h]
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
fs/ecryptfs/crypto.c
fs/ecryptfs/ecryptfs_kernel.h