rxrpc: Call state should be read with READ_ONCE() under some circumstances
authorBaptiste Lepers <baptiste.lepers@gmail.com>
Tue, 12 Jan 2021 15:59:15 +0000 (15:59 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 13 Jan 2021 18:38:20 +0000 (10:38 -0800)
commita95d25dd7b94a5ba18246da09b4218f132fed60e
tree9e862148394de9b2ada9c57ca025b93160dd3a89
parentd52e419ac8b50c8bef41b398ed13528e75d7ad48
rxrpc: Call state should be read with READ_ONCE() under some circumstances

The call state may be changed at any time by the data-ready routine in
response to received packets, so if the call state is to be read and acted
upon several times in a function, READ_ONCE() must be used unless the call
state lock is held.

As it happens, we used READ_ONCE() to read the state a few lines above the
unmarked read in rxrpc_input_data(), so use that value rather than
re-reading it.

Fixes: a158bdd3247b ("rxrpc: Fix call timeouts")
Signed-off-by: Baptiste Lepers <baptiste.lepers@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/161046715522.2450566.488819910256264150.stgit@warthog.procyon.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rxrpc/input.c