agp: remove unnecessary pci_dev_put
authorJulia Lawall <julia@diku.dk>
Wed, 5 Dec 2007 21:55:36 +0000 (13:55 -0800)
committerDave Airlie <airlied@redhat.com>
Tue, 5 Feb 2008 04:33:33 +0000 (14:33 +1000)
commit91d361c279b66ce4d617d544641d5f70b27c401a
tree9991f26bf4f2cbccc3b7f2d7ea30b6fe593f92da
parent62f29babbc60ab572d3cecda981931d3a66123d6
agp: remove unnecessary pci_dev_put

pci_get_class implicitly does a pci_dev_put on its second argument, so
pci_dev_put is only needed if there is a break out of the loop.

The semantic match detecting this problem is as follows:

// <smpl>
@@
expression dev;
expression E;
@@

* pci_dev_put(dev)
  ... when != dev = E
(
* pci_get_device(...,dev)
|
* pci_get_device_reverse(...,dev)
|
* pci_get_subsys(...,dev)
|
* pci_get_class(...,dev)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Airlie <airlied@linux.ie>
drivers/char/agp/amd-k7-agp.c