drivers/ide: Use memdup_user
authorJulia Lawall <julia@diku.dk>
Fri, 4 Jun 2010 23:11:17 +0000 (16:11 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Aug 2010 10:17:53 +0000 (03:17 -0700)
commit7d543d8468348c44010c7b4e6fdd23a398779668
tree8d38259d1d2d4a6a8fca966f4c134e75e50b3df1
parent2a800b7bd926c739c07c1690579f03bbd6f1b5a3
drivers/ide: Use memdup_user

Use memdup_user when user data is immediately copied into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@

-  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+  to = memdup_user(from,size);
   if (
-      to==NULL
+      IS_ERR(to)
                 || ...) {
   <+... when != goto l1;
-  -ENOMEM
+  PTR_ERR(to)
   ...+>
   }
-  if (copy_from_user(to, from, size) != 0) {
-    <+... when != goto l2;
-    -EFAULT
-    ...+>
-  }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide-taskfile.c