drm: vc4: remove redundant check of plane being non-null
authorColin Ian King <colin.king@canonical.com>
Thu, 16 Mar 2017 18:54:18 +0000 (18:54 +0000)
committerEric Anholt <eric@anholt.net>
Fri, 17 Mar 2017 23:44:14 +0000 (16:44 -0700)
commit7b34734816d5170f40329598390de22d0166e4e9
treec5f6bb431a424aca2896dcf915f93cacc9d42ac2
parentcc2e6da1b5a8986dc2831d5b63f4d0a15704e4f1
drm: vc4: remove redundant check of plane being non-null

The pointer plane is always null on the error path at label 'fail'
hence the check if it is non-null is redundant. We can therefore
remove the check and the destruction of plane as well as the fail
error path and instead just return an -ENOMEM ERR_PTR.

Detected by CoverityScan, CID#1339532 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: http://patchwork.freedesktop.org/patch/msgid/20170316185418.32765-1-colin.king@canonical.com
drivers/gpu/drm/vc4/vc4_plane.c