perf bench: Fix NULL pointer dereference in "perf bench all"
authorPatrick Palka <patrick@parcs.ath.cx>
Wed, 12 Mar 2014 22:40:51 +0000 (18:40 -0400)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 14 Mar 2014 16:45:54 +0000 (13:45 -0300)
commit6eeefccdcfc2cc9697562e740bfe6c35fddd4e1c
tree8485c870071abd4d7600a5441ed3539beeebd9ec
parent0fae799e869b9b1ece8c04c714d0529da0b0bade
perf bench: Fix NULL pointer dereference in "perf bench all"

The for_each_bench() macro must check that the "benchmarks" field of a
collection is not NULL before dereferencing it because the "all"
collection in particular has a NULL "benchmarks" field (signifying that
it has no benchmarks to iterate over).

This fixes this NULL pointer dereference when running "perf bench all":

  [root@ssdandy ~]# perf bench all
  <SNIP>

  # Running mem/memset benchmark...
  # Copying 1MB Bytes ...

         2.453675 GB/Sec
        12.056327 GB/Sec (with prefault)

  Segmentation fault (core dumped)
  [root@ssdandy ~]#

Signed-off-by: Patrick Palka <patrick@parcs.ath.cx>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1394664051-6037-1-git-send-email-patrick@parcs.ath.cx
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-bench.c