wl1251: fix elp_work race condition
authorGrazvydas Ignotas <notasas@gmail.com>
Sun, 6 Mar 2011 17:23:37 +0000 (19:23 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 11 Mar 2011 19:15:35 +0000 (14:15 -0500)
commit5f6722ee63a45d4ad3412743d161ec54d6c32ccc
tree4eb2812a5f0dd9c6d538d74f48afee91bca06d90
parentd0c331aff99ca75f9aa0f794cf68b572d8ec7c5a
wl1251: fix elp_work race condition

While working on PS I've noticed elp_work is kicking rather often, and
sometimes the chip is put to sleep before 5ms delay expires. This
seems to happen because by the time wl1251_ps_elp_wakeup is called
elp_work might still be pending. After wakeup is done, the processing
may take some time, during which 5ms might expire and elp_work might
get scheduled. In this case, ss soon as 1st thread finishes work and
releases the mutex, elp_work will then put the device to sleep without
5ms delay. In addition 1st thread will queue additional elp_work
needlessly.

Fix this by cancelling work in wl1251_ps_elp_wakeup instead.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Acked-by: Kalle Valo <kvalo@adurom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wl1251/ps.c