ASoC: soc-core: dai_link check under soc_dpcm_debugfs_add()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Wed, 7 Aug 2019 01:31:36 +0000 (10:31 +0900)
committerMark Brown <broonie@kernel.org>
Thu, 8 Aug 2019 19:56:58 +0000 (20:56 +0100)
commit596becd3f82a7b7e091b0f5c380bc9a0e6758126
treeb4558a115b54b1fde4bbecbb3be721f7906699a3
parentee5b3f11416d1ba69e919b2fe86aae0b46f9a83e
ASoC: soc-core: dai_link check under soc_dpcm_debugfs_add()

soc_dpcm_debugfs_add(rtd) is checking rtd->dai_link pointer,
but, rtd->dai_link->dynamic have been already checked before calling it.

static int soc_probe_link_dais(...) {
dai_link = rtd->dai_link;
...
=> if (dai_link->dynamic)
=> soc_dpcm_debugfs_add(rtd);
...
}

void soc_dpcm_debugfs_add(rtd)
{
=> if (!rtd->dai_link)
return;
...
}

These pointer checks are strange/pointless.
This patch checks dai_link->dynamic under soc_dpcm_debugfs_add().

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/874l2tahnq.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c
sound/soc/soc-pcm.c