vt6655: Fix a possible sleep-in-atomic bug in vt6655_suspend
authorJia-Ju Bai <baijiaju1990@163.com>
Mon, 9 Oct 2017 08:45:55 +0000 (16:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Oct 2017 14:42:28 +0000 (16:42 +0200)
commit42c8eb3f6e15367981b274cb79ee4657e2c6949d
treec687e6cb40d2ba1078f014355302efacd38722fd
parent6e047ac922d8dd1293bdb9778bf2f2c0d699e9c6
vt6655: Fix a possible sleep-in-atomic bug in vt6655_suspend

The driver may sleep under a spinlock, and the function call path is:
vt6655_suspend (acquire the spinlock)
  pci_set_power_state
    __pci_start_power_transition (drivers/pci/pci.c)
      msleep --> may sleep

To fix it, pci_set_power_state is called without having a spinlock.

This bug is found by my static analysis tool and my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/device_main.c