net: phy: sfp: Fix unregistering of HWMON SFP device
authorAndrew Lunn <andrew@lunn.ch>
Mon, 24 Sep 2018 23:50:00 +0000 (01:50 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Sep 2018 03:23:31 +0000 (20:23 -0700)
commit3e322474485931e7ea6e4c5560089991a7f03cbc
tree6b1bf48c256946ca775c9ab0e7f6d0c77da5401d
parent77f2d753819b7d50c16abfb778caf1fe075faed0
net: phy: sfp: Fix unregistering of HWMON SFP device

A HWMON device is only registered is the SFP module supports the
diagnostic page and is complient to SFF8472. Don't unconditionally
unregister the hwmon device when the SFP module is remove, otherwise
we access data structures which don't exist.

Reported-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: 1323061a018a ("net: phy: sfp: Add HWMON support for module sensors")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/sfp.c