xfs: fix corruption case for block size < page size
authorEric Sandeen <sandeen@sandeen.net>
Wed, 23 Jun 2010 23:45:30 +0000 (09:45 +1000)
committerAlex Elder <aelder@sgi.com>
Mon, 26 Jul 2010 18:16:40 +0000 (13:16 -0500)
commit3d9b02e3c76531687ab5314e0edf266256f13c2d
treef730a4da55eb1536227ebe0f976f878f0e08181b
parentb4e9181e772b0c8b9038c5822ead368b96c2b533
xfs: fix corruption case for block size < page size

xfstests 194 first truncats a file back and then extends it again by
truncating it to a larger size.  This causes discard_buffer to drop
the mapped, but not the uptodate bit and thus creates something that
xfs_page_state_convert takes for unmapped space created by mmap because
it doesn't check for the dirty bit, which also gets cleared by
discard_buffer and checked by other ->writepage implementations like
block_write_full_page.  Handle this kind of buffers early, and unlike
Eric's first version of the patch simply ASSERT that the buffers is
dirty, given that the mmap write case can't happen anymore since the
introduction of ->page_mkwrite.  The now dead code dealing with that
will be deleted in a follow on patch.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
fs/xfs/linux-2.6/xfs_aops.c