nohz: Use IPI implicit full barrier against rq->nr_running r/w
authorFrederic Weisbecker <fweisbec@gmail.com>
Tue, 18 Mar 2014 21:54:04 +0000 (22:54 +0100)
committerFrederic Weisbecker <fweisbec@gmail.com>
Mon, 16 Jun 2014 14:27:24 +0000 (16:27 +0200)
commit3882ec643997757824cd5f25180cd8a787b9dbe1
tree82bbcc724d7dc4fc4442cc2a1699cd2ec9518725
parentfd2ac4f4a65a7f34b0bc6433fcca1192d7ba8b8e
nohz: Use IPI implicit full barrier against rq->nr_running r/w

A full dynticks CPU is allowed to stop its tick when a single task runs.
Meanwhile when a new task gets enqueued, the CPU must be notified so that
it can restart its tick to maintain local fairness and other accounting
details.

This notification is performed by way of an IPI. Then when the target
receives the IPI, we expect it to see the new value of rq->nr_running.

Hence the following ordering scenario:

   CPU 0                   CPU 1

   write rq->running       get IPI
   smp_wmb()               smp_rmb()
   send IPI                read rq->nr_running

But Paul Mckenney says that nowadays IPIs imply a full barrier on
all architectures. So we can safely remove this pair and rely on the
implicit barriers that come along IPI send/receive. Lets
just comment on this new assumption.

Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Kevin Hilman <khilman@linaro.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
kernel/sched/core.c
kernel/sched/sched.h