nvdimm: Split label init out from the logic for getting config data
authorAlexander Duyck <alexander.h.duyck@linux.intel.com>
Wed, 10 Oct 2018 23:39:20 +0000 (16:39 -0700)
committerDan Williams <dan.j.williams@intel.com>
Fri, 12 Oct 2018 15:39:24 +0000 (08:39 -0700)
commit2d657d17f72d2ae70c02f0d0ea6a04ad0f016b57
treedc29e62aec8df86f531adfdc3c706856ca8499e4
parent19418b024427ec60ba6084addf691a8d93670398
nvdimm: Split label init out from the logic for getting config data

This patch splits the initialization of the label data into two functions.
One for doing the init, and another for reading the actual configuration
data. The idea behind this is that by doing this we create a symmetry
between the getting and setting of config data in that we have a function
for both. In addition it will make it easier for us to identify the bits
that are related to init versus the pieces that are a wrapper for reading
data from the ACPI interface.

So for example by splitting things out like this it becomes much more
obvious that we were performing checks that weren't necessarily related to
the set/get operations such as relying on ndd->data being present when the
set and get ops should not care about a locally cached copy of the label
area.

Reviewed-by: Toshi Kani <toshi.kani@hpe.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/dimm.c
drivers/nvdimm/dimm_devs.c
drivers/nvdimm/label.c
drivers/nvdimm/label.h
drivers/nvdimm/nd.h