ACPICA: Avoid null pointer dereference on Op.
authorColin Ian King <colin.king@canonical.com>
Fri, 17 Nov 2017 23:40:17 +0000 (15:40 -0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 27 Nov 2017 00:20:28 +0000 (01:20 +0100)
commit29ad1f88ab7dd6c220ff9f5b9faed718b443f4a4
treeb2d3d236768804314dab98756e65ce823d16a76e
parentee470f08b07d6c3a07a8d9dd7d1817e68cdf3b86
ACPICA: Avoid null pointer dereference on Op.

ACPICA commit 08a00639b0d6756e8ba1421419fc3728904651d9

The calls to acpi_os_acquire_object can result in a null being assigned
to Op (for example if a mutex acquire fails) which can lead to a
null pointer dereference on Op on the call to ASL_CV_TRANSFER_COMMENTS
(via function cv_transfer_comments). Move the block into the previous
block that checks for a null Op so that we never can call
cv_transfer_comments with a null Op.

Detected by: coverity_scan CID#1371660 ("Dereference after null check")

Link: https://github.com/acpica/acpica/commit/08a00639
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Erik Schmauss <erik.schmauss@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpica/psutils.c