ALSA: seq: oss: Fix missing error check in snd_seq_oss_synth_make_info()
authorTakashi Iwai <tiwai@suse.de>
Fri, 15 Jan 2021 09:34:28 +0000 (10:34 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 15 Jan 2021 09:35:17 +0000 (10:35 +0100)
commit217bfbb8b0bfa24619b11ab75c135fec99b99b20
tree5205a300d11998ea5eb2539447a72f08fbc92932
parent67ea698c3950d10925be33c21ca49ffb64e21842
ALSA: seq: oss: Fix missing error check in snd_seq_oss_synth_make_info()

snd_seq_oss_synth_make_info() didn't check the error code from
snd_seq_oss_midi_make_info(), and this leads to the call of strlcpy()
with the uninitialized string as the source, which may lead to the
access over the limit.

Add the proper error check for avoiding the failure.

Reported-by: syzbot+e42504ff21cff05a595f@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210115093428.15882-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/oss/seq_oss_synth.c