scsi: libsas: Drop SAS_DPRINTK() and revise logs levels
authorJohn Garry <john.garry@huawei.com>
Thu, 15 Nov 2018 10:20:31 +0000 (18:20 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 15 Nov 2018 19:37:06 +0000 (14:37 -0500)
commit15ba7806c316ce88d45db7d12d32380f53c01a06
tree37af10a8d6ee1aad4267f1161726306c27a2d89d
parent71a4a9923122091be1167bac9379d5d1cfdb1153
scsi: libsas: Drop SAS_DPRINTK() and revise logs levels

Like sas_printk() did previously, SAS_DPRINTK() offers little value now
that libsas logs already have the "sas" prefix through pr_fmt(fmt). So it
can be dropped.

However, after reviewing some logs in libsas, it is noticed that debug
level is too low in many instances.

So this change drops SAS_DPRINTK() and revises some logs to a more
appropriate level. However many stay at debug level, although some
are significantly promoted.

We add -DDEBUG for compilation so that we keep the debug messages by
default, as before.

All the pre-existing checkpatch errors for spanning messages across
multiple lines are also fixed.

Finally, all other references to printk() [apart from special formatting
in sas_ata.c] are removed and replaced with appropriate pr_xxx().

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libsas/Makefile
drivers/scsi/libsas/sas_ata.c
drivers/scsi/libsas/sas_discover.c
drivers/scsi/libsas/sas_expander.c
drivers/scsi/libsas/sas_init.c
drivers/scsi/libsas/sas_internal.h
drivers/scsi/libsas/sas_port.c
drivers/scsi/libsas/sas_scsi_host.c
drivers/scsi/libsas/sas_task.c