SUNRPC: Change return value type of .pc_encode
authorChuck Lever <chuck.lever@oracle.com>
Wed, 13 Oct 2021 14:41:13 +0000 (10:41 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 13 Oct 2021 15:34:49 +0000 (11:34 -0400)
commit130e2054d4a652a2bd79fb1557ddcd19c053cb37
treefc1a90c03341d82a9d34816450a3277a0fd0c0b1
parentfda494411485aff91768842c532f90fb8eb54943
SUNRPC: Change return value type of .pc_encode

Returning an undecorated integer is an age-old trope, but it's
not clear (even to previous experts in this code) that the only
valid return values are 1 and 0. These functions do not return
a negative errno, rpc_stat value, or a positive length.

Document there are only two valid return values by having
.pc_encode return only true or false.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
16 files changed:
fs/lockd/xdr.c
fs/lockd/xdr4.c
fs/nfs/callback_xdr.c
fs/nfsd/nfs2acl.c
fs/nfsd/nfs3acl.c
fs/nfsd/nfs3xdr.c
fs/nfsd/nfs4xdr.c
fs/nfsd/nfsd.h
fs/nfsd/nfssvc.c
fs/nfsd/nfsxdr.c
fs/nfsd/xdr.h
fs/nfsd/xdr3.h
fs/nfsd/xdr4.h
include/linux/lockd/xdr.h
include/linux/lockd/xdr4.h
include/linux/sunrpc/svc.h