ipv4, route: pass 0 instead of LOOPBACK_IFINDEX to fib_validate_source()
authorCong Wang <cwang@twopensource.com>
Tue, 15 Apr 2014 23:25:35 +0000 (16:25 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Apr 2014 19:05:12 +0000 (15:05 -0400)
commit0d5edc68739f1c1e0519acbea1d3f0c1882a15d7
treef0e29586ba3af5fe02b569016bef1e596015fa3f
parent6a662719c9868b3d6c7d26b3a085f0cd3cc15e64
ipv4, route: pass 0 instead of LOOPBACK_IFINDEX to fib_validate_source()

In my special case, when a packet is redirected from veth0 to lo,
its skb->dev->ifindex would be LOOPBACK_IFINDEX. Meanwhile we
pass the hard-coded LOOPBACK_IFINDEX to fib_validate_source()
in ip_route_input_slow(). This would cause the following check
in fib_validate_source() fail:

            (dev->ifindex != oif || !IN_DEV_TX_REDIRECTS(idev))

when rp_filter is disabeld on loopback. As suggested by Julian,
the caller should pass 0 here so that we will not end up by
calling __fib_validate_source().

Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Julian Anastasov <ja@ssi.bg>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/route.c