git.samba.org / sfrench / cifs-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e02010a) | patch
bnx2x: remove zeroing of dump data buffer
authorMichal Schmidt <mschmidt@redhat.com>
Mon, 1 Jul 2013 15:23:05 +0000 (17:23 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Jul 2013 07:15:56 +0000 (00:15 -0700)
commit058eec4116935c5640299913e1e0715e87ec622a
treed006037c2fe6b47f99402d9cc2de415938ea51b0tree
parente02010adeeb21ef56d6b9b68c785ed1ecc832aeecommit | diff
bnx2x: remove zeroing of dump data buffer

There is no need to initialize the dump data with zeros.
data is allocated with vzalloc, so it's already zero-filled.

More importantly, the memset is harmful, because dump->len (the length
requested by userspace) can be bigger than the allocated buffer (whose
size is determined by asking the driver's .get_dump_flag method).

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.