idle / sleep: Avoid excessive disabling and enabling interrupts
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 26 Feb 2015 23:39:21 +0000 (00:39 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 28 Feb 2015 22:46:24 +0000 (23:46 +0100)
commit01e04f466e12e883907937eb04a9010533363f55
tree3c10e3c6c051d508bdf655d5e06162b328ffe7cf
parentc517d838eb7d07bbe9507871fab3931deccff539
idle / sleep: Avoid excessive disabling and enabling interrupts

Disabling interrupts at the end of cpuidle_enter_freeze() is not
useful, because its caller, cpuidle_idle_call(), re-enables them
right away after invoking it.

To avoid that unnecessary back and forth dance with interrupts,
make cpuidle_enter_freeze() enable interrupts after calling
enter_freeze_proper() and drop the local_irq_disable() at its
end, so that all of the code paths in it end up with interrupts
enabled.  Then, cpuidle_idle_call() will not need to re-enable
interrupts after calling cpuidle_enter_freeze() any more, because
the latter will return with interrupts enabled, in analogy with
cpuidle_enter().

Reported-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
drivers/cpuidle/cpuidle.c
kernel/sched/idle.c