ASoC: amd: Fix potential NULL pointer dereference
[sfrench/cifs-2.6.git] / sound / soc / amd / raven / acp3x-pcm-dma.c
index 94f915afd1b3fbab7a0832e221a8af30435691a2..3d58338fa3cf79b3d9c28351cfd9411167fe51a5 100644 (file)
@@ -1,22 +1,14 @@
-/*
- * AMD ALSA SoC PCM Driver
- *
- * Copyright 2016 Advanced Micro Devices, Inc.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// AMD ALSA SoC PCM Driver
+//
+//Copyright 2016 Advanced Micro Devices, Inc.
 
 #include <linux/platform_device.h>
 #include <linux/module.h>
 #include <linux/err.h>
 #include <linux/io.h>
+#include <linux/pm_runtime.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
 #define DRV_NAME "acp3x-i2s-audio"
 
 struct i2s_dev_data {
+       bool tdm_mode;
        unsigned int i2s_irq;
+       u32 tdm_fmt;
        void __iomem *acp3x_base;
        struct snd_pcm_substream *play_stream;
        struct snd_pcm_substream *capture_stream;
 };
 
+struct i2s_stream_instance {
+       u16 num_pages;
+       u16 channels;
+       u32 xfer_resolution;
+       struct page *pg;
+       void __iomem *acp3x_base;
+};
+
+static const struct snd_pcm_hardware acp3x_pcm_hardware_playback = {
+       .info = SNDRV_PCM_INFO_INTERLEAVED |
+               SNDRV_PCM_INFO_BLOCK_TRANSFER |
+               SNDRV_PCM_INFO_BATCH |
+               SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
+       .formats = SNDRV_PCM_FMTBIT_S16_LE |  SNDRV_PCM_FMTBIT_S8 |
+                  SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S24_LE |
+                  SNDRV_PCM_FMTBIT_S32_LE,
+       .channels_min = 2,
+       .channels_max = 8,
+       .rates = SNDRV_PCM_RATE_8000_96000,
+       .rate_min = 8000,
+       .rate_max = 96000,
+       .buffer_bytes_max = PLAYBACK_MAX_NUM_PERIODS * PLAYBACK_MAX_PERIOD_SIZE,
+       .period_bytes_min = PLAYBACK_MIN_PERIOD_SIZE,
+       .period_bytes_max = PLAYBACK_MAX_PERIOD_SIZE,
+       .periods_min = PLAYBACK_MIN_NUM_PERIODS,
+       .periods_max = PLAYBACK_MAX_NUM_PERIODS,
+};
+
+static const struct snd_pcm_hardware acp3x_pcm_hardware_capture = {
+       .info = SNDRV_PCM_INFO_INTERLEAVED |
+               SNDRV_PCM_INFO_BLOCK_TRANSFER |
+               SNDRV_PCM_INFO_BATCH |
+           SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
+       .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8 |
+                  SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S24_LE |
+                  SNDRV_PCM_FMTBIT_S32_LE,
+       .channels_min = 2,
+       .channels_max = 2,
+       .rates = SNDRV_PCM_RATE_8000_48000,
+       .rate_min = 8000,
+       .rate_max = 48000,
+       .buffer_bytes_max = CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
+       .period_bytes_min = CAPTURE_MIN_PERIOD_SIZE,
+       .period_bytes_max = CAPTURE_MAX_PERIOD_SIZE,
+       .periods_min = CAPTURE_MIN_NUM_PERIODS,
+       .periods_max = CAPTURE_MAX_NUM_PERIODS,
+};
+
 static int acp3x_power_on(void __iomem *acp3x_base, bool on)
 {
        u16 val, mask;
@@ -165,20 +207,362 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
                return IRQ_NONE;
 }
 
+static void config_acp3x_dma(struct i2s_stream_instance *rtd, int direction)
+{
+       u16 page_idx;
+       u64 addr;
+       u32 low, high, val, acp_fifo_addr;
+       struct page *pg = rtd->pg;
+
+       /* 8 scratch registers used to map one 64 bit address */
+       if (direction == SNDRV_PCM_STREAM_PLAYBACK)
+               val = 0;
+       else
+               val = rtd->num_pages * 8;
+
+       /* Group Enable */
+       rv_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp3x_base +
+                 mmACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
+       rv_writel(PAGE_SIZE_4K_ENABLE, rtd->acp3x_base +
+                 mmACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
+
+       for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
+               /* Load the low address of page int ACP SRAM through SRBM */
+               addr = page_to_phys(pg);
+               low = lower_32_bits(addr);
+               high = upper_32_bits(addr);
+
+               rv_writel(low, rtd->acp3x_base + mmACP_SCRATCH_REG_0 + val);
+               high |= BIT(31);
+               rv_writel(high, rtd->acp3x_base + mmACP_SCRATCH_REG_0 + val
+                               + 4);
+               /* Move to next physically contiguos page */
+               val += 8;
+               pg++;
+       }
+
+       if (direction == SNDRV_PCM_STREAM_PLAYBACK) {
+               /* Config ringbuffer */
+               rv_writel(MEM_WINDOW_START, rtd->acp3x_base +
+                         mmACP_BT_TX_RINGBUFADDR);
+               rv_writel(MAX_BUFFER, rtd->acp3x_base +
+                         mmACP_BT_TX_RINGBUFSIZE);
+               rv_writel(DMA_SIZE, rtd->acp3x_base + mmACP_BT_TX_DMA_SIZE);
+
+               /* Config audio fifo */
+               acp_fifo_addr = ACP_SRAM_PTE_OFFSET + (rtd->num_pages * 8)
+                               + PLAYBACK_FIFO_ADDR_OFFSET;
+               rv_writel(acp_fifo_addr, rtd->acp3x_base +
+                         mmACP_BT_TX_FIFOADDR);
+               rv_writel(FIFO_SIZE, rtd->acp3x_base + mmACP_BT_TX_FIFOSIZE);
+       } else {
+               /* Config ringbuffer */
+               rv_writel(MEM_WINDOW_START + MAX_BUFFER, rtd->acp3x_base +
+                         mmACP_BT_RX_RINGBUFADDR);
+               rv_writel(MAX_BUFFER, rtd->acp3x_base +
+                         mmACP_BT_RX_RINGBUFSIZE);
+               rv_writel(DMA_SIZE, rtd->acp3x_base + mmACP_BT_RX_DMA_SIZE);
+
+               /* Config audio fifo */
+               acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+                               (rtd->num_pages * 8) + CAPTURE_FIFO_ADDR_OFFSET;
+               rv_writel(acp_fifo_addr, rtd->acp3x_base +
+                         mmACP_BT_RX_FIFOADDR);
+               rv_writel(FIFO_SIZE, rtd->acp3x_base + mmACP_BT_RX_FIFOSIZE);
+       }
+
+       /* Enable  watermark/period interrupt to host */
+       rv_writel(BIT(BT_TX_THRESHOLD) | BIT(BT_RX_THRESHOLD),
+                 rtd->acp3x_base + mmACP_EXTERNAL_INTR_CNTL);
+}
+
+static int acp3x_dma_open(struct snd_pcm_substream *substream)
+{
+       int ret = 0;
+
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_soc_pcm_runtime *prtd = substream->private_data;
+       struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd,
+                                                                   DRV_NAME);
+       struct i2s_dev_data *adata = dev_get_drvdata(component->dev);
+
+       struct i2s_stream_instance *i2s_data = kzalloc(sizeof(struct i2s_stream_instance),
+                                                      GFP_KERNEL);
+       if (!i2s_data)
+               return -EINVAL;
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               runtime->hw = acp3x_pcm_hardware_playback;
+       else
+               runtime->hw = acp3x_pcm_hardware_capture;
+
+       ret = snd_pcm_hw_constraint_integer(runtime,
+                                           SNDRV_PCM_HW_PARAM_PERIODS);
+       if (ret < 0) {
+               dev_err(component->dev, "set integer constraint failed\n");
+               kfree(i2s_data);
+               return ret;
+       }
+
+       if (!adata->play_stream && !adata->capture_stream)
+               rv_writel(1, adata->acp3x_base + mmACP_EXTERNAL_INTR_ENB);
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               adata->play_stream = substream;
+       else
+               adata->capture_stream = substream;
+
+       i2s_data->acp3x_base = adata->acp3x_base;
+       runtime->private_data = i2s_data;
+       return 0;
+}
+
+static int acp3x_dma_hw_params(struct snd_pcm_substream *substream,
+                              struct snd_pcm_hw_params *params)
+{
+       int status;
+       u64 size;
+       struct page *pg;
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct i2s_stream_instance *rtd = runtime->private_data;
+
+       if (!rtd)
+               return -EINVAL;
+
+       size = params_buffer_bytes(params);
+       status = snd_pcm_lib_malloc_pages(substream, size);
+       if (status < 0)
+               return status;
+
+       memset(substream->runtime->dma_area, 0, params_buffer_bytes(params));
+       pg = virt_to_page(substream->dma_buffer.area);
+       if (pg) {
+               rtd->pg = pg;
+               rtd->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
+               config_acp3x_dma(rtd, substream->stream);
+               status = 0;
+       } else {
+               status = -ENOMEM;
+       }
+       return status;
+}
+
+static snd_pcm_uframes_t acp3x_dma_pointer(struct snd_pcm_substream *substream)
+{
+       u32 pos = 0;
+       struct i2s_stream_instance *rtd = substream->runtime->private_data;
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               pos = rv_readl(rtd->acp3x_base +
+                              mmACP_BT_TX_LINKPOSITIONCNTR);
+       else
+               pos = rv_readl(rtd->acp3x_base +
+                              mmACP_BT_RX_LINKPOSITIONCNTR);
+
+       if (pos >= MAX_BUFFER)
+               pos = 0;
+
+       return bytes_to_frames(substream->runtime, pos);
+}
+
+static int acp3x_dma_new(struct snd_soc_pcm_runtime *rtd)
+{
+       return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
+                                                    SNDRV_DMA_TYPE_DEV,
+                                                    NULL, MIN_BUFFER,
+                                                    MAX_BUFFER);
+}
+
+static int acp3x_dma_hw_free(struct snd_pcm_substream *substream)
+{
+       return snd_pcm_lib_free_pages(substream);
+}
+
+static int acp3x_dma_mmap(struct snd_pcm_substream *substream,
+                         struct vm_area_struct *vma)
+{
+       return snd_pcm_lib_default_mmap(substream, vma);
+}
+
+static int acp3x_dma_close(struct snd_pcm_substream *substream)
+{
+       struct snd_soc_pcm_runtime *prtd = substream->private_data;
+       struct i2s_stream_instance *rtd = substream->runtime->private_data;
+       struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd,
+                                                                   DRV_NAME);
+       struct i2s_dev_data *adata = dev_get_drvdata(component->dev);
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               adata->play_stream = NULL;
+       else
+               adata->capture_stream = NULL;
+
+       /* Disable ACP irq, when the current stream is being closed and
+        * another stream is also not active.
+        */
+       if (!adata->play_stream && !adata->capture_stream)
+               rv_writel(0, adata->acp3x_base + mmACP_EXTERNAL_INTR_ENB);
+       kfree(rtd);
+       return 0;
+}
+
 static struct snd_pcm_ops acp3x_dma_ops = {
-       .open = NULL,
-       .close = NULL,
-       .ioctl = NULL,
-       .hw_params = NULL,
-       .hw_free = NULL,
-       .pointer = NULL,
-       .mmap = NULL,
+       .open = acp3x_dma_open,
+       .close = acp3x_dma_close,
+       .ioctl = snd_pcm_lib_ioctl,
+       .hw_params = acp3x_dma_hw_params,
+       .hw_free = acp3x_dma_hw_free,
+       .pointer = acp3x_dma_pointer,
+       .mmap = acp3x_dma_mmap,
 };
 
+
+static int acp3x_dai_i2s_set_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
+{
+
+       struct i2s_dev_data *adata = snd_soc_dai_get_drvdata(cpu_dai);
+
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       case SND_SOC_DAIFMT_I2S:
+               adata->tdm_mode = false;
+               break;
+       case SND_SOC_DAIFMT_DSP_A:
+               adata->tdm_mode = true;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int acp3x_dai_set_tdm_slot(struct snd_soc_dai *cpu_dai, u32 tx_mask,
+                                 u32 rx_mask, int slots, int slot_width)
+{
+       u32 val = 0;
+       u16 slot_len;
+
+       struct i2s_dev_data *adata = snd_soc_dai_get_drvdata(cpu_dai);
+
+       switch (slot_width) {
+       case SLOT_WIDTH_8:
+               slot_len = 8;
+               break;
+       case SLOT_WIDTH_16:
+               slot_len = 16;
+               break;
+       case SLOT_WIDTH_24:
+               slot_len = 24;
+               break;
+       case SLOT_WIDTH_32:
+               slot_len = 0;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       val = rv_readl(adata->acp3x_base + mmACP_BTTDM_ITER);
+       rv_writel((val | 0x2), adata->acp3x_base + mmACP_BTTDM_ITER);
+       val = rv_readl(adata->acp3x_base + mmACP_BTTDM_IRER);
+       rv_writel((val | 0x2), adata->acp3x_base + mmACP_BTTDM_IRER);
+
+       val = (FRM_LEN | (slots << 15) | (slot_len << 18));
+       rv_writel(val, adata->acp3x_base + mmACP_BTTDM_TXFRMT);
+       rv_writel(val, adata->acp3x_base + mmACP_BTTDM_RXFRMT);
+
+       adata->tdm_fmt = val;
+       return 0;
+}
+
+static int acp3x_dai_i2s_hwparams(struct snd_pcm_substream *substream,
+                                 struct snd_pcm_hw_params *params,
+                                 struct snd_soc_dai *dai)
+{
+       u32 val = 0;
+       struct i2s_stream_instance *rtd = substream->runtime->private_data;
+
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_U8:
+       case SNDRV_PCM_FORMAT_S8:
+               rtd->xfer_resolution = 0x0;
+               break;
+       case SNDRV_PCM_FORMAT_S16_LE:
+               rtd->xfer_resolution = 0x02;
+               break;
+       case SNDRV_PCM_FORMAT_S24_LE:
+               rtd->xfer_resolution = 0x04;
+               break;
+       case SNDRV_PCM_FORMAT_S32_LE:
+               rtd->xfer_resolution = 0x05;
+               break;
+       default:
+               return -EINVAL;
+       }
+       val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER);
+       val = val | (rtd->xfer_resolution  << 3);
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER);
+       else
+               rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_IRER);
+
+       return 0;
+}
+
+static int acp3x_dai_i2s_trigger(struct snd_pcm_substream *substream,
+                                int cmd, struct snd_soc_dai *dai)
+{
+       int ret = 0;
+       struct i2s_stream_instance *rtd = substream->runtime->private_data;
+       u32 val, period_bytes;
+
+       period_bytes = frames_to_bytes(substream->runtime,
+                                      substream->runtime->period_size);
+       switch (cmd) {
+       case SNDRV_PCM_TRIGGER_START:
+       case SNDRV_PCM_TRIGGER_RESUME:
+       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+                       rv_writel(period_bytes, rtd->acp3x_base +
+                                 mmACP_BT_TX_INTR_WATERMARK_SIZE);
+                       val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER);
+                       val = val | BIT(0);
+                       rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER);
+               } else {
+                       rv_writel(period_bytes, rtd->acp3x_base +
+                                 mmACP_BT_RX_INTR_WATERMARK_SIZE);
+                       val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_IRER);
+                       val = val | BIT(0);
+                       rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_IRER);
+               }
+               rv_writel(1, rtd->acp3x_base + mmACP_BTTDM_IER);
+               break;
+       case SNDRV_PCM_TRIGGER_STOP:
+       case SNDRV_PCM_TRIGGER_SUSPEND:
+       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+                       val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER);
+                       val = val & ~BIT(0);
+                       rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER);
+               } else {
+                       val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_IRER);
+                       val = val & ~BIT(0);
+                       rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_IRER);
+               }
+               rv_writel(0, rtd->acp3x_base + mmACP_BTTDM_IER);
+               break;
+       default:
+               ret = -EINVAL;
+               break;
+       }
+
+       return ret;
+}
+
 struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
-       .hw_params = NULL,
-       .trigger   = NULL,
-       .set_fmt = NULL,
+       .hw_params = acp3x_dai_i2s_hwparams,
+       .trigger   = acp3x_dai_i2s_trigger,
+       .set_fmt = acp3x_dai_i2s_set_fmt,
+       .set_tdm_slot = acp3x_dai_set_tdm_slot,
 };
 
 static struct snd_soc_dai_driver acp3x_i2s_dai_driver = {
@@ -227,14 +611,16 @@ static int acp3x_audio_probe(struct platform_device *pdev)
        }
        irqflags = *((unsigned int *)(pdev->dev.platform_data));
 
-       adata = devm_kzalloc(&pdev->dev, sizeof(struct i2s_dev_data),
-                            GFP_KERNEL);
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (!res) {
                dev_err(&pdev->dev, "IORESOURCE_IRQ FAILED\n");
                        return -ENODEV;
        }
 
+       adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
+       if (!adata)
+               return -ENOMEM;
+
        adata->acp3x_base = devm_ioremap(&pdev->dev, res->start,
                                         resource_size(res));
 
@@ -267,6 +653,9 @@ static int acp3x_audio_probe(struct platform_device *pdev)
                goto dev_err;
        }
 
+       pm_runtime_set_autosuspend_delay(&pdev->dev, 10000);
+       pm_runtime_use_autosuspend(&pdev->dev);
+       pm_runtime_enable(&pdev->dev);
        return 0;
 dev_err:
        status = acp3x_deinit(adata->acp3x_base);
@@ -289,14 +678,95 @@ static int acp3x_audio_remove(struct platform_device *pdev)
        else
                dev_info(&pdev->dev, "ACP de-initialized\n");
 
+       pm_runtime_disable(&pdev->dev);
        return 0;
 }
 
+static int acp3x_resume(struct device *dev)
+{
+       int status;
+       u32 val;
+       struct i2s_dev_data *adata = dev_get_drvdata(dev);
+
+       status = acp3x_init(adata->acp3x_base);
+       if (status)
+               return -ENODEV;
+
+       if (adata->play_stream && adata->play_stream->runtime) {
+               struct i2s_stream_instance *rtd =
+                       adata->play_stream->runtime->private_data;
+               config_acp3x_dma(rtd, SNDRV_PCM_STREAM_PLAYBACK);
+               rv_writel((rtd->xfer_resolution  << 3),
+                         rtd->acp3x_base + mmACP_BTTDM_ITER);
+               if (adata->tdm_mode == true) {
+                       rv_writel(adata->tdm_fmt, adata->acp3x_base +
+                                 mmACP_BTTDM_TXFRMT);
+                       val = rv_readl(adata->acp3x_base + mmACP_BTTDM_ITER);
+                       rv_writel((val | 0x2), adata->acp3x_base +
+                                 mmACP_BTTDM_ITER);
+               }
+       }
+
+       if (adata->capture_stream && adata->capture_stream->runtime) {
+               struct i2s_stream_instance *rtd =
+                       adata->capture_stream->runtime->private_data;
+               config_acp3x_dma(rtd, SNDRV_PCM_STREAM_CAPTURE);
+               rv_writel((rtd->xfer_resolution  << 3),
+                         rtd->acp3x_base + mmACP_BTTDM_IRER);
+               if (adata->tdm_mode == true) {
+                       rv_writel(adata->tdm_fmt, adata->acp3x_base +
+                                 mmACP_BTTDM_RXFRMT);
+                       val = rv_readl(adata->acp3x_base + mmACP_BTTDM_IRER);
+                       rv_writel((val | 0x2), adata->acp3x_base +
+                                 mmACP_BTTDM_IRER);
+               }
+       }
+
+       rv_writel(1, adata->acp3x_base + mmACP_EXTERNAL_INTR_ENB);
+       return 0;
+}
+
+
+static int acp3x_pcm_runtime_suspend(struct device *dev)
+{
+       int status;
+       struct i2s_dev_data *adata = dev_get_drvdata(dev);
+
+       status = acp3x_deinit(adata->acp3x_base);
+       if (status)
+               dev_err(dev, "ACP de-init failed\n");
+       else
+               dev_info(dev, "ACP de-initialized\n");
+
+       rv_writel(0, adata->acp3x_base + mmACP_EXTERNAL_INTR_ENB);
+
+       return 0;
+}
+
+static int acp3x_pcm_runtime_resume(struct device *dev)
+{
+       int status;
+       struct i2s_dev_data *adata = dev_get_drvdata(dev);
+
+       status = acp3x_init(adata->acp3x_base);
+       if (status)
+               return -ENODEV;
+       rv_writel(1, adata->acp3x_base + mmACP_EXTERNAL_INTR_ENB);
+       return 0;
+}
+
+static const struct dev_pm_ops acp3x_pm_ops = {
+       .runtime_suspend = acp3x_pcm_runtime_suspend,
+       .runtime_resume = acp3x_pcm_runtime_resume,
+       .resume = acp3x_resume,
+};
+
 static struct platform_driver acp3x_dma_driver = {
        .probe = acp3x_audio_probe,
        .remove = acp3x_audio_remove,
        .driver = {
                .name = "acp3x_rv_i2s",
+               .pm = &acp3x_pm_ops,
        },
 };