Btrfs: fix spinlock assertions on UP systems
[sfrench/cifs-2.6.git] / fs / btrfs / disk-io.c
index 40a540f311619f28b8cdd448ab5ed78dec8a3b44..3e18175248e030ce37aa8dcd1edd400cb7d79e1e 100644 (file)
  * Boston, MA 021110-1307, USA.
  */
 
-#include <linux/version.h>
 #include <linux/fs.h>
 #include <linux/blkdev.h>
 #include <linux/scatterlist.h>
 #include <linux/swap.h>
 #include <linux/radix-tree.h>
 #include <linux/writeback.h>
-#include <linux/buffer_head.h> // for block_sync_page
+#include <linux/buffer_head.h>
 #include <linux/workqueue.h>
 #include <linux/kthread.h>
 #include <linux/freezer.h>
 #include "ref-cache.h"
 #include "tree-log.h"
 
-#if 0
-static int check_tree_block(struct btrfs_root *root, struct extent_buffer *buf)
-{
-       if (extent_buffer_blocknr(buf) != btrfs_header_blocknr(buf)) {
-               printk(KERN_CRIT "buf blocknr(buf) is %llu, header is %llu\n",
-                      (unsigned long long)extent_buffer_blocknr(buf),
-                      (unsigned long long)btrfs_header_blocknr(buf));
-               return 1;
-       }
-       return 0;
-}
-#endif
-
 static struct extent_io_ops btree_extent_io_ops;
 static void end_workqueue_fn(struct btrfs_work *work);
 
@@ -89,6 +75,40 @@ struct async_submit_bio {
        struct btrfs_work work;
 };
 
+/* These are used to set the lockdep class on the extent buffer locks.
+ * The class is set by the readpage_end_io_hook after the buffer has
+ * passed csum validation but before the pages are unlocked.
+ *
+ * The lockdep class is also set by btrfs_init_new_buffer on freshly
+ * allocated blocks.
+ *
+ * The class is based on the level in the tree block, which allows lockdep
+ * to know that lower nodes nest inside the locks of higher nodes.
+ *
+ * We also add a check to make sure the highest level of the tree is
+ * the same as our lockdep setup here.  If BTRFS_MAX_LEVEL changes, this
+ * code needs update as well.
+ */
+#ifdef CONFIG_DEBUG_LOCK_ALLOC
+# if BTRFS_MAX_LEVEL != 8
+#  error
+# endif
+static struct lock_class_key btrfs_eb_class[BTRFS_MAX_LEVEL + 1];
+static const char *btrfs_eb_name[BTRFS_MAX_LEVEL + 1] = {
+       /* leaf */
+       "btrfs-extent-00",
+       "btrfs-extent-01",
+       "btrfs-extent-02",
+       "btrfs-extent-03",
+       "btrfs-extent-04",
+       "btrfs-extent-05",
+       "btrfs-extent-06",
+       "btrfs-extent-07",
+       /* highest possible level */
+       "btrfs-extent-08",
+};
+#endif
+
 /*
  * extents on the btree inode are pretty simple, there's one extent
  * that covers the entire device
@@ -128,23 +148,13 @@ static struct extent_map *btree_get_extent(struct inode *inode,
                u64 failed_start = em->start;
                u64 failed_len = em->len;
 
-               printk("failed to insert %Lu %Lu -> %Lu into tree\n",
-                      em->start, em->len, em->block_start);
                free_extent_map(em);
                em = lookup_extent_mapping(em_tree, start, len);
                if (em) {
-                       printk("after failing, found %Lu %Lu %Lu\n",
-                              em->start, em->len, em->block_start);
                        ret = 0;
                } else {
                        em = lookup_extent_mapping(em_tree, failed_start,
                                                   failed_len);
-                       if (em) {
-                               printk("double failure lookup gives us "
-                                      "%Lu %Lu -> %Lu\n", em->start,
-                                      em->len, em->block_start);
-                               free_extent_map(em);
-                       }
                        ret = -EIO;
                }
        } else if (ret) {
@@ -191,15 +201,12 @@ static int csum_tree_block(struct btrfs_root *root, struct extent_buffer *buf,
        unsigned long inline_result;
 
        len = buf->len - offset;
-       while(len > 0) {
+       while (len > 0) {
                err = map_private_extent_buffer(buf, offset, 32,
                                        &map_token, &kaddr,
                                        &map_start, &map_len, KM_USER0);
-               if (err) {
-                       printk("failed to map extent buffer! %lu\n",
-                              offset);
+               if (err)
                        return 1;
-               }
                cur_len = min(len, map_len - (offset - map_start));
                crc = btrfs_csum_data(root, kaddr + offset - map_start,
                                      crc, cur_len);
@@ -218,15 +225,14 @@ static int csum_tree_block(struct btrfs_root *root, struct extent_buffer *buf,
        btrfs_csum_final(crc, result);
 
        if (verify) {
-               /* FIXME, this is not good */
                if (memcmp_extent_buffer(buf, result, 0, csum_size)) {
                        u32 val;
                        u32 found = 0;
                        memcpy(&found, result, csum_size);
 
                        read_extent_buffer(buf, &val, 0, csum_size);
-                       printk("btrfs: %s checksum verify failed on %llu "
-                              "wanted %X found %X level %d\n",
+                       printk(KERN_INFO "btrfs: %s checksum verify failed "
+                              "on %llu wanted %X found %X level %d\n",
                               root->fs_info->sb->s_id,
                               buf->start, val, found, btrfs_header_level(buf));
                        if (result != (char *)&inline_result)
@@ -293,7 +299,7 @@ static int btree_read_extent_buffer_pages(struct btrfs_root *root,
                if (!ret &&
                    !verify_parent_transid(io_tree, eb, parent_transid))
                        return ret;
-printk("read extent buffer pages failed with ret %d mirror no %d\n", ret, mirror_num);
+
                num_copies = btrfs_num_copies(&root->fs_info->mapping_tree,
                                              eb->start, eb->len);
                if (num_copies == 1)
@@ -307,9 +313,10 @@ printk("read extent buffer pages failed with ret %d mirror no %d\n", ret, mirror
 }
 
 /*
- * checksum a dirty tree block before IO.  This has extra checks to make
- * sure we only fill in the checksum field in the first page of a multi-page block
+ * checksum a dirty tree block before IO.  This has extra checks to make sure
+ * we only fill in the checksum field in the first page of a multi-page block
  */
+
 static int csum_dirty_buffer(struct btrfs_root *root, struct page *page)
 {
        struct extent_io_tree *tree;
@@ -327,28 +334,22 @@ static int csum_dirty_buffer(struct btrfs_root *root, struct page *page)
        if (!page->private)
                goto out;
        len = page->private >> 2;
-       if (len == 0) {
-               WARN_ON(1);
-       }
+       WARN_ON(len == 0);
+
        eb = alloc_extent_buffer(tree, start, len, page, GFP_NOFS);
        ret = btree_read_extent_buffer_pages(root, eb, start + PAGE_CACHE_SIZE,
                                             btrfs_header_generation(eb));
        BUG_ON(ret);
        found_start = btrfs_header_bytenr(eb);
        if (found_start != start) {
-               printk("warning: eb start incorrect %Lu buffer %Lu len %lu\n",
-                      start, found_start, len);
                WARN_ON(1);
                goto err;
        }
        if (eb->first_page != page) {
-               printk("bad first page %lu %lu\n", eb->first_page->index,
-                      page->index);
                WARN_ON(1);
                goto err;
        }
        if (!PageUptodate(page)) {
-               printk("csum not up to date page %lu\n", page->index);
                WARN_ON(1);
                goto err;
        }
@@ -380,6 +381,15 @@ static int check_tree_block_fsid(struct btrfs_root *root,
        return ret;
 }
 
+#ifdef CONFIG_DEBUG_LOCK_ALLOC
+void btrfs_set_buffer_lockdep_class(struct extent_buffer *eb, int level)
+{
+       lockdep_set_class_and_name(&eb->lock,
+                          &btrfs_eb_class[level],
+                          btrfs_eb_name[level]);
+}
+#endif
+
 static int btree_readpage_end_io_hook(struct page *page, u64 start, u64 end,
                               struct extent_state *state)
 {
@@ -396,34 +406,37 @@ static int btree_readpage_end_io_hook(struct page *page, u64 start, u64 end,
                goto out;
        if (!page->private)
                goto out;
+
        len = page->private >> 2;
-       if (len == 0) {
-               WARN_ON(1);
-       }
+       WARN_ON(len == 0);
+
        eb = alloc_extent_buffer(tree, start, len, page, GFP_NOFS);
 
        found_start = btrfs_header_bytenr(eb);
        if (found_start != start) {
-               printk("bad tree block start %llu %llu\n",
+               printk(KERN_INFO "btrfs bad tree block start %llu %llu\n",
                       (unsigned long long)found_start,
                       (unsigned long long)eb->start);
                ret = -EIO;
                goto err;
        }
        if (eb->first_page != page) {
-               printk("bad first page %lu %lu\n", eb->first_page->index,
-                      page->index);
+               printk(KERN_INFO "btrfs bad first page %lu %lu\n",
+                      eb->first_page->index, page->index);
                WARN_ON(1);
                ret = -EIO;
                goto err;
        }
        if (check_tree_block_fsid(root, eb)) {
-               printk("bad fsid on block %Lu\n", eb->start);
+               printk(KERN_INFO "btrfs bad fsid on block %llu\n",
+                      (unsigned long long)eb->start);
                ret = -EIO;
                goto err;
        }
        found_level = btrfs_header_level(eb);
 
+       btrfs_set_buffer_lockdep_class(eb, found_level);
+
        ret = csum_tree_block(root, eb, 1);
        if (ret)
                ret = -EIO;
@@ -578,7 +591,7 @@ int btrfs_wq_submit_bio(struct btrfs_fs_info *fs_info, struct inode *inode,
                           HZ/10);
        }
 #endif
-       while(atomic_read(&fs_info->async_submit_draining) &&
+       while (atomic_read(&fs_info->async_submit_draining) &&
              atomic_read(&fs_info->nr_async_submits)) {
                wait_event(fs_info->async_submit_wait,
                           (atomic_read(&fs_info->nr_async_submits) == 0));
@@ -594,7 +607,7 @@ static int btree_csum_one_bio(struct bio *bio)
        struct btrfs_root *root;
 
        WARN_ON(bio->bi_vcnt <= 0);
-       while(bio_index < bio->bi_vcnt) {
+       while (bio_index < bio->bi_vcnt) {
                root = BTRFS_I(bvec->bv_page->mapping->host)->root;
                csum_dirty_buffer(root, bvec->bv_page);
                bio_index++;
@@ -680,9 +693,8 @@ static int btree_writepages(struct address_space *mapping,
 
                num_dirty = count_range_bits(tree, &start, (u64)-1,
                                             thresh, EXTENT_DIRTY);
-               if (num_dirty < thresh) {
+               if (num_dirty < thresh)
                        return 0;
-               }
        }
        return extent_writepages(tree, mapping, btree_get_extent, wbc);
 }
@@ -701,15 +713,14 @@ static int btree_releasepage(struct page *page, gfp_t gfp_flags)
        int ret;
 
        if (PageWriteback(page) || PageDirty(page))
-           return 0;
+               return 0;
 
        tree = &BTRFS_I(page->mapping->host)->io_tree;
        map = &BTRFS_I(page->mapping->host)->extent_tree;
 
        ret = try_release_extent_state(map, tree, page, gfp_flags);
-       if (!ret) {
+       if (!ret)
                return 0;
-       }
 
        ret = try_release_extent_buffer(tree, page);
        if (ret == 1) {
@@ -728,8 +739,8 @@ static void btree_invalidatepage(struct page *page, unsigned long offset)
        extent_invalidatepage(tree, page, offset);
        btree_releasepage(page, GFP_NOFS);
        if (PagePrivate(page)) {
-               printk("warning page private not zero on page %Lu\n",
-                      page_offset(page));
+               printk(KERN_WARNING "btrfs warning page private not zero "
+                      "on page %llu\n", (unsigned long long)page_offset(page));
                ClearPagePrivate(page);
                set_page_private(page, 0);
                page_cache_release(page);
@@ -813,7 +824,7 @@ int btrfs_write_tree_block(struct extent_buffer *buf)
 int btrfs_wait_tree_block_writeback(struct extent_buffer *buf)
 {
        return btrfs_wait_on_page_writeback_range(buf->first_page->mapping,
-                                 buf->start, buf->start + buf->len -1);
+                                 buf->start, buf->start + buf->len - 1);
 }
 
 struct extent_buffer *read_tree_block(struct btrfs_root *root, u64 bytenr,
@@ -832,11 +843,10 @@ struct extent_buffer *read_tree_block(struct btrfs_root *root, u64 bytenr,
 
        ret = btree_read_extent_buffer_pages(root, buf, 0, parent_transid);
 
-       if (ret == 0) {
-               buf->flags |= EXTENT_UPTODATE;
-       } else {
+       if (ret == 0)
+               set_bit(EXTENT_BUFFER_UPTODATE, &buf->bflags);
+       else
                WARN_ON(1);
-       }
        return buf;
 
 }
@@ -847,7 +857,11 @@ int clean_tree_block(struct btrfs_trans_handle *trans, struct btrfs_root *root,
        struct inode *btree_inode = root->fs_info->btree_inode;
        if (btrfs_header_generation(buf) ==
            root->fs_info->running_transaction->transid) {
-               WARN_ON(!btrfs_tree_locked(buf));
+               btrfs_assert_tree_locked(buf);
+
+               /* ugh, clear_extent_buffer_dirty can be expensive */
+               btrfs_set_lock_blocking(buf);
+
                clear_extent_buffer_dirty(&BTRFS_I(btree_inode)->io_tree,
                                          buf);
        }
@@ -884,6 +898,14 @@ static int __setup_root(u32 nodesize, u32 leafsize, u32 sectorsize,
        spin_lock_init(&root->list_lock);
        mutex_init(&root->objectid_mutex);
        mutex_init(&root->log_mutex);
+       init_waitqueue_head(&root->log_writer_wait);
+       init_waitqueue_head(&root->log_commit_wait[0]);
+       init_waitqueue_head(&root->log_commit_wait[1]);
+       atomic_set(&root->log_commit[0], 0);
+       atomic_set(&root->log_commit[1], 0);
+       atomic_set(&root->log_writers, 0);
+       root->log_batch = 0;
+       root->log_transid = 0;
        extent_io_tree_init(&root->dirty_log_pages,
                             fs_info->btree_inode->i_mapping, GFP_NOFS);
 
@@ -944,7 +966,7 @@ int btrfs_free_log_root_tree(struct btrfs_trans_handle *trans,
        if (!log_root_tree)
                return 0;
 
-       while(1) {
+       while (1) {
                ret = find_first_extent_bit(&log_root_tree->dirty_log_pages,
                                    0, &start, &end, EXTENT_DIRTY);
                if (ret)
@@ -968,15 +990,16 @@ int btrfs_free_log_root_tree(struct btrfs_trans_handle *trans,
        return 0;
 }
 
-int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans,
-                            struct btrfs_fs_info *fs_info)
+static struct btrfs_root *alloc_log_tree(struct btrfs_trans_handle *trans,
+                                        struct btrfs_fs_info *fs_info)
 {
        struct btrfs_root *root;
        struct btrfs_root *tree_root = fs_info->tree_root;
+       struct extent_buffer *leaf;
 
        root = kzalloc(sizeof(*root), GFP_NOFS);
        if (!root)
-               return -ENOMEM;
+               return ERR_PTR(-ENOMEM);
 
        __setup_root(tree_root->nodesize, tree_root->leafsize,
                     tree_root->sectorsize, tree_root->stripesize,
@@ -985,12 +1008,23 @@ int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans,
        root->root_key.objectid = BTRFS_TREE_LOG_OBJECTID;
        root->root_key.type = BTRFS_ROOT_ITEM_KEY;
        root->root_key.offset = BTRFS_TREE_LOG_OBJECTID;
+       /*
+        * log trees do not get reference counted because they go away
+        * before a real commit is actually done.  They do store pointers
+        * to file data extents, and those reference counts still get
+        * updated (along with back refs to the log tree).
+        */
        root->ref_cows = 0;
 
-       root->node = btrfs_alloc_free_block(trans, root, root->leafsize,
-                                           0, BTRFS_TREE_LOG_OBJECTID,
-                                           trans->transid, 0, 0, 0);
+       leaf = btrfs_alloc_free_block(trans, root, root->leafsize,
+                                     0, BTRFS_TREE_LOG_OBJECTID,
+                                     trans->transid, 0, 0, 0);
+       if (IS_ERR(leaf)) {
+               kfree(root);
+               return ERR_CAST(leaf);
+       }
 
+       root->node = leaf;
        btrfs_set_header_nritems(root->node, 0);
        btrfs_set_header_level(root->node, 0);
        btrfs_set_header_bytenr(root->node, root->node->start);
@@ -1002,7 +1036,48 @@ int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans,
                            BTRFS_FSID_SIZE);
        btrfs_mark_buffer_dirty(root->node);
        btrfs_tree_unlock(root->node);
-       fs_info->log_root_tree = root;
+       return root;
+}
+
+int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans,
+                            struct btrfs_fs_info *fs_info)
+{
+       struct btrfs_root *log_root;
+
+       log_root = alloc_log_tree(trans, fs_info);
+       if (IS_ERR(log_root))
+               return PTR_ERR(log_root);
+       WARN_ON(fs_info->log_root_tree);
+       fs_info->log_root_tree = log_root;
+       return 0;
+}
+
+int btrfs_add_log_tree(struct btrfs_trans_handle *trans,
+                      struct btrfs_root *root)
+{
+       struct btrfs_root *log_root;
+       struct btrfs_inode_item *inode_item;
+
+       log_root = alloc_log_tree(trans, root->fs_info);
+       if (IS_ERR(log_root))
+               return PTR_ERR(log_root);
+
+       log_root->last_trans = trans->transid;
+       log_root->root_key.offset = root->root_key.objectid;
+
+       inode_item = &log_root->root_item.inode;
+       inode_item->generation = cpu_to_le64(1);
+       inode_item->size = cpu_to_le64(3);
+       inode_item->nlink = cpu_to_le32(1);
+       inode_item->nbytes = cpu_to_le64(root->leafsize);
+       inode_item->mode = cpu_to_le32(S_IFDIR | 0755);
+
+       btrfs_set_root_bytenr(&log_root->root_item, log_root->node->start);
+       btrfs_set_root_generation(&log_root->root_item, trans->transid);
+
+       WARN_ON(root->log_root);
+       root->log_root = log_root;
+       root->log_transid = 0;
        return 0;
 }
 
@@ -1165,30 +1240,11 @@ struct btrfs_root *btrfs_read_fs_root(struct btrfs_fs_info *fs_info,
        root->in_sysfs = 1;
        return root;
 }
-#if 0
-static int add_hasher(struct btrfs_fs_info *info, char *type) {
-       struct btrfs_hasher *hasher;
-
-       hasher = kmalloc(sizeof(*hasher), GFP_NOFS);
-       if (!hasher)
-               return -ENOMEM;
-       hasher->hash_tfm = crypto_alloc_hash(type, 0, CRYPTO_ALG_ASYNC);
-       if (!hasher->hash_tfm) {
-               kfree(hasher);
-               return -EINVAL;
-       }
-       spin_lock(&info->hash_lock);
-       list_add(&hasher->list, &info->hashers);
-       spin_unlock(&info->hash_lock);
-       return 0;
-}
-#endif
 
 static int btrfs_congested_fn(void *congested_data, int bdi_bits)
 {
        struct btrfs_fs_info *info = (struct btrfs_fs_info *)congested_data;
        int ret = 0;
-       struct list_head *cur;
        struct btrfs_device *device;
        struct backing_dev_info *bdi;
 #if 0
@@ -1196,8 +1252,7 @@ static int btrfs_congested_fn(void *congested_data, int bdi_bits)
            btrfs_congested_async(info, 0))
                return 1;
 #endif
-       list_for_each(cur, &info->fs_devices->devices) {
-               device = list_entry(cur, struct btrfs_device, dev_list);
+       list_for_each_entry(device, &info->fs_devices->devices, dev_list) {
                if (!device->bdev)
                        continue;
                bdi = blk_get_backing_dev_info(device->bdev);
@@ -1215,20 +1270,17 @@ static int btrfs_congested_fn(void *congested_data, int bdi_bits)
  */
 static void __unplug_io_fn(struct backing_dev_info *bdi, struct page *page)
 {
-       struct list_head *cur;
        struct btrfs_device *device;
        struct btrfs_fs_info *info;
 
        info = (struct btrfs_fs_info *)bdi->unplug_io_data;
-       list_for_each(cur, &info->fs_devices->devices) {
-               device = list_entry(cur, struct btrfs_device, dev_list);
+       list_for_each_entry(device, &info->fs_devices->devices, dev_list) {
                if (!device->bdev)
                        continue;
 
                bdi = blk_get_backing_dev_info(device->bdev);
-               if (bdi->unplug_io_fn) {
+               if (bdi->unplug_io_fn)
                        bdi->unplug_io_fn(bdi, page);
-               }
        }
 }
 
@@ -1420,8 +1472,9 @@ static int transaction_kthread(void *arg)
                mutex_lock(&root->fs_info->transaction_kthread_mutex);
 
                if (root->fs_info->total_ref_cache_size > 20 * 1024 * 1024) {
-                       printk("btrfs: total reference cache size %Lu\n",
-                               root->fs_info->total_ref_cache_size);
+                       printk(KERN_INFO "btrfs: total reference cache "
+                              "size %llu\n",
+                              root->fs_info->total_ref_cache_size);
                }
 
                mutex_lock(&root->fs_info->trans_mutex);
@@ -1499,7 +1552,6 @@ struct btrfs_root *open_ctree(struct super_block *sb,
        INIT_LIST_HEAD(&fs_info->dead_roots);
        INIT_LIST_HEAD(&fs_info->hashers);
        INIT_LIST_HEAD(&fs_info->delalloc_inodes);
-       spin_lock_init(&fs_info->hash_lock);
        spin_lock_init(&fs_info->delalloc_lock);
        spin_lock_init(&fs_info->new_trans_lock);
        spin_lock_init(&fs_info->ref_cache_lock);
@@ -1587,19 +1639,7 @@ struct btrfs_root *open_ctree(struct super_block *sb,
        init_waitqueue_head(&fs_info->transaction_throttle);
        init_waitqueue_head(&fs_info->transaction_wait);
        init_waitqueue_head(&fs_info->async_submit_wait);
-       init_waitqueue_head(&fs_info->tree_log_wait);
-       atomic_set(&fs_info->tree_log_commit, 0);
-       atomic_set(&fs_info->tree_log_writers, 0);
-       fs_info->tree_log_transid = 0;
 
-#if 0
-       ret = add_hasher(fs_info, "crc32c");
-       if (ret) {
-               printk("btrfs: failed hash setup, modprobe cryptomgr?\n");
-               err = -ENOMEM;
-               goto fail_iput;
-       }
-#endif
        __setup_root(4096, 4096, 4096, 4096, tree_root,
                     fs_info, BTRFS_ROOT_TREE_OBJECTID);
 
@@ -1609,6 +1649,8 @@ struct btrfs_root *open_ctree(struct super_block *sb,
                goto fail_iput;
 
        memcpy(&fs_info->super_copy, bh->b_data, sizeof(fs_info->super_copy));
+       memcpy(&fs_info->super_for_commit, &fs_info->super_copy,
+              sizeof(fs_info->super_for_commit));
        brelse(bh);
 
        memcpy(fs_info->fsid, fs_info->super_copy.fsid, BTRFS_FSID_SIZE);
@@ -1685,6 +1727,8 @@ struct btrfs_root *open_ctree(struct super_block *sb,
         * low idle thresh
         */
        fs_info->endio_workers.idle_thresh = 4;
+       fs_info->endio_meta_workers.idle_thresh = 4;
+
        fs_info->endio_write_workers.idle_thresh = 64;
        fs_info->endio_meta_write_workers.idle_thresh = 64;
 
@@ -1718,7 +1762,7 @@ struct btrfs_root *open_ctree(struct super_block *sb,
 
        if (strncmp((char *)(&disk_super->magic), BTRFS_MAGIC,
                    sizeof(disk_super->magic))) {
-               printk("btrfs: valid FS not found on %s\n", sb->s_id);
+               printk(KERN_INFO "btrfs: valid FS not found on %s\n", sb->s_id);
                goto fail_sb_buffer;
        }
 
@@ -1726,8 +1770,8 @@ struct btrfs_root *open_ctree(struct super_block *sb,
        ret = btrfs_read_sys_array(tree_root);
        mutex_unlock(&fs_info->chunk_mutex);
        if (ret) {
-               printk("btrfs: failed to read the system array on %s\n",
-                      sb->s_id);
+               printk(KERN_WARNING "btrfs: failed to read the system "
+                      "array on %s\n", sb->s_id);
                goto fail_sys_array;
        }
 
@@ -1744,14 +1788,15 @@ struct btrfs_root *open_ctree(struct super_block *sb,
        BUG_ON(!chunk_root->node);
 
        read_extent_buffer(chunk_root->node, fs_info->chunk_tree_uuid,
-                (unsigned long)btrfs_header_chunk_tree_uuid(chunk_root->node),
-                BTRFS_UUID_SIZE);
+          (unsigned long)btrfs_header_chunk_tree_uuid(chunk_root->node),
+          BTRFS_UUID_SIZE);
 
        mutex_lock(&fs_info->chunk_mutex);
        ret = btrfs_read_chunk_tree(chunk_root);
        mutex_unlock(&fs_info->chunk_mutex);
        if (ret) {
-               printk("btrfs: failed to read chunk tree on %s\n", sb->s_id);
+               printk(KERN_WARNING "btrfs: failed to read chunk tree on %s\n",
+                      sb->s_id);
                goto fail_chunk_root;
        }
 
@@ -1777,7 +1822,6 @@ struct btrfs_root *open_ctree(struct super_block *sb,
        ret = find_and_setup_root(tree_root, fs_info,
                                  BTRFS_DEV_TREE_OBJECTID, dev_root);
        dev_root->track_dirty = 1;
-
        if (ret)
                goto fail_extent_root;
 
@@ -1790,27 +1834,28 @@ struct btrfs_root *open_ctree(struct super_block *sb,
 
        btrfs_read_block_groups(extent_root);
 
-       fs_info->generation = generation + 1;
+       fs_info->generation = generation;
        fs_info->last_trans_committed = generation;
        fs_info->data_alloc_profile = (u64)-1;
        fs_info->metadata_alloc_profile = (u64)-1;
        fs_info->system_alloc_profile = fs_info->metadata_alloc_profile;
        fs_info->cleaner_kthread = kthread_run(cleaner_kthread, tree_root,
                                               "btrfs-cleaner");
-       if (!fs_info->cleaner_kthread)
+       if (IS_ERR(fs_info->cleaner_kthread))
                goto fail_csum_root;
 
        fs_info->transaction_kthread = kthread_run(transaction_kthread,
                                                   tree_root,
                                                   "btrfs-transaction");
-       if (!fs_info->transaction_kthread)
+       if (IS_ERR(fs_info->transaction_kthread))
                goto fail_cleaner;
 
        if (btrfs_super_log_root(disk_super) != 0) {
                u64 bytenr = btrfs_super_log_root(disk_super);
 
                if (fs_devices->rw_devices == 0) {
-                       printk("Btrfs log replay required on RO media\n");
+                       printk(KERN_WARNING "Btrfs log replay required "
+                              "on RO media\n");
                        err = -EIO;
                        goto fail_trans_kthread;
                }
@@ -1884,13 +1929,14 @@ fail_sb_buffer:
 fail_iput:
        invalidate_inode_pages2(fs_info->btree_inode->i_mapping);
        iput(fs_info->btree_inode);
-fail:
+
        btrfs_close_devices(fs_info->fs_devices);
        btrfs_mapping_tree_free(&fs_info->mapping_tree);
+       bdi_destroy(&fs_info->bdi);
 
+fail:
        kfree(extent_root);
        kfree(tree_root);
-       bdi_destroy(&fs_info->bdi);
        kfree(fs_info);
        kfree(chunk_root);
        kfree(dev_root);
@@ -2051,7 +2097,6 @@ static int write_dev_supers(struct btrfs_device *device,
 
 int write_all_supers(struct btrfs_root *root, int max_mirrors)
 {
-       struct list_head *cur;
        struct list_head *head = &root->fs_info->fs_devices->devices;
        struct btrfs_device *dev;
        struct btrfs_super_block *sb;
@@ -2067,8 +2112,7 @@ int write_all_supers(struct btrfs_root *root, int max_mirrors)
 
        sb = &root->fs_info->super_for_commit;
        dev_item = &sb->dev_item;
-       list_for_each(cur, head) {
-               dev = list_entry(cur, struct btrfs_device, dev_list);
+       list_for_each_entry(dev, head, dev_list) {
                if (!dev->bdev) {
                        total_errors++;
                        continue;
@@ -2095,13 +2139,13 @@ int write_all_supers(struct btrfs_root *root, int max_mirrors)
                        total_errors++;
        }
        if (total_errors > max_errors) {
-               printk("btrfs: %d errors while writing supers\n", total_errors);
+               printk(KERN_ERR "btrfs: %d errors while writing supers\n",
+                      total_errors);
                BUG();
        }
 
        total_errors = 0;
-       list_for_each(cur, head) {
-               dev = list_entry(cur, struct btrfs_device, dev_list);
+       list_for_each_entry(dev, head, dev_list) {
                if (!dev->bdev)
                        continue;
                if (!dev->in_fs_metadata || !dev->writeable)
@@ -2112,7 +2156,8 @@ int write_all_supers(struct btrfs_root *root, int max_mirrors)
                        total_errors++;
        }
        if (total_errors > max_errors) {
-               printk("btrfs: %d errors while writing supers\n", total_errors);
+               printk(KERN_ERR "btrfs: %d errors while writing supers\n",
+                      total_errors);
                BUG();
        }
        return 0;
@@ -2135,16 +2180,11 @@ int btrfs_free_fs_root(struct btrfs_fs_info *fs_info, struct btrfs_root *root)
                down_write(&root->anon_super.s_umount);
                kill_anon_super(&root->anon_super);
        }
-#if 0
-       if (root->in_sysfs)
-               btrfs_sysfs_del_root(root);
-#endif
        if (root->node)
                free_extent_buffer(root->node);
        if (root->commit_root)
                free_extent_buffer(root->commit_root);
-       if (root->name)
-               kfree(root->name);
+       kfree(root->name);
        kfree(root);
        return 0;
 }
@@ -2155,7 +2195,7 @@ static int del_fs_roots(struct btrfs_fs_info *fs_info)
        struct btrfs_root *gang[8];
        int i;
 
-       while(1) {
+       while (1) {
                ret = radix_tree_gang_lookup(&fs_info->fs_roots_radix,
                                             (void **)gang, 0,
                                             ARRAY_SIZE(gang));
@@ -2226,18 +2266,17 @@ int close_ctree(struct btrfs_root *root)
 
        if (!(fs_info->sb->s_flags & MS_RDONLY)) {
                ret =  btrfs_commit_super(root);
-               if (ret) {
-                       printk("btrfs: commit super returns %d\n", ret);
-               }
+               if (ret)
+                       printk(KERN_ERR "btrfs: commit super ret %d\n", ret);
        }
 
        if (fs_info->delalloc_bytes) {
-               printk("btrfs: at unmount delalloc count %Lu\n",
+               printk(KERN_INFO "btrfs: at unmount delalloc count %llu\n",
                       fs_info->delalloc_bytes);
        }
        if (fs_info->total_ref_cache_size) {
-               printk("btrfs: at umount reference cache size %Lu\n",
-                       fs_info->total_ref_cache_size);
+               printk(KERN_INFO "btrfs: at umount reference cache size %llu\n",
+                      (unsigned long long)fs_info->total_ref_cache_size);
        }
 
        if (fs_info->extent_root->node)
@@ -2246,13 +2285,13 @@ int close_ctree(struct btrfs_root *root)
        if (fs_info->tree_root->node)
                free_extent_buffer(fs_info->tree_root->node);
 
-       if (root->fs_info->chunk_root->node);
+       if (root->fs_info->chunk_root->node)
                free_extent_buffer(root->fs_info->chunk_root->node);
 
-       if (root->fs_info->dev_root->node);
+       if (root->fs_info->dev_root->node)
                free_extent_buffer(root->fs_info->dev_root->node);
 
-       if (root->fs_info->csum_root->node);
+       if (root->fs_info->csum_root->node)
                free_extent_buffer(root->fs_info->csum_root->node);
 
        btrfs_free_block_groups(root->fs_info);
@@ -2271,7 +2310,7 @@ int close_ctree(struct btrfs_root *root)
        btrfs_stop_workers(&fs_info->submit_workers);
 
 #if 0
-       while(!list_empty(&fs_info->hashers)) {
+       while (!list_empty(&fs_info->hashers)) {
                struct btrfs_hasher *hasher;
                hasher = list_entry(fs_info->hashers.next, struct btrfs_hasher,
                                    hashers);
@@ -2320,11 +2359,15 @@ void btrfs_mark_buffer_dirty(struct extent_buffer *buf)
        u64 transid = btrfs_header_generation(buf);
        struct inode *btree_inode = root->fs_info->btree_inode;
 
-       WARN_ON(!btrfs_tree_locked(buf));
+       btrfs_set_lock_blocking(buf);
+
+       btrfs_assert_tree_locked(buf);
        if (transid != root->fs_info->generation) {
-               printk(KERN_CRIT "transid mismatch buffer %llu, found %Lu running %Lu\n",
+               printk(KERN_CRIT "btrfs transid mismatch buffer %llu, "
+                      "found %llu running %llu\n",
                        (unsigned long long)buf->start,
-                       transid, root->fs_info->generation);
+                       (unsigned long long)transid,
+                       (unsigned long long)root->fs_info->generation);
                WARN_ON(1);
        }
        set_extent_buffer_dirty(&BTRFS_I(btree_inode)->io_tree, buf);
@@ -2359,16 +2402,14 @@ int btrfs_read_buffer(struct extent_buffer *buf, u64 parent_transid)
        struct btrfs_root *root = BTRFS_I(buf->first_page->mapping->host)->root;
        int ret;
        ret = btree_read_extent_buffer_pages(root, buf, 0, parent_transid);
-       if (ret == 0) {
-               buf->flags |= EXTENT_UPTODATE;
-       }
+       if (ret == 0)
+               set_bit(EXTENT_BUFFER_UPTODATE, &buf->bflags);
        return ret;
 }
 
 int btree_lock_page_hook(struct page *page)
 {
        struct inode *inode = page->mapping->host;
-       struct btrfs_root *root = BTRFS_I(inode)->root;
        struct extent_io_tree *io_tree = &BTRFS_I(inode)->io_tree;
        struct extent_buffer *eb;
        unsigned long len;
@@ -2383,9 +2424,7 @@ int btree_lock_page_hook(struct page *page)
                goto out;
 
        btrfs_tree_lock(eb);
-       spin_lock(&root->fs_info->hash_lock);
        btrfs_set_header_flag(eb, BTRFS_HEADER_FLAG_WRITTEN);
-       spin_unlock(&root->fs_info->hash_lock);
        btrfs_tree_unlock(eb);
        free_extent_buffer(eb);
 out: