Merge branch 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mfashe...
[sfrench/cifs-2.6.git] / drivers / media / video / cx23885 / cx23885-core.c
index 13dc7c8642cab8ce3a56aec6c94ba2ab8e16b286..8e40c7bcc06d08dbd7ed0363533cf26ab0ff01da 100644 (file)
@@ -36,7 +36,7 @@ MODULE_DESCRIPTION("Driver for cx23885 based TV cards");
 MODULE_AUTHOR("Steven Toth <stoth@hauppauge.com>");
 MODULE_LICENSE("GPL");
 
-static unsigned int debug = 0;
+static unsigned int debug;
 module_param(debug,int,0644);
 MODULE_PARM_DESC(debug,"enable debug messages");
 
@@ -44,13 +44,15 @@ static unsigned int card[]  = {[0 ... (CX23885_MAXBOARDS - 1)] = UNSET };
 module_param_array(card,  int, NULL, 0444);
 MODULE_PARM_DESC(card,"card type");
 
-#define dprintk(level,fmt, arg...)     if (debug >= level) \
-       printk(KERN_DEBUG "%s/0: " fmt, dev->name , ## arg)
+#define dprintk(level, fmt, arg...)\
+       do { if (debug >= level)\
+               printk(KERN_DEBUG "%s/0: " fmt, dev->name, ## arg);\
+       } while (0)
 
 static unsigned int cx23885_devcount;
 
 static DEFINE_MUTEX(devlist);
-static LIST_HEAD(cx23885_devlist);
+LIST_HEAD(cx23885_devlist);
 
 #define NO_SYNC_LINE (-1U)
 
@@ -73,14 +75,14 @@ static LIST_HEAD(cx23885_devlist);
  * 0x00010ea0 0x00010xxx Free
  */
 
-struct sram_channel cx23885_sram_channels[] = {
+static struct sram_channel cx23885_sram_channels[] = {
        [SRAM_CH01] = {
-               .name           = "test ch1",
+               .name           = "VID A",
                .cmds_start     = 0x10000,
-               .ctrl_start     = 0x10500,
-               .cdt            = 0x10900,
-               .fifo_start     = 0x3000,
-               .fifo_size      = 0x1000,
+               .ctrl_start     = 0x105b0,
+               .cdt            = 0x107b0,
+               .fifo_start     = 0x40,
+               .fifo_size      = 0x2800,
                .ptr1_reg       = DMA1_PTR1,
                .ptr2_reg       = DMA1_PTR2,
                .cnt1_reg       = DMA1_CNT1,
@@ -100,12 +102,12 @@ struct sram_channel cx23885_sram_channels[] = {
                .cnt2_reg       = DMA2_CNT2,
        },
        [SRAM_CH03] = {
-               .name           = "ch3",
-               .cmds_start     = 0x0,
-               .ctrl_start     = 0x0,
-               .cdt            = 0x0,
-               .fifo_start     = 0x0,
-               .fifo_size      = 0x0,
+               .name           = "TS1 B",
+               .cmds_start     = 0x100A0,
+               .ctrl_start     = 0x10630,
+               .cdt            = 0x10870,
+               .fifo_start     = 0x5000,
+               .fifo_size      = 0x1000,
                .ptr1_reg       = DMA3_PTR1,
                .ptr2_reg       = DMA3_PTR2,
                .cnt1_reg       = DMA3_CNT1,
@@ -139,7 +141,7 @@ struct sram_channel cx23885_sram_channels[] = {
                .name           = "TS2 C",
                .cmds_start     = 0x10140,
                .ctrl_start     = 0x10680,
-               .cdt            = 0x10480,
+               .cdt            = 0x108d0,
                .fifo_start     = 0x6000,
                .fifo_size      = 0x1000,
                .ptr1_reg       = DMA5_PTR1,
@@ -205,14 +207,14 @@ struct sram_channel cx23885_sram_channels[] = {
  * 0x00010ea0 0x00010xxx Free
  */
 
-struct sram_channel cx23887_sram_channels[] = {
+static struct sram_channel cx23887_sram_channels[] = {
        [SRAM_CH01] = {
-               .name           = "test ch1",
-               .cmds_start     = 0x0,
-               .ctrl_start     = 0x0,
-               .cdt            = 0x0,
-               .fifo_start     = 0x0,
-               .fifo_size      = 0x0,
+               .name           = "VID A",
+               .cmds_start     = 0x10000,
+               .ctrl_start     = 0x105b0,
+               .cdt            = 0x107b0,
+               .fifo_start     = 0x40,
+               .fifo_size      = 0x2800,
                .ptr1_reg       = DMA1_PTR1,
                .ptr2_reg       = DMA1_PTR2,
                .cnt1_reg       = DMA1_CNT1,
@@ -231,12 +233,12 @@ struct sram_channel cx23887_sram_channels[] = {
                .cnt2_reg       = DMA2_CNT2,
        },
        [SRAM_CH03] = {
-               .name           = "ch3",
-               .cmds_start     = 0x0,
-               .ctrl_start     = 0x0,
-               .cdt            = 0x0,
-               .fifo_start     = 0x0,
-               .fifo_size      = 0x0,
+               .name           = "TS1 B",
+               .cmds_start     = 0x100A0,
+               .ctrl_start     = 0x10780,
+               .cdt            = 0x10400,
+               .fifo_start     = 0x5000,
+               .fifo_size      = 0x1000,
                .ptr1_reg       = DMA3_PTR1,
                .ptr2_reg       = DMA3_PTR2,
                .cnt1_reg       = DMA3_CNT1,
@@ -357,7 +359,7 @@ static int cx23885_risc_decode(u32 risc)
 }
 
 void cx23885_wakeup(struct cx23885_tsport *port,
-                   struct cx23885_dmaqueue *q, u32 count)
+                          struct cx23885_dmaqueue *q, u32 count)
 {
        struct cx23885_dev *dev = port->dev;
        struct cx23885_buffer *buf;
@@ -378,7 +380,7 @@ void cx23885_wakeup(struct cx23885_tsport *port,
                do_gettimeofday(&buf->vb.ts);
                dprintk(2, "[%p/%d] wakeup reg=%d buf=%d\n", buf, buf->vb.i,
                        count, buf->count);
-               buf->vb.state = STATE_DONE;
+               buf->vb.state = VIDEOBUF_DONE;
                list_del(&buf->vb.queue);
                wake_up(&buf->vb.done);
        }
@@ -391,12 +393,10 @@ void cx23885_wakeup(struct cx23885_tsport *port,
                printk("%s: %d buffers handled (should be 1)\n",
                       __FUNCTION__, bc);
 }
-void cx23885_sram_channel_dump(struct cx23885_dev *dev,
-                              struct sram_channel *ch);
 
 int cx23885_sram_channel_setup(struct cx23885_dev *dev,
-                              struct sram_channel *ch,
-                              unsigned int bpl, u32 risc)
+                                     struct sram_channel *ch,
+                                     unsigned int bpl, u32 risc)
 {
        unsigned int i, lines;
        u32 cdt;
@@ -468,7 +468,7 @@ int cx23885_sram_channel_setup(struct cx23885_dev *dev,
 }
 
 void cx23885_sram_channel_dump(struct cx23885_dev *dev,
-                              struct sram_channel *ch)
+                                     struct sram_channel *ch)
 {
        static char *name[] = {
                "init risc lo",
@@ -529,8 +529,8 @@ void cx23885_sram_channel_dump(struct cx23885_dev *dev,
               dev->name, cx_read(ch->cnt2_reg));
 }
 
-void cx23885_risc_disasm(struct cx23885_tsport *port,
-                        struct btcx_riscmem *risc)
+static void cx23885_risc_disasm(struct cx23885_tsport *port,
+                               struct btcx_riscmem *risc)
 {
        struct cx23885_dev *dev = port->dev;
        unsigned int i, j, n;
@@ -548,7 +548,7 @@ void cx23885_risc_disasm(struct cx23885_tsport *port,
        }
 }
 
-void cx23885_shutdown(struct cx23885_dev *dev)
+static void cx23885_shutdown(struct cx23885_dev *dev)
 {
        /* disable RISC controller */
        cx_write(DEV_CNTRL2, 0);
@@ -578,7 +578,7 @@ void cx23885_shutdown(struct cx23885_dev *dev)
 
 }
 
-void cx23885_reset(struct cx23885_dev *dev)
+static void cx23885_reset(struct cx23885_dev *dev)
 {
        dprintk(1, "%s()\n", __FUNCTION__);
 
@@ -594,34 +594,20 @@ void cx23885_reset(struct cx23885_dev *dev)
 
        mdelay(100);
 
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH01 ], 188*4, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH02 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH03 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH04 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH05 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH06 ], 188*4, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH07 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH08 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH09 ], 128, 0);
-
-       switch(dev->board) {
-       case CX23885_BOARD_HAUPPAUGE_HVR1250:
-               /* GPIO-0 cx24227 demodulator reset */
-               dprintk( 1, "%s() Configuring HVR1250 GPIO's\n", __FUNCTION__);
-               cx_set(GP0_IO, 0x00010001); /* Bring the part out of reset */
-               break;
-       case CX23885_BOARD_HAUPPAUGE_HVR1800:
-               /* GPIO-0 656_CLK */
-               /* GPIO-1 656_D0 */
-               /* GPIO-2 8295A Reset */
-               /* GPIO-3-10 cx23417 data0-7 */
-               /* GPIO-11-14 cx23417 addr0-3 */
-               /* GPIO-15-18 cx23417 READY, CS, RD, WR */
-               /* GPIO-19 IR_RX */
-               dprintk( 1, "%s() Configuring HVR1800 GPIO's\n", __FUNCTION__);
-               // FIXME: Analog requires the tuner is brought out of reset
-               break;
-       }
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH01],
+               720*4, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH02], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH03],
+               188*4, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH04], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH05], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH06],
+               188*4, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH07], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH08], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH09], 128, 0);
+
+       cx23885_gpio_setup(dev);
 }
 
 
@@ -654,22 +640,111 @@ static int get_resources(struct cx23885_dev *dev)
 
 static void cx23885_timeout(unsigned long data);
 int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
-                        u32 reg, u32 mask, u32 value);
+                               u32 reg, u32 mask, u32 value);
 
-static int cx23885_ir_init(struct cx23885_dev *dev)
+static int cx23885_init_tsport(struct cx23885_dev *dev, struct cx23885_tsport *port, int portno)
 {
-       dprintk(1, "%s()\n", __FUNCTION__);
-
-       switch (dev->board) {
-       case CX23885_BOARD_HAUPPAUGE_HVR1250:
-       case CX23885_BOARD_HAUPPAUGE_HVR1800:
-               dprintk(1, "%s() FIXME - Implement IR support\n", __FUNCTION__);
+       dprintk(1, "%s(portno=%d)\n", __FUNCTION__, portno);
+
+       /* Transport bus init dma queue  - Common settings */
+       port->dma_ctl_val        = 0x11; /* Enable RISC controller and Fifo */
+       port->ts_int_msk_val     = 0x1111; /* TS port bits for RISC */
+
+       spin_lock_init(&port->slock);
+       port->dev = dev;
+       port->nr = portno;
+
+       INIT_LIST_HEAD(&port->mpegq.active);
+       INIT_LIST_HEAD(&port->mpegq.queued);
+       port->mpegq.timeout.function = cx23885_timeout;
+       port->mpegq.timeout.data = (unsigned long)port;
+       init_timer(&port->mpegq.timeout);
+
+       switch(portno) {
+       case 1:
+               port->reg_gpcnt          = VID_B_GPCNT;
+               port->reg_gpcnt_ctl      = VID_B_GPCNT_CTL;
+               port->reg_dma_ctl        = VID_B_DMA_CTL;
+               port->reg_lngth          = VID_B_LNGTH;
+               port->reg_hw_sop_ctrl    = VID_B_HW_SOP_CTL;
+               port->reg_gen_ctrl       = VID_B_GEN_CTL;
+               port->reg_bd_pkt_status  = VID_B_BD_PKT_STATUS;
+               port->reg_sop_status     = VID_B_SOP_STATUS;
+               port->reg_fifo_ovfl_stat = VID_B_FIFO_OVFL_STAT;
+               port->reg_vld_misc       = VID_B_VLD_MISC;
+               port->reg_ts_clk_en      = VID_B_TS_CLK_EN;
+               port->reg_src_sel        = VID_B_SRC_SEL;
+               port->reg_ts_int_msk     = VID_B_INT_MSK;
+               port->reg_ts_int_stat   = VID_B_INT_STAT;
+               port->sram_chno          = SRAM_CH03; /* VID_B */
+               port->pci_irqmask        = 0x02; /* VID_B bit1 */
+               break;
+       case 2:
+               port->reg_gpcnt          = VID_C_GPCNT;
+               port->reg_gpcnt_ctl      = VID_C_GPCNT_CTL;
+               port->reg_dma_ctl        = VID_C_DMA_CTL;
+               port->reg_lngth          = VID_C_LNGTH;
+               port->reg_hw_sop_ctrl    = VID_C_HW_SOP_CTL;
+               port->reg_gen_ctrl       = VID_C_GEN_CTL;
+               port->reg_bd_pkt_status  = VID_C_BD_PKT_STATUS;
+               port->reg_sop_status     = VID_C_SOP_STATUS;
+               port->reg_fifo_ovfl_stat = VID_C_FIFO_OVFL_STAT;
+               port->reg_vld_misc       = VID_C_VLD_MISC;
+               port->reg_ts_clk_en      = VID_C_TS_CLK_EN;
+               port->reg_src_sel        = 0;
+               port->reg_ts_int_msk     = VID_C_INT_MSK;
+               port->reg_ts_int_stat    = VID_C_INT_STAT;
+               port->sram_chno          = SRAM_CH06; /* VID_C */
+               port->pci_irqmask        = 0x04; /* VID_C bit2 */
                break;
+       default:
+               BUG();
        }
 
+       cx23885_risc_stopper(dev->pci, &port->mpegq.stopper,
+                    port->reg_dma_ctl, port->dma_ctl_val, 0x00);
+
        return 0;
 }
 
+static void cx23885_dev_checkrevision(struct cx23885_dev *dev)
+{
+       switch (cx_read(RDR_CFG2) & 0xff) {
+       case 0x00:
+               /* cx23885 */
+               dev->hwrevision = 0xa0;
+               break;
+       case 0x01:
+               /* CX23885-12Z */
+               dev->hwrevision = 0xa1;
+               break;
+       case 0x02:
+               /* CX23885-13Z */
+               dev->hwrevision = 0xb0;
+               break;
+       case 0x03:
+               /* CX23888-22Z */
+               dev->hwrevision = 0xc0;
+               break;
+       case 0x0e:
+               /* CX23887-15Z */
+               dev->hwrevision = 0xc0;
+       case 0x0f:
+               /* CX23887-14Z */
+               dev->hwrevision = 0xb1;
+               break;
+       default:
+               printk(KERN_ERR "%s() New hardware revision found 0x%x\n",
+                       __FUNCTION__, dev->hwrevision);
+       }
+       if (dev->hwrevision)
+               printk(KERN_INFO "%s() Hardware revision = 0x%02x\n",
+                       __FUNCTION__, dev->hwrevision);
+       else
+               printk(KERN_ERR "%s() Hardware revision unknown 0x%x\n",
+                       __FUNCTION__, dev->hwrevision);
+}
+
 static int cx23885_dev_setup(struct cx23885_dev *dev)
 {
        int i;
@@ -679,6 +754,47 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        atomic_inc(&dev->refcount);
 
        dev->nr = cx23885_devcount++;
+       sprintf(dev->name, "cx23885[%d]", dev->nr);
+
+       mutex_lock(&devlist);
+       list_add_tail(&dev->devlist, &cx23885_devlist);
+       mutex_unlock(&devlist);
+
+       /* Configure the internal memory */
+       if(dev->pci->device == 0x8880) {
+               dev->bridge = CX23885_BRIDGE_887;
+               dev->sram_channels = cx23887_sram_channels;
+               /* Apply a sensible clock frequency for the PCIe bridge */
+               dev->clk_freq = 25000000;
+       } else
+       if(dev->pci->device == 0x8852) {
+               dev->bridge = CX23885_BRIDGE_885;
+               dev->sram_channels = cx23885_sram_channels;
+               /* Apply a sensible clock frequency for the PCIe bridge */
+               dev->clk_freq = 28000000;
+       } else
+               BUG();
+
+       dprintk(1, "%s() Memory configured for PCIe bridge type %d\n",
+               __FUNCTION__, dev->bridge);
+
+       /* board config */
+       dev->board = UNSET;
+       if (card[dev->nr] < cx23885_bcount)
+               dev->board = card[dev->nr];
+       for (i = 0; UNSET == dev->board  &&  i < cx23885_idcount; i++)
+               if (dev->pci->subsystem_vendor == cx23885_subids[i].subvendor &&
+                   dev->pci->subsystem_device == cx23885_subids[i].subdevice)
+                       dev->board = cx23885_subids[i].card;
+       if (UNSET == dev->board) {
+               dev->board = CX23885_BOARD_UNKNOWN;
+               cx23885_card_list(dev);
+       }
+
+       /* If the user specific a clk freq override, apply it */
+       if (cx23885_boards[dev->board].clk_freq > 0)
+               dev->clk_freq = cx23885_boards[dev->board].clk_freq;
+
        dev->pci_bus  = dev->pci->bus->number;
        dev->pci_slot = PCI_SLOT(dev->pci->devfn);
        dev->pci_irqmask = 0x001f00;
@@ -713,41 +829,11 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        dev->i2c_bus[2].reg_wdata = I2C3_WDATA;
        dev->i2c_bus[2].i2c_period = (0x07 << 24); /* 1.95MHz */
 
-       /* Transport bus init dma queue */
-       spin_lock_init(&dev->ts2.slock);
-       dev->ts2.dev = dev;
-       dev->ts2.nr = 2;
-       dev->ts2.sram_chno = SRAM_CH06;
-       INIT_LIST_HEAD(&dev->ts2.mpegq.active);
-       INIT_LIST_HEAD(&dev->ts2.mpegq.queued);
-       dev->ts2.mpegq.timeout.function = cx23885_timeout;
-       dev->ts2.mpegq.timeout.data     = (unsigned long)&dev->ts2;
-       init_timer(&dev->ts2.mpegq.timeout);
-
-       dev->ts2.reg_gpcnt = VID_C_GPCNT;
-       dev->ts2.reg_gpcnt_ctl = VID_C_GPCNT_CTL;
-       dev->ts2.reg_dma_ctl = VID_C_DMA_CTL;
-       dev->ts2.reg_lngth = VID_C_LNGTH;
-       dev->ts2.reg_hw_sop_ctrl = VID_C_HW_SOP_CTL;
-       dev->ts2.reg_gen_ctrl = VID_C_GEN_CTL;
-       dev->ts2.reg_bd_pkt_status = VID_C_BD_PKT_STATUS;
-       dev->ts2.reg_sop_status = VID_C_SOP_STATUS;
-       dev->ts2.reg_fifo_ovfl_stat = VID_C_FIFO_OVFL_STAT;
-       dev->ts2.reg_vld_misc = VID_C_VLD_MISC;
-       dev->ts2.reg_ts_clk_en = VID_C_TS_CLK_EN;
-       dev->ts2.reg_ts_int_msk = VID_C_INT_MSK;
-
-       // FIXME: Make this board specific
-       dev->ts2.pci_irqmask = 0x04; /* TS Port 2 bit */
-       dev->ts2.dma_ctl_val = 0x11; /* Enable RISC controller and Fifo */
-       dev->ts2.ts_int_msk_val = 0x1111; /* TS port bits for RISC */
-       dev->ts2.gen_ctrl_val = 0xc; /* Serial bus + punctured clock */
-       dev->ts2.ts_clk_en_val = 0x1; /* Enable TS_CLK */
-
-       cx23885_risc_stopper(dev->pci, &dev->ts2.mpegq.stopper,
-                            dev->ts2.reg_dma_ctl, dev->ts2.dma_ctl_val, 0x00);
+       if(cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
+               cx23885_init_tsport(dev, &dev->ts1, 1);
 
-       sprintf(dev->name, "cx23885[%d]", dev->nr);
+       if(cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
+               cx23885_init_tsport(dev, &dev->ts2, 2);
 
        if (get_resources(dev) < 0) {
                printk(KERN_ERR "CORE %s No more PCIe resources for "
@@ -756,51 +842,34 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
                       dev->pci->subsystem_device);
 
                cx23885_devcount--;
-               goto fail_free;
+               return -ENODEV;
        }
 
-       mutex_lock(&devlist);
-       list_add_tail(&dev->devlist, &cx23885_devlist);
-       mutex_unlock(&devlist);
-
        /* PCIe stuff */
        dev->lmmio = ioremap(pci_resource_start(dev->pci,0),
                             pci_resource_len(dev->pci,0));
 
        dev->bmmio = (u8 __iomem *)dev->lmmio;
 
-       /* board config */
-       dev->board = UNSET;
-       if (card[dev->nr] < cx23885_bcount)
-               dev->board = card[dev->nr];
-       for (i = 0; UNSET == dev->board  &&  i < cx23885_idcount; i++)
-               if (dev->pci->subsystem_vendor == cx23885_subids[i].subvendor &&
-                   dev->pci->subsystem_device == cx23885_subids[i].subdevice)
-                       dev->board = cx23885_subids[i].card;
-       if (UNSET == dev->board) {
-               dev->board = CX23885_BOARD_UNKNOWN;
-               cx23885_card_list(dev);
-       }
        printk(KERN_INFO "CORE %s: subsystem: %04x:%04x, board: %s [card=%d,%s]\n",
               dev->name, dev->pci->subsystem_vendor,
               dev->pci->subsystem_device, cx23885_boards[dev->board].name,
               dev->board, card[dev->nr] == dev->board ?
               "insmod option" : "autodetected");
 
-       /* Configure the internal memory */
-       if(dev->pci->device == 0x8880) {
-               dev->bridge = CX23885_BRIDGE_887;
-               dev->sram_channels = cx23887_sram_channels;
-       } else
-       if(dev->pci->device == 0x8852) {
-               dev->bridge = CX23885_BRIDGE_885;
-               dev->sram_channels = cx23885_sram_channels;
-       }
-       dprintk(1, "%s() Memory configured for PCIe bridge type %d\n",
-               __FUNCTION__, dev->bridge);
-
        cx23885_pci_quirks(dev);
 
+       /* Assume some sensible defaults */
+       dev->tuner_type = cx23885_boards[dev->board].tuner_type;
+       dev->tuner_addr = cx23885_boards[dev->board].tuner_addr;
+       dev->radio_type = cx23885_boards[dev->board].radio_type;
+       dev->radio_addr = cx23885_boards[dev->board].radio_addr;
+
+       dprintk(1, "%s() tuner_type = 0x%x tuner_addr = 0x%x\n",
+               __FUNCTION__, dev->tuner_type, dev->tuner_addr);
+       dprintk(1, "%s() radio_type = 0x%x radio_addr = 0x%x\n",
+               __FUNCTION__, dev->radio_type, dev->radio_addr);
+
        /* init hardware */
        cx23885_reset(dev);
 
@@ -808,23 +877,36 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        cx23885_i2c_register(&dev->i2c_bus[1]);
        cx23885_i2c_register(&dev->i2c_bus[2]);
        cx23885_call_i2c_clients (&dev->i2c_bus[0], TUNER_SET_STANDBY, NULL);
-
        cx23885_card_setup(dev);
        cx23885_ir_init(dev);
 
-       if (cx23885_dvb_register(&dev->ts2) < 0) {
-               printk(KERN_ERR "%s() Failed to register dvb adapters\n",
-                      __FUNCTION__);
+       if (cx23885_boards[dev->board].porta == CX23885_ANALOG_VIDEO) {
+               if (cx23885_video_register(dev) < 0) {
+                       printk(KERN_ERR "%s() Failed to register analog "
+                               "video adapters on VID_A\n", __FUNCTION__);
+               }
        }
 
-       return 0;
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_DVB) {
+               if (cx23885_dvb_register(&dev->ts1) < 0) {
+                       printk(KERN_ERR "%s() Failed to register dvb adapters on VID_B\n",
+                              __FUNCTION__);
+               }
+       }
 
-fail_free:
-       kfree(dev);
-       return -ENODEV;
+       if (cx23885_boards[dev->board].portc == CX23885_MPEG_DVB) {
+               if (cx23885_dvb_register(&dev->ts2) < 0) {
+                       printk(KERN_ERR "%s() Failed to register dvb adapters on VID_C\n",
+                              __FUNCTION__);
+               }
+       }
+
+       cx23885_dev_checkrevision(dev);
+
+       return 0;
 }
 
-void cx23885_dev_unregister(struct cx23885_dev *dev)
+static void cx23885_dev_unregister(struct cx23885_dev *dev)
 {
        release_mem_region(pci_resource_start(dev->pci,0),
                           pci_resource_len(dev->pci,0));
@@ -832,7 +914,15 @@ void cx23885_dev_unregister(struct cx23885_dev *dev)
        if (!atomic_dec_and_test(&dev->refcount))
                return;
 
-       cx23885_dvb_unregister(&dev->ts2);
+       if (cx23885_boards[dev->board].porta == CX23885_ANALOG_VIDEO)
+               cx23885_video_unregister(dev);
+
+       if(cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
+               cx23885_dvb_unregister(&dev->ts1);
+
+       if(cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
+               cx23885_dvb_unregister(&dev->ts2);
+
        cx23885_i2c_unregister(&dev->i2c_bus[2]);
        cx23885_i2c_unregister(&dev->i2c_bus[1]);
        cx23885_i2c_unregister(&dev->i2c_bus[0]);
@@ -934,9 +1024,11 @@ int cx23885_risc_buffer(struct pci_dev *pci, struct btcx_riscmem *risc,
        return 0;
 }
 
-int cx23885_risc_databuffer(struct pci_dev *pci, struct btcx_riscmem *risc,
-                           struct scatterlist *sglist, unsigned int bpl,
-                           unsigned int lines)
+static int cx23885_risc_databuffer(struct pci_dev *pci,
+                                  struct btcx_riscmem *risc,
+                                  struct scatterlist *sglist,
+                                  unsigned int bpl,
+                                  unsigned int lines)
 {
        u32 instructions;
        u32 *rp;
@@ -964,7 +1056,7 @@ int cx23885_risc_databuffer(struct pci_dev *pci, struct btcx_riscmem *risc,
 }
 
 int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
-                        u32 reg, u32 mask, u32 value)
+                               u32 reg, u32 mask, u32 value)
 {
        u32 *rp;
        int rc;
@@ -986,12 +1078,65 @@ int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
 
 void cx23885_free_buffer(struct videobuf_queue *q, struct cx23885_buffer *buf)
 {
+       struct videobuf_dmabuf *dma = videobuf_to_dma(&buf->vb);
+
        BUG_ON(in_interrupt());
        videobuf_waiton(&buf->vb, 0, 0);
-       videobuf_dma_unmap(q, &buf->vb.dma);
-       videobuf_dma_free(&buf->vb.dma);
+       videobuf_dma_unmap(q, dma);
+       videobuf_dma_free(dma);
        btcx_riscmem_free((struct pci_dev *)q->dev, &buf->risc);
-       buf->vb.state = STATE_NEEDS_INIT;
+       buf->vb.state = VIDEOBUF_NEEDS_INIT;
+}
+
+static void cx23885_tsport_reg_dump(struct cx23885_tsport *port)
+{
+       struct cx23885_dev *dev = port->dev;
+
+       dprintk(1, "%s() Register Dump\n", __FUNCTION__);
+       dprintk(1, "%s() DEV_CNTRL2               0x%08X\n", __FUNCTION__,
+               cx_read(DEV_CNTRL2));
+       dprintk(1, "%s() PCI_INT_MSK              0x%08X\n", __FUNCTION__,
+               cx_read(PCI_INT_MSK));
+       dprintk(1, "%s() AUD_INT_INT_MSK          0x%08X\n", __FUNCTION__,
+               cx_read(AUDIO_INT_INT_MSK));
+       dprintk(1, "%s() AUD_INT_DMA_CTL          0x%08X\n", __FUNCTION__,
+               cx_read(AUD_INT_DMA_CTL));
+       dprintk(1, "%s() AUD_EXT_INT_MSK          0x%08X\n", __FUNCTION__,
+               cx_read(AUDIO_EXT_INT_MSK));
+       dprintk(1, "%s() AUD_EXT_DMA_CTL          0x%08X\n", __FUNCTION__,
+               cx_read(AUD_EXT_DMA_CTL));
+       dprintk(1, "%s() PAD_CTRL                 0x%08X\n", __FUNCTION__,
+               cx_read(PAD_CTRL));
+       dprintk(1, "%s() ALT_PIN_OUT_SEL          0x%08X\n", __FUNCTION__,
+               cx_read(ALT_PIN_OUT_SEL));
+       dprintk(1, "%s() GPIO2                    0x%08X\n", __FUNCTION__,
+               cx_read(GPIO2));
+       dprintk(1, "%s() gpcnt(0x%08X)          0x%08X\n", __FUNCTION__,
+               port->reg_gpcnt, cx_read(port->reg_gpcnt));
+       dprintk(1, "%s() gpcnt_ctl(0x%08X)      0x%08x\n", __FUNCTION__,
+               port->reg_gpcnt_ctl, cx_read(port->reg_gpcnt_ctl));
+       dprintk(1, "%s() dma_ctl(0x%08X)        0x%08x\n", __FUNCTION__,
+               port->reg_dma_ctl, cx_read(port->reg_dma_ctl));
+       dprintk(1, "%s() src_sel(0x%08X)        0x%08x\n", __FUNCTION__,
+               port->reg_src_sel, cx_read(port->reg_src_sel));
+       dprintk(1, "%s() lngth(0x%08X)          0x%08x\n", __FUNCTION__,
+               port->reg_lngth, cx_read(port->reg_lngth));
+       dprintk(1, "%s() hw_sop_ctrl(0x%08X)    0x%08x\n", __FUNCTION__,
+               port->reg_hw_sop_ctrl, cx_read(port->reg_hw_sop_ctrl));
+       dprintk(1, "%s() gen_ctrl(0x%08X)       0x%08x\n", __FUNCTION__,
+               port->reg_gen_ctrl, cx_read(port->reg_gen_ctrl));
+       dprintk(1, "%s() bd_pkt_status(0x%08X)  0x%08x\n", __FUNCTION__,
+               port->reg_bd_pkt_status, cx_read(port->reg_bd_pkt_status));
+       dprintk(1, "%s() sop_status(0x%08X)     0x%08x\n", __FUNCTION__,
+               port->reg_sop_status, cx_read(port->reg_sop_status));
+       dprintk(1, "%s() fifo_ovfl_stat(0x%08X) 0x%08x\n", __FUNCTION__,
+               port->reg_fifo_ovfl_stat, cx_read(port->reg_fifo_ovfl_stat));
+       dprintk(1, "%s() vld_misc(0x%08X)       0x%08x\n", __FUNCTION__,
+               port->reg_vld_misc, cx_read(port->reg_vld_misc));
+       dprintk(1, "%s() ts_clk_en(0x%08X)      0x%08x\n", __FUNCTION__,
+               port->reg_ts_clk_en, cx_read(port->reg_ts_clk_en));
+       dprintk(1, "%s() ts_int_msk(0x%08X)     0x%08x\n", __FUNCTION__,
+               port->reg_ts_int_msk, cx_read(port->reg_ts_int_msk));
 }
 
 static int cx23885_start_dma(struct cx23885_tsport *port,
@@ -1015,32 +1160,28 @@ static int cx23885_start_dma(struct cx23885_tsport *port,
        /* write TS length to chip */
        cx_write(port->reg_lngth, buf->vb.width);
 
-       if (!(cx23885_boards[dev->board].portc & CX23885_MPEG_DVB)) {
-               printk( "%s() Failed. Unsupported value in .portc (0x%08x)\n",
-                       __FUNCTION__, cx23885_boards[dev->board].portc );
+       if ( (!(cx23885_boards[dev->board].portb & CX23885_MPEG_DVB)) &&
+               (!(cx23885_boards[dev->board].portc & CX23885_MPEG_DVB)) ) {
+               printk( "%s() Failed. Unsupported value in .portb/c (0x%08x)/(0x%08x)\n",
+                       __FUNCTION__,
+                       cx23885_boards[dev->board].portb,
+                       cx23885_boards[dev->board].portc );
                return -EINVAL;
        }
 
        udelay(100);
 
+       /* If the port supports SRC SELECT, configure it */
+       if(port->reg_src_sel)
+               cx_write(port->reg_src_sel, port->src_sel_val);
+
        cx_write(port->reg_hw_sop_ctrl, 0x47 << 16 | 188 << 4);
        cx_write(port->reg_ts_clk_en, port->ts_clk_en_val);
-
-       switch (dev->board) {
-       case CX23885_BOARD_HAUPPAUGE_HVR1250:
-       case CX23885_BOARD_HAUPPAUGE_HVR1800lp:
-       case CX23885_BOARD_HAUPPAUGE_HVR1800:
-               cx_write(port->reg_vld_misc, 0x00);
-               dprintk(1, "%s() Configuring HVR1800/lp/1500 board\n",
-                       __FUNCTION__);
-               break;
-       default:
-               printk(KERN_ERR "%s() error, default case", __FUNCTION__ );
-       }
-
+       cx_write(port->reg_vld_misc, 0x00);
        cx_write(port->reg_gen_ctrl, port->gen_ctrl_val);
        udelay(100);
 
+       // NOTE: this is 2 (reserved) for portb, does it matter?
        /* reset counter to zero */
        cx_write(port->reg_gpcnt_ctl, 3);
        q->count = 1;
@@ -1055,11 +1196,14 @@ static int cx23885_start_dma(struct cx23885_tsport *port,
                cx_set(PCI_INT_MSK, dev->pci_irqmask | port->pci_irqmask);
                break;
        default:
-               printk(KERN_ERR "%s() error, default case", __FUNCTION__ );
+               BUG();
        }
 
        cx_set(DEV_CNTRL2, (1<<5)); /* Enable RISC controller */
 
+       if (debug > 4)
+               cx23885_tsport_reg_dump(port);
+
        return 0;
 }
 
@@ -1075,12 +1219,11 @@ static int cx23885_stop_dma(struct cx23885_tsport *port)
        return 0;
 }
 
-static int cx23885_restart_queue(struct cx23885_tsport *port,
+int cx23885_restart_queue(struct cx23885_tsport *port,
                                struct cx23885_dmaqueue *q)
 {
        struct cx23885_dev *dev = port->dev;
        struct cx23885_buffer *buf;
-       struct list_head *item;
 
        dprintk(5, "%s()\n", __FUNCTION__);
        if (list_empty(&q->active))
@@ -1099,7 +1242,7 @@ static int cx23885_restart_queue(struct cx23885_tsport *port,
                                list_del(&buf->vb.queue);
                                list_add_tail(&buf->vb.queue, &q->active);
                                cx23885_start_dma(port, q, buf);
-                               buf->vb.state = STATE_ACTIVE;
+                               buf->vb.state = VIDEOBUF_ACTIVE;
                                buf->count    = q->count++;
                                mod_timer(&q->timeout, jiffies+BUFFER_TIMEOUT);
                                dprintk(5, "[%p/%d] restart_queue - first active\n",
@@ -1110,7 +1253,7 @@ static int cx23885_restart_queue(struct cx23885_tsport *port,
                                   prev->fmt       == buf->fmt) {
                                list_del(&buf->vb.queue);
                                list_add_tail(&buf->vb.queue, &q->active);
-                               buf->vb.state = STATE_ACTIVE;
+                               buf->vb.state = VIDEOBUF_ACTIVE;
                                buf->count    = q->count++;
                                prev->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
                                prev->risc.jmp[2] = cpu_to_le32(0); /* 64 bit bits 63-32 */
@@ -1128,10 +1271,8 @@ static int cx23885_restart_queue(struct cx23885_tsport *port,
        dprintk(2, "restart_queue [%p/%d]: restart dma\n",
                buf, buf->vb.i);
        cx23885_start_dma(port, q, buf);
-       list_for_each(item, &q->active) {
-               buf = list_entry(item, struct cx23885_buffer, vb.queue);
+       list_for_each_entry(buf, &q->active, vb.queue)
                buf->count = q->count++;
-       }
        mod_timer(&q->timeout, jiffies + BUFFER_TIMEOUT);
        return 0;
 }
@@ -1149,7 +1290,7 @@ int cx23885_buf_prepare(struct videobuf_queue *q, struct cx23885_tsport *port,
        if (0 != buf->vb.baddr  &&  buf->vb.bsize < size)
                return -EINVAL;
 
-       if (STATE_NEEDS_INIT == buf->vb.state) {
+       if (VIDEOBUF_NEEDS_INIT == buf->vb.state) {
                buf->vb.width  = port->ts_packet_size;
                buf->vb.height = port->ts_packet_count;
                buf->vb.size   = size;
@@ -1158,10 +1299,10 @@ int cx23885_buf_prepare(struct videobuf_queue *q, struct cx23885_tsport *port,
                if (0 != (rc = videobuf_iolock(q, &buf->vb, NULL)))
                        goto fail;
                cx23885_risc_databuffer(dev->pci, &buf->risc,
-                                    buf->vb.dma.sglist,
-                                    buf->vb.width, buf->vb.height);
+                                       videobuf_to_dma(&buf->vb)->sglist,
+                                       buf->vb.width, buf->vb.height);
        }
-       buf->vb.state = STATE_PREPARED;
+       buf->vb.state = VIDEOBUF_PREPARED;
        return 0;
 
  fail:
@@ -1184,7 +1325,7 @@ void cx23885_buf_queue(struct cx23885_tsport *port, struct cx23885_buffer *buf)
                dprintk( 1, "queue is empty - first active\n" );
                list_add_tail(&buf->vb.queue, &cx88q->active);
                cx23885_start_dma(port, cx88q, buf);
-               buf->vb.state = STATE_ACTIVE;
+               buf->vb.state = VIDEOBUF_ACTIVE;
                buf->count    = cx88q->count++;
                mod_timer(&cx88q->timeout, jiffies + BUFFER_TIMEOUT);
                dprintk(1, "[%p/%d] %s - first active\n",
@@ -1194,7 +1335,7 @@ void cx23885_buf_queue(struct cx23885_tsport *port, struct cx23885_buffer *buf)
                prev = list_entry(cx88q->active.prev, struct cx23885_buffer,
                                  vb.queue);
                list_add_tail(&buf->vb.queue, &cx88q->active);
-               buf->vb.state = STATE_ACTIVE;
+               buf->vb.state = VIDEOBUF_ACTIVE;
                buf->count    = cx88q->count++;
                prev->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
                prev->risc.jmp[2] = cpu_to_le32(0); /* 64 bit bits 63-32 */
@@ -1218,7 +1359,7 @@ static void do_cancel_buffers(struct cx23885_tsport *port, char *reason,
                buf = list_entry(q->active.next, struct cx23885_buffer,
                                 vb.queue);
                list_del(&buf->vb.queue);
-               buf->vb.state = STATE_ERROR;
+               buf->vb.state = VIDEOBUF_ERROR;
                wake_up(&buf->vb.done);
                dprintk(1, "[%p/%d] %s - dma=0x%08lx\n",
                        buf, buf->vb.i, reason, (unsigned long)buf->risc.dma);
@@ -1230,16 +1371,6 @@ static void do_cancel_buffers(struct cx23885_tsport *port, char *reason,
        spin_unlock_irqrestore(&port->slock, flags);
 }
 
-void cx23885_cancel_buffers(struct cx23885_tsport *port)
-{
-       struct cx23885_dev *dev = port->dev;
-       struct cx23885_dmaqueue *q = &port->mpegq;
-
-       dprintk(1, "%s()\n", __FUNCTION__);
-       del_timer_sync(&q->timeout);
-       cx23885_stop_dma(port);
-       do_cancel_buffers(port, "cancel", 0);
-}
 
 static void cx23885_timeout(unsigned long data)
 {
@@ -1255,26 +1386,91 @@ static void cx23885_timeout(unsigned long data)
        do_cancel_buffers(port, "timeout", 1);
 }
 
+static int cx23885_irq_ts(struct cx23885_tsport *port, u32 status)
+{
+       struct cx23885_dev *dev = port->dev;
+       int handled = 0;
+       u32 count;
+
+       if ( (status & VID_BC_MSK_OPC_ERR) ||
+            (status & VID_BC_MSK_BAD_PKT) ||
+            (status & VID_BC_MSK_SYNC) ||
+            (status & VID_BC_MSK_OF))
+       {
+               if (status & VID_BC_MSK_OPC_ERR)
+                       dprintk(7, " (VID_BC_MSK_OPC_ERR 0x%08x)\n", VID_BC_MSK_OPC_ERR);
+               if (status & VID_BC_MSK_BAD_PKT)
+                       dprintk(7, " (VID_BC_MSK_BAD_PKT 0x%08x)\n", VID_BC_MSK_BAD_PKT);
+               if (status & VID_BC_MSK_SYNC)
+                       dprintk(7, " (VID_BC_MSK_SYNC    0x%08x)\n", VID_BC_MSK_SYNC);
+               if (status & VID_BC_MSK_OF)
+                       dprintk(7, " (VID_BC_MSK_OF      0x%08x)\n", VID_BC_MSK_OF);
+
+               printk(KERN_ERR "%s: mpeg risc op code error\n", dev->name);
+
+               cx_clear(port->reg_dma_ctl, port->dma_ctl_val);
+               cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ]);
+
+       } else if (status & VID_BC_MSK_RISCI1) {
+
+               dprintk(7, " (RISCI1            0x%08x)\n", VID_BC_MSK_RISCI1);
+
+               spin_lock(&port->slock);
+               count = cx_read(port->reg_gpcnt);
+               cx23885_wakeup(port, &port->mpegq, count);
+               spin_unlock(&port->slock);
+
+       } else if (status & VID_BC_MSK_RISCI2) {
+
+               dprintk(7, " (RISCI2            0x%08x)\n", VID_BC_MSK_RISCI2);
+
+               spin_lock(&port->slock);
+               cx23885_restart_queue(port, &port->mpegq);
+               spin_unlock(&port->slock);
+
+       }
+       if (status) {
+               cx_write(port->reg_ts_int_stat, status);
+               handled = 1;
+       }
+
+       return handled;
+}
+
 static irqreturn_t cx23885_irq(int irq, void *dev_id)
 {
        struct cx23885_dev *dev = dev_id;
-       struct cx23885_tsport *port = &dev->ts2;
+       struct cx23885_tsport *ts1 = &dev->ts1;
+       struct cx23885_tsport *ts2 = &dev->ts2;
        u32 pci_status, pci_mask;
+       u32 vida_status, vida_mask;
+       u32 ts1_status, ts1_mask;
        u32 ts2_status, ts2_mask;
-       int count = 0, handled = 0;
+       int vida_count = 0, ts1_count = 0, ts2_count = 0, handled = 0;
 
        pci_status = cx_read(PCI_INT_STAT);
        pci_mask = cx_read(PCI_INT_MSK);
-
+       vida_status = cx_read(VID_A_INT_STAT);
+       vida_mask = cx_read(VID_A_INT_MSK);
+       ts1_status = cx_read(VID_B_INT_STAT);
+       ts1_mask = cx_read(VID_B_INT_MSK);
        ts2_status = cx_read(VID_C_INT_STAT);
        ts2_mask = cx_read(VID_C_INT_MSK);
 
-       if ( (pci_status == 0) && (ts2_status == 0) )
+       if ( (pci_status == 0) && (ts2_status == 0) && (ts1_status == 0) )
                goto out;
 
-       count = cx_read(port->reg_gpcnt);
-       dprintk(7, "pci_status: 0x%08x  pci_mask: 0x%08x\n", pci_status, pci_mask );
-       dprintk(7, "ts2_status: 0x%08x  ts2_mask: 0x%08x count: 0x%x\n", ts2_status, ts2_mask, count );
+       vida_count = cx_read(VID_A_GPCNT);
+       ts1_count = cx_read(ts1->reg_gpcnt);
+       ts2_count = cx_read(ts2->reg_gpcnt);
+       dprintk(7, "pci_status: 0x%08x  pci_mask: 0x%08x\n",
+               pci_status, pci_mask);
+       dprintk(7, "vida_status: 0x%08x vida_mask: 0x%08x count: 0x%x\n",
+               vida_status, vida_mask, vida_count);
+       dprintk(7, "ts1_status: 0x%08x  ts1_mask: 0x%08x count: 0x%x\n",
+               ts1_status, ts1_mask, ts1_count);
+       dprintk(7, "ts2_status: 0x%08x  ts2_mask: 0x%08x count: 0x%x\n",
+               ts2_status, ts2_mask, ts2_count);
 
        if ( (pci_status & PCI_MSK_RISC_RD) ||
             (pci_status & PCI_MSK_RISC_WR) ||
@@ -1311,47 +1507,21 @@ static irqreturn_t cx23885_irq(int irq, void *dev_id)
 
        }
 
-       if ( (ts2_status & VID_C_MSK_OPC_ERR) ||
-            (ts2_status & VID_C_MSK_BAD_PKT) ||
-            (ts2_status & VID_C_MSK_SYNC) ||
-            (ts2_status & VID_C_MSK_OF))
-       {
-               if (ts2_status & VID_C_MSK_OPC_ERR)
-                       dprintk(7, " (VID_C_MSK_OPC_ERR 0x%08x)\n", VID_C_MSK_OPC_ERR);
-               if (ts2_status & VID_C_MSK_BAD_PKT)
-                       dprintk(7, " (VID_C_MSK_BAD_PKT 0x%08x)\n", VID_C_MSK_BAD_PKT);
-               if (ts2_status & VID_C_MSK_SYNC)
-                       dprintk(7, " (VID_C_MSK_SYNC    0x%08x)\n", VID_C_MSK_SYNC);
-               if (ts2_status & VID_C_MSK_OF)
-                       dprintk(7, " (VID_C_MSK_OF      0x%08x)\n", VID_C_MSK_OF);
-
-               printk(KERN_ERR "%s: mpeg risc op code error\n", dev->name);
-
-               cx_clear(port->reg_dma_ctl, port->dma_ctl_val);
-               cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ]);
-
-       } else if (ts2_status & VID_C_MSK_RISCI1) {
-
-               dprintk(7, " (RISCI1            0x%08x)\n", VID_C_MSK_RISCI1);
-
-               spin_lock(&port->slock);
-               count = cx_read(port->reg_gpcnt);
-               cx23885_wakeup(port, &port->mpegq, count);
-               spin_unlock(&port->slock);
-
-       } else if (ts2_status & VID_C_MSK_RISCI2) {
-
-               dprintk(7, " (RISCI2            0x%08x)\n", VID_C_MSK_RISCI2);
-
-               spin_lock(&port->slock);
-               cx23885_restart_queue(port, &port->mpegq);
-               spin_unlock(&port->slock);
+       if (ts1_status) {
+               if (cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
+                       handled += cx23885_irq_ts(ts1, ts1_status);
+       }
 
+       if (ts2_status) {
+               if (cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
+                       handled += cx23885_irq_ts(ts2, ts2_status);
        }
 
-       cx_write(VID_C_INT_STAT, ts2_status);
-       cx_write(PCI_INT_STAT, pci_status);
-       handled = 1;
+       if (vida_status)
+               handled += cx23885_video_irq(dev, vida_status);
+
+       if (handled)
+               cx_write(PCI_INT_STAT, pci_status);
 out:
        return IRQ_RETVAL(handled);
 }