[media] v4l2: pass std by value to the write-only s_std ioctl
[sfrench/cifs-2.6.git] / drivers / media / usb / cx231xx / cx231xx-417.c
index 28688dbcb6090cfab70386e7ac03b3526875598e..f548db8043d4bb1bfc52d7739348ac72d45d78f7 100644 (file)
 #include <linux/vmalloc.h>
 #include <media/v4l2-common.h>
 #include <media/v4l2-ioctl.h>
+#include <media/v4l2-event.h>
 #include <media/cx2341x.h>
+#include <media/tuner.h>
 #include <linux/usb.h>
 
 #include "cx231xx.h"
-/*#include "cx23885-ioctl.h"*/
 
 #define CX231xx_FIRM_IMAGE_SIZE 376836
 #define CX231xx_FIRM_IMAGE_NAME "v4l-cx23885-enc.fw"
 static unsigned int mpegbufs = 8;
 module_param(mpegbufs, int, 0644);
 MODULE_PARM_DESC(mpegbufs, "number of mpeg buffers, range 2-32");
+
 static unsigned int mpeglines = 128;
 module_param(mpeglines, int, 0644);
 MODULE_PARM_DESC(mpeglines, "number of lines in an MPEG buffer, range 2-32");
+
 static unsigned int mpeglinesize = 512;
 module_param(mpeglinesize, int, 0644);
 MODULE_PARM_DESC(mpeglinesize,
@@ -86,10 +89,10 @@ MODULE_PARM_DESC(mpeglinesize,
 static unsigned int v4l_debug = 1;
 module_param(v4l_debug, int, 0644);
 MODULE_PARM_DESC(v4l_debug, "enable V4L debug messages");
-struct cx231xx_dmaqueue *dma_qq;
+
 #define dprintk(level, fmt, arg...)\
        do { if (v4l_debug >= level) \
-               printk(KERN_INFO "%s: " fmt, \
+               pr_info("%s: " fmt, \
                (dev) ? dev->name : "cx231xx[?]", ## arg); \
        } while (0)
 
@@ -131,11 +134,13 @@ static struct cx231xx_tvnorm cx231xx_tvnorms[] = {
 };
 
 /* ------------------------------------------------------------------ */
+
 enum cx231xx_capture_type {
        CX231xx_MPEG_CAPTURE,
        CX231xx_RAW_CAPTURE,
        CX231xx_RAW_PASSTHRU_CAPTURE
 };
+
 enum cx231xx_capture_bits {
        CX231xx_RAW_BITS_NONE             = 0x00,
        CX231xx_RAW_BITS_YUV_CAPTURE      = 0x01,
@@ -144,33 +149,40 @@ enum cx231xx_capture_bits {
        CX231xx_RAW_BITS_PASSTHRU_CAPTURE = 0x08,
        CX231xx_RAW_BITS_TO_HOST_CAPTURE  = 0x10
 };
+
 enum cx231xx_capture_end {
        CX231xx_END_AT_GOP, /* stop at the end of gop, generate irq */
        CX231xx_END_NOW, /* stop immediately, no irq */
 };
+
 enum cx231xx_framerate {
        CX231xx_FRAMERATE_NTSC_30, /* NTSC: 30fps */
        CX231xx_FRAMERATE_PAL_25   /* PAL: 25fps */
 };
+
 enum cx231xx_stream_port {
        CX231xx_OUTPUT_PORT_MEMORY,
        CX231xx_OUTPUT_PORT_STREAMING,
        CX231xx_OUTPUT_PORT_SERIAL
 };
+
 enum cx231xx_data_xfer_status {
        CX231xx_MORE_BUFFERS_FOLLOW,
        CX231xx_LAST_BUFFER,
 };
+
 enum cx231xx_picture_mask {
        CX231xx_PICTURE_MASK_NONE,
        CX231xx_PICTURE_MASK_I_FRAMES,
        CX231xx_PICTURE_MASK_I_P_FRAMES = 0x3,
        CX231xx_PICTURE_MASK_ALL_FRAMES = 0x7,
 };
+
 enum cx231xx_vbi_mode_bits {
        CX231xx_VBI_BITS_SLICED,
        CX231xx_VBI_BITS_RAW,
 };
+
 enum cx231xx_vbi_insertion_bits {
        CX231xx_VBI_BITS_INSERT_IN_XTENSION_USR_DATA,
        CX231xx_VBI_BITS_INSERT_IN_PRIVATE_PACKETS = 0x1 << 1,
@@ -178,56 +190,69 @@ enum cx231xx_vbi_insertion_bits {
        CX231xx_VBI_BITS_SEPARATE_STREAM_USR_DATA = 0x4 << 1,
        CX231xx_VBI_BITS_SEPARATE_STREAM_PRV_DATA = 0x5 << 1,
 };
+
 enum cx231xx_dma_unit {
        CX231xx_DMA_BYTES,
        CX231xx_DMA_FRAMES,
 };
+
 enum cx231xx_dma_transfer_status_bits {
        CX231xx_DMA_TRANSFER_BITS_DONE = 0x01,
        CX231xx_DMA_TRANSFER_BITS_ERROR = 0x04,
        CX231xx_DMA_TRANSFER_BITS_LL_ERROR = 0x10,
 };
+
 enum cx231xx_pause {
        CX231xx_PAUSE_ENCODING,
        CX231xx_RESUME_ENCODING,
 };
+
 enum cx231xx_copyright {
        CX231xx_COPYRIGHT_OFF,
        CX231xx_COPYRIGHT_ON,
 };
+
 enum cx231xx_notification_type {
        CX231xx_NOTIFICATION_REFRESH,
 };
+
 enum cx231xx_notification_status {
        CX231xx_NOTIFICATION_OFF,
        CX231xx_NOTIFICATION_ON,
 };
+
 enum cx231xx_notification_mailbox {
        CX231xx_NOTIFICATION_NO_MAILBOX = -1,
 };
+
 enum cx231xx_field1_lines {
        CX231xx_FIELD1_SAA7114 = 0x00EF, /* 239 */
        CX231xx_FIELD1_SAA7115 = 0x00F0, /* 240 */
        CX231xx_FIELD1_MICRONAS = 0x0105, /* 261 */
 };
+
 enum cx231xx_field2_lines {
        CX231xx_FIELD2_SAA7114 = 0x00EF, /* 239 */
        CX231xx_FIELD2_SAA7115 = 0x00F0, /* 240 */
        CX231xx_FIELD2_MICRONAS = 0x0106, /* 262 */
 };
+
 enum cx231xx_custom_data_type {
        CX231xx_CUSTOM_EXTENSION_USR_DATA,
        CX231xx_CUSTOM_PRIVATE_PACKET,
 };
+
 enum cx231xx_mute {
        CX231xx_UNMUTE,
        CX231xx_MUTE,
 };
+
 enum cx231xx_mute_video_mask {
        CX231xx_MUTE_VIDEO_V_MASK = 0x0000FF00,
        CX231xx_MUTE_VIDEO_U_MASK = 0x00FF0000,
        CX231xx_MUTE_VIDEO_Y_MASK = 0xFF000000,
 };
+
 enum cx231xx_mute_video_shift {
        CX231xx_MUTE_VIDEO_V_SHIFT = 8,
        CX231xx_MUTE_VIDEO_U_SHIFT = 16,
@@ -296,41 +321,43 @@ enum cx231xx_mute_video_shift {
 
 
 #define CX23417_GPIO_MASK 0xFC0003FF
-static int setITVCReg(struct cx231xx *dev, u32 gpio_direction, u32 value)
+
+static int set_itvc_reg(struct cx231xx *dev, u32 gpio_direction, u32 value)
 {
        int status = 0;
        u32 _gpio_direction = 0;
 
        _gpio_direction = _gpio_direction & CX23417_GPIO_MASK;
-       _gpio_direction = _gpio_direction|gpio_direction;
+       _gpio_direction = _gpio_direction | gpio_direction;
        status = cx231xx_send_gpio_cmd(dev, _gpio_direction,
                         (u8 *)&value, 4, 0, 0);
        return status;
 }
-static int getITVCReg(struct cx231xx *dev, u32 gpio_direction, u32 *pValue)
+
+static int get_itvc_reg(struct cx231xx *dev, u32 gpio_direction, u32 *val_ptr)
 {
        int status = 0;
        u32 _gpio_direction = 0;
 
        _gpio_direction = _gpio_direction & CX23417_GPIO_MASK;
-       _gpio_direction = _gpio_direction|gpio_direction;
+       _gpio_direction = _gpio_direction | gpio_direction;
 
        status = cx231xx_send_gpio_cmd(dev, _gpio_direction,
-                (u8 *)pValue, 4, 0, 1);
+                (u8 *)val_ptr, 4, 0, 1);
        return status;
 }
 
-static int waitForMciComplete(struct cx231xx *dev)
+static int wait_for_mci_complete(struct cx231xx *dev)
 {
        u32 gpio;
-       u32 gpio_driection = 0;
+       u32 gpio_direction = 0;
        u8 count = 0;
-       getITVCReg(dev, gpio_driection, &gpio);
+       get_itvc_reg(dev, gpio_direction, &gpio);
 
        while (!(gpio&0x020000)) {
                msleep(10);
 
-               getITVCReg(dev, gpio_driection, &gpio);
+               get_itvc_reg(dev, gpio_direction, &gpio);
 
                if (count++ > 100) {
                        dprintk(3, "ERROR: Timeout - gpio=%x\n", gpio);
@@ -345,57 +372,57 @@ static int mc417_register_write(struct cx231xx *dev, u16 address, u32 value)
        u32 temp;
        int status = 0;
 
-       temp = 0x82|MCI_REGISTER_DATA_BYTE0|((value&0x000000FF)<<8);
-       temp = temp<<10;
-       status = setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_REGISTER_DATA_BYTE0 | ((value & 0x000000FF) << 8);
+       temp = temp << 10;
+       status = set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
        if (status < 0)
                return status;
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write data byte 1;*/
-       temp = 0x82|MCI_REGISTER_DATA_BYTE1|(value&0x0000FF00);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_REGISTER_DATA_BYTE1 | (value & 0x0000FF00);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write data byte 2;*/
-       temp = 0x82|MCI_REGISTER_DATA_BYTE2|((value&0x00FF0000)>>8);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_REGISTER_DATA_BYTE2 | ((value & 0x00FF0000) >> 8);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write data byte 3;*/
-       temp = 0x82|MCI_REGISTER_DATA_BYTE3|((value&0xFF000000)>>16);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_REGISTER_DATA_BYTE3 | ((value & 0xFF000000) >> 16);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write address byte 0;*/
-       temp = 0x82|MCI_REGISTER_ADDRESS_BYTE0|((address&0x000000FF)<<8);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_REGISTER_ADDRESS_BYTE0 | ((address & 0x000000FF) << 8);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write address byte 1;*/
-       temp = 0x82|MCI_REGISTER_ADDRESS_BYTE1|(address&0x0000FF00);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_REGISTER_ADDRESS_BYTE1 | (address & 0x0000FF00);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*Write that the mode is write.*/
        temp = 0x82 | MCI_REGISTER_MODE | MCI_MODE_REGISTER_WRITE;
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
-       return waitForMciComplete(dev);
+       return wait_for_mci_complete(dev);
 }
 
 static int mc417_register_read(struct cx231xx *dev, u16 address, u32 *value)
@@ -407,70 +434,68 @@ static int mc417_register_read(struct cx231xx *dev, u16 address, u32 *value)
 
        temp = 0x82 | MCI_REGISTER_ADDRESS_BYTE0 | ((address & 0x00FF) << 8);
        temp = temp << 10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
        temp = temp | ((0x05) << 10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write address byte 1;*/
        temp = 0x82 | MCI_REGISTER_ADDRESS_BYTE1 | (address & 0xFF00);
        temp = temp << 10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
        temp = temp | ((0x05) << 10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write that the mode is read;*/
        temp = 0x82 | MCI_REGISTER_MODE | MCI_MODE_REGISTER_READ;
        temp = temp << 10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
        temp = temp | ((0x05) << 10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*wait for the MIRDY line to be asserted ,
        signalling that the read is done;*/
-       ret = waitForMciComplete(dev);
+       ret = wait_for_mci_complete(dev);
 
        /*switch the DATA- GPIO to input mode;*/
 
        /*Read data byte 0;*/
        temp = (0x82 | MCI_REGISTER_DATA_BYTE0) << 10;
-       setITVCReg(dev, ITVC_READ_DIR, temp);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
        temp = ((0x81 | MCI_REGISTER_DATA_BYTE0) << 10);
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       getITVCReg(dev, ITVC_READ_DIR, &temp);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       get_itvc_reg(dev, ITVC_READ_DIR, &temp);
        return_value |= ((temp & 0x03FC0000) >> 18);
-       setITVCReg(dev, ITVC_READ_DIR, (0x87 << 10));
+       set_itvc_reg(dev, ITVC_READ_DIR, (0x87 << 10));
 
        /* Read data byte 1;*/
        temp = (0x82 | MCI_REGISTER_DATA_BYTE1) << 10;
-       setITVCReg(dev, ITVC_READ_DIR, temp);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
        temp = ((0x81 | MCI_REGISTER_DATA_BYTE1) << 10);
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       getITVCReg(dev, ITVC_READ_DIR, &temp);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       get_itvc_reg(dev, ITVC_READ_DIR, &temp);
 
        return_value |= ((temp & 0x03FC0000) >> 10);
-       setITVCReg(dev, ITVC_READ_DIR, (0x87 << 10));
+       set_itvc_reg(dev, ITVC_READ_DIR, (0x87 << 10));
 
        /*Read data byte 2;*/
        temp = (0x82 | MCI_REGISTER_DATA_BYTE2) << 10;
-       setITVCReg(dev, ITVC_READ_DIR, temp);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
        temp = ((0x81 | MCI_REGISTER_DATA_BYTE2) << 10);
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       getITVCReg(dev, ITVC_READ_DIR, &temp);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       get_itvc_reg(dev, ITVC_READ_DIR, &temp);
        return_value |= ((temp & 0x03FC0000) >> 2);
-       setITVCReg(dev, ITVC_READ_DIR, (0x87 << 10));
+       set_itvc_reg(dev, ITVC_READ_DIR, (0x87 << 10));
 
        /*Read data byte 3;*/
        temp = (0x82 | MCI_REGISTER_DATA_BYTE3) << 10;
-       setITVCReg(dev, ITVC_READ_DIR, temp);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
        temp = ((0x81 | MCI_REGISTER_DATA_BYTE3) << 10);
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       getITVCReg(dev, ITVC_READ_DIR, &temp);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       get_itvc_reg(dev, ITVC_READ_DIR, &temp);
        return_value |= ((temp & 0x03FC0000) << 6);
-       setITVCReg(dev, ITVC_READ_DIR, (0x87 << 10));
+       set_itvc_reg(dev, ITVC_READ_DIR, (0x87 << 10));
 
        *value  = return_value;
-
-
        return ret;
 }
 
@@ -481,59 +506,59 @@ static int mc417_memory_write(struct cx231xx *dev, u32 address, u32 value)
        u32 temp;
        int ret = 0;
 
-       temp = 0x82 | MCI_MEMORY_DATA_BYTE0|((value & 0x000000FF) << 8);
+       temp = 0x82 | MCI_MEMORY_DATA_BYTE0 | ((value & 0x000000FF) << 8);
        temp = temp << 10;
-       ret = setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       ret = set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
        if (ret < 0)
                return ret;
-       temp = temp | ((0x05) << 10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write data byte 1;*/
        temp = 0x82 | MCI_MEMORY_DATA_BYTE1 | (value & 0x0000FF00);
        temp = temp << 10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp | ((0x05) << 10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write data byte 2;*/
-       temp = 0x82|MCI_MEMORY_DATA_BYTE2|((value&0x00FF0000)>>8);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_MEMORY_DATA_BYTE2 | ((value & 0x00FF0000) >> 8);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write data byte 3;*/
-       temp = 0x82|MCI_MEMORY_DATA_BYTE3|((value&0xFF000000)>>16);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_MEMORY_DATA_BYTE3 | ((value & 0xFF000000) >> 16);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /* write address byte 2;*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE2 | MCI_MODE_MEMORY_WRITE |
-               ((address & 0x003F0000)>>8);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE2 | MCI_MODE_MEMORY_WRITE |
+               ((address & 0x003F0000) >> 8);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /* write address byte 1;*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE1 | (address & 0xFF00);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE1 | (address & 0xFF00);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /* write address byte 0;*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE0|((address & 0x00FF)<<8);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE0 | ((address & 0x00FF) << 8);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*wait for MIRDY line;*/
-       waitForMciComplete(dev);
+       wait_for_mci_complete(dev);
 
        return 0;
 }
@@ -545,68 +570,68 @@ static int mc417_memory_read(struct cx231xx *dev, u32 address, u32 *value)
        int ret = 0;
 
        /*write address byte 2;*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE2 | MCI_MODE_MEMORY_READ |
-               ((address & 0x003F0000)>>8);
-       temp = temp<<10;
-       ret = setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE2 | MCI_MODE_MEMORY_READ |
+               ((address & 0x003F0000) >> 8);
+       temp = temp << 10;
+       ret = set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
        if (ret < 0)
                return ret;
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write address byte 1*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE1 | (address & 0xFF00);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE1 | (address & 0xFF00);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*write address byte 0*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE0 | ((address & 0x00FF)<<8);
-       temp = temp<<10;
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
-       temp = temp|((0x05)<<10);
-       setITVCReg(dev, ITVC_WRITE_DIR, temp);
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE0 | ((address & 0x00FF) << 8);
+       temp = temp << 10;
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
+       temp = temp | (0x05 << 10);
+       set_itvc_reg(dev, ITVC_WRITE_DIR, temp);
 
        /*Wait for MIRDY line*/
-       ret = waitForMciComplete(dev);
+       ret = wait_for_mci_complete(dev);
 
 
        /*Read data byte 3;*/
-       temp = (0x82|MCI_MEMORY_DATA_BYTE3)<<10;
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       temp = ((0x81|MCI_MEMORY_DATA_BYTE3)<<10);
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       getITVCReg(dev, ITVC_READ_DIR, &temp);
-       return_value |= ((temp&0x03FC0000)<<6);
-       setITVCReg(dev, ITVC_READ_DIR, (0x87<<10));
+       temp = (0x82 | MCI_MEMORY_DATA_BYTE3) << 10;
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       temp = ((0x81 | MCI_MEMORY_DATA_BYTE3) << 10);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       get_itvc_reg(dev, ITVC_READ_DIR, &temp);
+       return_value |= ((temp & 0x03FC0000) << 6);
+       set_itvc_reg(dev, ITVC_READ_DIR, (0x87 << 10));
 
        /*Read data byte 2;*/
-       temp = (0x82|MCI_MEMORY_DATA_BYTE2)<<10;
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       temp = ((0x81|MCI_MEMORY_DATA_BYTE2)<<10);
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       getITVCReg(dev, ITVC_READ_DIR, &temp);
-       return_value |= ((temp&0x03FC0000)>>2);
-       setITVCReg(dev, ITVC_READ_DIR, (0x87<<10));
+       temp = (0x82 | MCI_MEMORY_DATA_BYTE2) << 10;
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       temp = ((0x81 | MCI_MEMORY_DATA_BYTE2) << 10);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       get_itvc_reg(dev, ITVC_READ_DIR, &temp);
+       return_value |= ((temp & 0x03FC0000) >> 2);
+       set_itvc_reg(dev, ITVC_READ_DIR, (0x87 << 10));
 
        /* Read data byte 1;*/
-       temp = (0x82|MCI_MEMORY_DATA_BYTE1)<<10;
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       temp = ((0x81|MCI_MEMORY_DATA_BYTE1)<<10);
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       getITVCReg(dev, ITVC_READ_DIR, &temp);
-       return_value |= ((temp&0x03FC0000)>>10);
-       setITVCReg(dev, ITVC_READ_DIR, (0x87<<10));
+       temp = (0x82 | MCI_MEMORY_DATA_BYTE1) << 10;
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       temp = ((0x81 | MCI_MEMORY_DATA_BYTE1) << 10);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       get_itvc_reg(dev, ITVC_READ_DIR, &temp);
+       return_value |= ((temp & 0x03FC0000) >> 10);
+       set_itvc_reg(dev, ITVC_READ_DIR, (0x87 << 10));
 
        /*Read data byte 0;*/
-       temp = (0x82|MCI_MEMORY_DATA_BYTE0)<<10;
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       temp = ((0x81|MCI_MEMORY_DATA_BYTE0)<<10);
-       setITVCReg(dev, ITVC_READ_DIR, temp);
-       getITVCReg(dev, ITVC_READ_DIR, &temp);
-       return_value |= ((temp&0x03FC0000)>>18);
-       setITVCReg(dev, ITVC_READ_DIR, (0x87<<10));
+       temp = (0x82 | MCI_MEMORY_DATA_BYTE0) << 10;
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       temp = ((0x81 | MCI_MEMORY_DATA_BYTE0) << 10);
+       set_itvc_reg(dev, ITVC_READ_DIR, temp);
+       get_itvc_reg(dev, ITVC_READ_DIR, &temp);
+       return_value |= ((temp & 0x03FC0000) >> 18);
+       set_itvc_reg(dev, ITVC_READ_DIR, (0x87 << 10));
 
        *value  = return_value;
        return ret;
@@ -619,94 +644,91 @@ static char *cmd_to_str(int cmd)
 {
        switch (cmd) {
        case CX2341X_ENC_PING_FW:
-               return  "PING_FW";
+               return "PING_FW";
        case CX2341X_ENC_START_CAPTURE:
-               return  "START_CAPTURE";
+               return "START_CAPTURE";
        case CX2341X_ENC_STOP_CAPTURE:
-               return  "STOP_CAPTURE";
+               return "STOP_CAPTURE";
        case CX2341X_ENC_SET_AUDIO_ID:
-               return  "SET_AUDIO_ID";
+               return "SET_AUDIO_ID";
        case CX2341X_ENC_SET_VIDEO_ID:
-               return  "SET_VIDEO_ID";
+               return "SET_VIDEO_ID";
        case CX2341X_ENC_SET_PCR_ID:
-               return  "SET_PCR_PID";
+               return "SET_PCR_PID";
        case CX2341X_ENC_SET_FRAME_RATE:
-               return  "SET_FRAME_RATE";
+               return "SET_FRAME_RATE";
        case CX2341X_ENC_SET_FRAME_SIZE:
-               return  "SET_FRAME_SIZE";
+               return "SET_FRAME_SIZE";
        case CX2341X_ENC_SET_BIT_RATE:
-               return  "SET_BIT_RATE";
+               return "SET_BIT_RATE";
        case CX2341X_ENC_SET_GOP_PROPERTIES:
-               return  "SET_GOP_PROPERTIES";
+               return "SET_GOP_PROPERTIES";
        case CX2341X_ENC_SET_ASPECT_RATIO:
-               return  "SET_ASPECT_RATIO";
+               return "SET_ASPECT_RATIO";
        case CX2341X_ENC_SET_DNR_FILTER_MODE:
-               return  "SET_DNR_FILTER_PROPS";
+               return "SET_DNR_FILTER_PROPS";
        case CX2341X_ENC_SET_DNR_FILTER_PROPS:
-               return  "SET_DNR_FILTER_PROPS";
+               return "SET_DNR_FILTER_PROPS";
        case CX2341X_ENC_SET_CORING_LEVELS:
-               return  "SET_CORING_LEVELS";
+               return "SET_CORING_LEVELS";
        case CX2341X_ENC_SET_SPATIAL_FILTER_TYPE:
-               return  "SET_SPATIAL_FILTER_TYPE";
+               return "SET_SPATIAL_FILTER_TYPE";
        case CX2341X_ENC_SET_VBI_LINE:
-               return  "SET_VBI_LINE";
+               return "SET_VBI_LINE";
        case CX2341X_ENC_SET_STREAM_TYPE:
-               return  "SET_STREAM_TYPE";
+               return "SET_STREAM_TYPE";
        case CX2341X_ENC_SET_OUTPUT_PORT:
-               return  "SET_OUTPUT_PORT";
+               return "SET_OUTPUT_PORT";
        case CX2341X_ENC_SET_AUDIO_PROPERTIES:
-               return  "SET_AUDIO_PROPERTIES";
+               return "SET_AUDIO_PROPERTIES";
        case CX2341X_ENC_HALT_FW:
-               return  "HALT_FW";
+               return "HALT_FW";
        case CX2341X_ENC_GET_VERSION:
-               return  "GET_VERSION";
+               return "GET_VERSION";
        case CX2341X_ENC_SET_GOP_CLOSURE:
-               return  "SET_GOP_CLOSURE";
+               return "SET_GOP_CLOSURE";
        case CX2341X_ENC_GET_SEQ_END:
-               return  "GET_SEQ_END";
+               return "GET_SEQ_END";
        case CX2341X_ENC_SET_PGM_INDEX_INFO:
-               return  "SET_PGM_INDEX_INFO";
+               return "SET_PGM_INDEX_INFO";
        case CX2341X_ENC_SET_VBI_CONFIG:
-               return  "SET_VBI_CONFIG";
+               return "SET_VBI_CONFIG";
        case CX2341X_ENC_SET_DMA_BLOCK_SIZE:
-               return  "SET_DMA_BLOCK_SIZE";
+               return "SET_DMA_BLOCK_SIZE";
        case CX2341X_ENC_GET_PREV_DMA_INFO_MB_10:
-               return  "GET_PREV_DMA_INFO_MB_10";
+               return "GET_PREV_DMA_INFO_MB_10";
        case CX2341X_ENC_GET_PREV_DMA_INFO_MB_9:
-               return  "GET_PREV_DMA_INFO_MB_9";
+               return "GET_PREV_DMA_INFO_MB_9";
        case CX2341X_ENC_SCHED_DMA_TO_HOST:
-               return  "SCHED_DMA_TO_HOST";
+               return "SCHED_DMA_TO_HOST";
        case CX2341X_ENC_INITIALIZE_INPUT:
-               return  "INITIALIZE_INPUT";
+               return "INITIALIZE_INPUT";
        case CX2341X_ENC_SET_FRAME_DROP_RATE:
-               return  "SET_FRAME_DROP_RATE";
+               return "SET_FRAME_DROP_RATE";
        case CX2341X_ENC_PAUSE_ENCODER:
-               return  "PAUSE_ENCODER";
+               return "PAUSE_ENCODER";
        case CX2341X_ENC_REFRESH_INPUT:
-               return  "REFRESH_INPUT";
+               return "REFRESH_INPUT";
        case CX2341X_ENC_SET_COPYRIGHT:
-               return  "SET_COPYRIGHT";
+               return "SET_COPYRIGHT";
        case CX2341X_ENC_SET_EVENT_NOTIFICATION:
-               return  "SET_EVENT_NOTIFICATION";
+               return "SET_EVENT_NOTIFICATION";
        case CX2341X_ENC_SET_NUM_VSYNC_LINES:
-               return  "SET_NUM_VSYNC_LINES";
+               return "SET_NUM_VSYNC_LINES";
        case CX2341X_ENC_SET_PLACEHOLDER:
-               return  "SET_PLACEHOLDER";
+               return "SET_PLACEHOLDER";
        case CX2341X_ENC_MUTE_VIDEO:
-               return  "MUTE_VIDEO";
+               return "MUTE_VIDEO";
        case CX2341X_ENC_MUTE_AUDIO:
-               return  "MUTE_AUDIO";
+               return "MUTE_AUDIO";
        case CX2341X_ENC_MISC:
-               return  "MISC";
+               return "MISC";
        default:
                return "UNKNOWN";
        }
 }
 
-static int cx231xx_mbox_func(void *priv,
-                            u32 command,
-                            int in,
-                            int out,
+static int cx231xx_mbox_func(void *priv, u32 command, int in, int out,
                             u32 data[CX2341X_MBOX_MAX_DATA])
 {
        struct cx231xx *dev = priv;
@@ -721,11 +743,9 @@ static int cx231xx_mbox_func(void *priv,
           without side effects */
        mc417_memory_read(dev, dev->cx23417_mailbox - 4, &value);
        if (value != 0x12345678) {
-               dprintk(3,
-                       "Firmware and/or mailbox pointer not initialized "
-                       "or corrupted, signature = 0x%x, cmd = %s\n", value,
-                       cmd_to_str(command));
-               return -1;
+               dprintk(3, "Firmware and/or mailbox pointer not initialized or corrupted, signature = 0x%x, cmd = %s\n",
+                       value, cmd_to_str(command));
+               return -EIO;
        }
 
        /* This read looks at 32 bits, but flag is only 8 bits.
@@ -733,9 +753,9 @@ static int cx231xx_mbox_func(void *priv,
         */
        mc417_memory_read(dev, dev->cx23417_mailbox, &flag);
        if (flag) {
-               dprintk(3, "ERROR: Mailbox appears to be in use "
-                       "(%x), cmd = %s\n", flag, cmd_to_str(command));
-               return -1;
+               dprintk(3, "ERROR: Mailbox appears to be in use (%x), cmd = %s\n",
+                               flag, cmd_to_str(command));
+               return -EBUSY;
        }
 
        flag |= 1; /* tell 'em we're working on it */
@@ -764,7 +784,7 @@ static int cx231xx_mbox_func(void *priv,
                        break;
                if (time_after(jiffies, timeout)) {
                        dprintk(3, "ERROR: API Mailbox timeout\n");
-                       return -1;
+                       return -EIO;
                }
                udelay(10);
        }
@@ -781,17 +801,14 @@ static int cx231xx_mbox_func(void *priv,
        flag = 0;
        mc417_memory_write(dev, dev->cx23417_mailbox, flag);
 
-       return retval;
+       return 0;
 }
 
 /* We don't need to call the API often, so using just one
  * mailbox will probably suffice
  */
-static int cx231xx_api_cmd(struct cx231xx *dev,
-                          u32 command,
-                          u32 inputcnt,
-                          u32 outputcnt,
-                          ...)
+static int cx231xx_api_cmd(struct cx231xx *dev, u32 command,
+               u32 inputcnt, u32 outputcnt, ...)
 {
        u32 data[CX2341X_MBOX_MAX_DATA];
        va_list vargs;
@@ -813,6 +830,7 @@ static int cx231xx_api_cmd(struct cx231xx *dev,
        return err;
 }
 
+
 static int cx231xx_find_mailbox(struct cx231xx *dev)
 {
        u32 signature[4] = {
@@ -834,81 +852,80 @@ static int cx231xx_find_mailbox(struct cx231xx *dev)
                else
                        signaturecnt = 0;
                if (4 == signaturecnt) {
-                       dprintk(1, "Mailbox signature found at 0x%x\n", i+1);
-                       return i+1;
+                       dprintk(1, "Mailbox signature found at 0x%x\n", i + 1);
+                       return i + 1;
                }
        }
        dprintk(3, "Mailbox signature values not found!\n");
        return -1;
 }
 
-static void mciWriteMemoryToGPIO(struct cx231xx *dev, u32 address, u32 value,
+static void mci_write_memory_to_gpio(struct cx231xx *dev, u32 address, u32 value,
                u32 *p_fw_image)
 {
-
        u32 temp = 0;
        int i = 0;
 
-       temp = 0x82|MCI_MEMORY_DATA_BYTE0|((value&0x000000FF)<<8);
-       temp = temp<<10;
+       temp = 0x82 | MCI_MEMORY_DATA_BYTE0 | ((value & 0x000000FF) << 8);
+       temp = temp << 10;
        *p_fw_image = temp;
        p_fw_image++;
-       temp = temp|((0x05)<<10);
+       temp = temp | (0x05 << 10);
        *p_fw_image = temp;
        p_fw_image++;
 
        /*write data byte 1;*/
-       temp = 0x82|MCI_MEMORY_DATA_BYTE1|(value&0x0000FF00);
-       temp = temp<<10;
+       temp = 0x82 | MCI_MEMORY_DATA_BYTE1 | (value & 0x0000FF00);
+       temp = temp << 10;
        *p_fw_image = temp;
        p_fw_image++;
-       temp = temp|((0x05)<<10);
+       temp = temp | (0x05 << 10);
        *p_fw_image = temp;
        p_fw_image++;
 
        /*write data byte 2;*/
-       temp = 0x82|MCI_MEMORY_DATA_BYTE2|((value&0x00FF0000)>>8);
-       temp = temp<<10;
+       temp = 0x82 | MCI_MEMORY_DATA_BYTE2 | ((value & 0x00FF0000) >> 8);
+       temp = temp << 10;
        *p_fw_image = temp;
        p_fw_image++;
-       temp = temp|((0x05)<<10);
+       temp = temp | (0x05 << 10);
        *p_fw_image = temp;
        p_fw_image++;
 
        /*write data byte 3;*/
-       temp = 0x82|MCI_MEMORY_DATA_BYTE3|((value&0xFF000000)>>16);
-       temp = temp<<10;
+       temp = 0x82 | MCI_MEMORY_DATA_BYTE3 | ((value & 0xFF000000) >> 16);
+       temp = temp << 10;
        *p_fw_image = temp;
        p_fw_image++;
-       temp = temp|((0x05)<<10);
+       temp = temp | (0x05 << 10);
        *p_fw_image = temp;
        p_fw_image++;
 
        /* write address byte 2;*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE2 | MCI_MODE_MEMORY_WRITE |
-               ((address & 0x003F0000)>>8);
-       temp = temp<<10;
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE2 | MCI_MODE_MEMORY_WRITE |
+               ((address & 0x003F0000) >> 8);
+       temp = temp << 10;
        *p_fw_image = temp;
        p_fw_image++;
-       temp = temp|((0x05)<<10);
+       temp = temp | (0x05 << 10);
        *p_fw_image = temp;
        p_fw_image++;
 
        /* write address byte 1;*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE1 | (address & 0xFF00);
-       temp = temp<<10;
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE1 | (address & 0xFF00);
+       temp = temp << 10;
        *p_fw_image = temp;
        p_fw_image++;
-       temp = temp|((0x05)<<10);
+       temp = temp | (0x05 << 10);
        *p_fw_image = temp;
        p_fw_image++;
 
        /* write address byte 0;*/
-       temp = 0x82|MCI_MEMORY_ADDRESS_BYTE0|((address & 0x00FF)<<8);
-       temp = temp<<10;
+       temp = 0x82 | MCI_MEMORY_ADDRESS_BYTE0 | ((address & 0x00FF) << 8);
+       temp = temp << 10;
        *p_fw_image = temp;
        p_fw_image++;
-       temp = temp|((0x05)<<10);
+       temp = temp | (0x05 << 10);
        *p_fw_image = temp;
        p_fw_image++;
 
@@ -971,8 +988,7 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
                IVTV_REG_APU, 0);
 
        if (retval != 0) {
-               printk(KERN_ERR "%s: Error with mc417_register_write\n",
-                       __func__);
+               pr_err("%s: Error with mc417_register_write\n", __func__);
                return -1;
        }
 
@@ -980,25 +996,21 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
                                  &dev->udev->dev);
 
        if (retval != 0) {
-               printk(KERN_ERR
-                       "ERROR: Hotplug firmware request failed (%s).\n",
+               pr_err("ERROR: Hotplug firmware request failed (%s).\n",
                        CX231xx_FIRM_IMAGE_NAME);
-               printk(KERN_ERR "Please fix your hotplug setup, the board will "
-                       "not work without firmware loaded!\n");
+               pr_err("Please fix your hotplug setup, the board will not work without firmware loaded!\n");
                return -1;
        }
 
        if (firmware->size != CX231xx_FIRM_IMAGE_SIZE) {
-               printk(KERN_ERR "ERROR: Firmware size mismatch "
-                       "(have %zd, expected %d)\n",
+               pr_err("ERROR: Firmware size mismatch (have %zd, expected %d)\n",
                        firmware->size, CX231xx_FIRM_IMAGE_SIZE);
                release_firmware(firmware);
                return -1;
        }
 
        if (0 != memcmp(firmware->data, magic, 8)) {
-               printk(KERN_ERR
-                       "ERROR: Firmware magic mismatch, wrong file?\n");
+               pr_err("ERROR: Firmware magic mismatch, wrong file?\n");
                release_firmware(firmware);
                return -1;
        }
@@ -1013,7 +1025,7 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
                 transfer_size += 4) {
                fw_data = *p_fw_data;
 
-                mciWriteMemoryToGPIO(dev, address, fw_data, p_current_fw);
+               mci_write_memory_to_gpio(dev, address, fw_data, p_current_fw);
                address = address + 1;
                p_current_fw += 20;
                p_fw_data += 1;
@@ -1045,7 +1057,7 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
        retval |= mc417_register_write(dev, IVTV_REG_HW_BLOCKS,
                IVTV_CMD_HW_BLOCKS_RST);
        if (retval < 0) {
-               printk(KERN_ERR "%s: Error with mc417_register_write\n",
+               pr_err("%s: Error with mc417_register_write\n",
                        __func__);
                return retval;
        }
@@ -1057,7 +1069,7 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
        retval |= mc417_register_write(dev, IVTV_REG_VPU, value & 0xFFFFFFE8);
 
        if (retval < 0) {
-               printk(KERN_ERR "%s: Error with mc417_register_write\n",
+               pr_err("%s: Error with mc417_register_write\n",
                        __func__);
                return retval;
        }
@@ -1082,10 +1094,10 @@ static void cx231xx_codec_settings(struct cx231xx *dev)
        cx231xx_api_cmd(dev, CX2341X_ENC_SET_FRAME_SIZE, 2, 0,
                                dev->ts1.height, dev->ts1.width);
 
-       dev->mpeg_params.width = dev->ts1.width;
-       dev->mpeg_params.height = dev->ts1.height;
+       dev->mpeg_ctrl_handler.width = dev->ts1.width;
+       dev->mpeg_ctrl_handler.height = dev->ts1.height;
 
-       cx2341x_update(dev, cx231xx_mbox_func, NULL, &dev->mpeg_params);
+       cx2341x_handler_setup(&dev->mpeg_ctrl_handler);
 
        cx231xx_api_cmd(dev, CX2341X_ENC_MISC, 2, 0, 3, 1);
        cx231xx_api_cmd(dev, CX2341X_ENC_MISC, 2, 0, 4, 1);
@@ -1105,27 +1117,25 @@ static int cx231xx_initialize_codec(struct cx231xx *dev)
                dprintk(2, "%s() PING OK\n", __func__);
                retval = cx231xx_load_firmware(dev);
                if (retval < 0) {
-                       printk(KERN_ERR "%s() f/w load failed\n", __func__);
+                       pr_err("%s() f/w load failed\n", __func__);
                        return retval;
                }
                retval = cx231xx_find_mailbox(dev);
                if (retval < 0) {
-                       printk(KERN_ERR "%s() mailbox < 0, error\n",
+                       pr_err("%s() mailbox < 0, error\n",
                                __func__);
                        return -1;
                }
                dev->cx23417_mailbox = retval;
                retval = cx231xx_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0);
                if (retval < 0) {
-                       printk(KERN_ERR
-                               "ERROR: cx23417 firmware ping failed!\n");
+                       pr_err("ERROR: cx23417 firmware ping failed!\n");
                        return -1;
                }
                retval = cx231xx_api_cmd(dev, CX2341X_ENC_GET_VERSION, 0, 1,
                        &version);
                if (retval < 0) {
-                       printk(KERN_ERR "ERROR: cx23417 firmware get encoder :"
-                               "version failed!\n");
+                       pr_err("ERROR: cx23417 firmware get encoder: version failed!\n");
                        return -1;
                }
                dprintk(1, "cx23417 firmware version is 0x%08x\n", version);
@@ -1134,7 +1144,7 @@ static int cx231xx_initialize_codec(struct cx231xx *dev)
 
        for (i = 0; i < 1; i++) {
                retval = mc417_register_read(dev, 0x20f8, &val);
-               dprintk(3, "***before enable656() VIM Capture Lines =%d ***\n",
+               dprintk(3, "***before enable656() VIM Capture Lines = %d ***\n",
                                 val);
                if (retval < 0)
                        return retval;
@@ -1202,7 +1212,7 @@ static int cx231xx_initialize_codec(struct cx231xx *dev)
 
        for (i = 0; i < 1; i++) {
                mc417_register_read(dev, 0x20f8, &val);
-       dprintk(3, "***VIM Capture Lines =%d ***\n", val);
+               dprintk(3, "***VIM Capture Lines =%d ***\n", val);
        }
 
        return 0;
@@ -1223,6 +1233,7 @@ static int bb_buf_setup(struct videobuf_queue *q,
 
        return 0;
 }
+
 static void free_buffer(struct videobuf_queue *vq, struct cx231xx_buffer *buf)
 {
        struct cx231xx_fh *fh = vq->priv_data;
@@ -1249,91 +1260,85 @@ static void free_buffer(struct videobuf_queue *vq, struct cx231xx_buffer *buf)
 static void buffer_copy(struct cx231xx *dev, char *data, int len, struct urb *urb,
                struct cx231xx_dmaqueue *dma_q)
 {
-               void *vbuf;
-               struct cx231xx_buffer *buf;
-               u32 tail_data = 0;
-               char *p_data;
-
-               if (dma_q->mpeg_buffer_done == 0) {
-                       if (list_empty(&dma_q->active))
-                               return;
-
-                       buf = list_entry(dma_q->active.next,
-                                       struct cx231xx_buffer, vb.queue);
-                       dev->video_mode.isoc_ctl.buf = buf;
-                       dma_q->mpeg_buffer_done = 1;
-               }
-               /* Fill buffer */
-               buf = dev->video_mode.isoc_ctl.buf;
-               vbuf = videobuf_to_vmalloc(&buf->vb);
-
-               if ((dma_q->mpeg_buffer_completed+len) <
-                  mpeglines*mpeglinesize) {
-                       if (dma_q->add_ps_package_head ==
-                          CX231XX_NEED_ADD_PS_PACKAGE_HEAD) {
-                               memcpy(vbuf+dma_q->mpeg_buffer_completed,
-                                      dma_q->ps_head, 3);
-                               dma_q->mpeg_buffer_completed =
-                                 dma_q->mpeg_buffer_completed + 3;
-                               dma_q->add_ps_package_head =
-                                 CX231XX_NONEED_PS_PACKAGE_HEAD;
-                       }
-                       memcpy(vbuf+dma_q->mpeg_buffer_completed, data, len);
-                       dma_q->mpeg_buffer_completed =
-                         dma_q->mpeg_buffer_completed + len;
-               } else {
-                       dma_q->mpeg_buffer_done = 0;
-
-                       tail_data =
-                         mpeglines*mpeglinesize - dma_q->mpeg_buffer_completed;
-                       memcpy(vbuf+dma_q->mpeg_buffer_completed,
-                              data, tail_data);
-
-                       buf->vb.state = VIDEOBUF_DONE;
-                       buf->vb.field_count++;
-                       v4l2_get_timestamp(&buf->vb.ts);
-                       list_del(&buf->vb.queue);
-                       wake_up(&buf->vb.done);
-                       dma_q->mpeg_buffer_completed = 0;
-
-                       if (len - tail_data > 0) {
-                               p_data = data + tail_data;
-                               dma_q->left_data_count = len - tail_data;
-                               memcpy(dma_q->p_left_data,
-                                      p_data, len - tail_data);
-                       }
-
-               }
-
-           return;
-}
-
-static void buffer_filled(char *data, int len, struct urb *urb,
-               struct cx231xx_dmaqueue *dma_q)
-{
-               void *vbuf;
-               struct cx231xx_buffer *buf;
+       void *vbuf;
+       struct cx231xx_buffer *buf;
+       u32 tail_data = 0;
+       char *p_data;
 
+       if (dma_q->mpeg_buffer_done == 0) {
                if (list_empty(&dma_q->active))
                        return;
 
-
                buf = list_entry(dma_q->active.next,
-                                struct cx231xx_buffer, vb.queue);
+                               struct cx231xx_buffer, vb.queue);
+               dev->video_mode.isoc_ctl.buf = buf;
+               dma_q->mpeg_buffer_done = 1;
+       }
+       /* Fill buffer */
+       buf = dev->video_mode.isoc_ctl.buf;
+       vbuf = videobuf_to_vmalloc(&buf->vb);
+
+       if ((dma_q->mpeg_buffer_completed+len) <
+                       mpeglines*mpeglinesize) {
+               if (dma_q->add_ps_package_head ==
+                               CX231XX_NEED_ADD_PS_PACKAGE_HEAD) {
+                       memcpy(vbuf+dma_q->mpeg_buffer_completed,
+                                       dma_q->ps_head, 3);
+                       dma_q->mpeg_buffer_completed =
+                               dma_q->mpeg_buffer_completed + 3;
+                       dma_q->add_ps_package_head =
+                               CX231XX_NONEED_PS_PACKAGE_HEAD;
+               }
+               memcpy(vbuf+dma_q->mpeg_buffer_completed, data, len);
+               dma_q->mpeg_buffer_completed =
+                       dma_q->mpeg_buffer_completed + len;
+       } else {
+               dma_q->mpeg_buffer_done = 0;
 
+               tail_data =
+                       mpeglines*mpeglinesize - dma_q->mpeg_buffer_completed;
+               memcpy(vbuf+dma_q->mpeg_buffer_completed,
+                               data, tail_data);
 
-               /* Fill buffer */
-               vbuf = videobuf_to_vmalloc(&buf->vb);
-               memcpy(vbuf, data, len);
                buf->vb.state = VIDEOBUF_DONE;
                buf->vb.field_count++;
                v4l2_get_timestamp(&buf->vb.ts);
                list_del(&buf->vb.queue);
                wake_up(&buf->vb.done);
+               dma_q->mpeg_buffer_completed = 0;
 
-           return;
+               if (len - tail_data > 0) {
+                       p_data = data + tail_data;
+                       dma_q->left_data_count = len - tail_data;
+                       memcpy(dma_q->p_left_data,
+                                       p_data, len - tail_data);
+               }
+       }
 }
-static inline int cx231xx_isoc_copy(struct cx231xx *dev, struct urb *urb)
+
+static void buffer_filled(char *data, int len, struct urb *urb,
+               struct cx231xx_dmaqueue *dma_q)
+{
+       void *vbuf;
+       struct cx231xx_buffer *buf;
+
+       if (list_empty(&dma_q->active))
+               return;
+
+       buf = list_entry(dma_q->active.next,
+                       struct cx231xx_buffer, vb.queue);
+
+       /* Fill buffer */
+       vbuf = videobuf_to_vmalloc(&buf->vb);
+       memcpy(vbuf, data, len);
+       buf->vb.state = VIDEOBUF_DONE;
+       buf->vb.field_count++;
+       v4l2_get_timestamp(&buf->vb.ts);
+       list_del(&buf->vb.queue);
+       wake_up(&buf->vb.done);
+}
+
+static int cx231xx_isoc_copy(struct cx231xx *dev, struct urb *urb)
 {
        struct cx231xx_dmaqueue *dma_q = urb->context;
        unsigned char *p_buffer;
@@ -1358,11 +1363,9 @@ static inline int cx231xx_isoc_copy(struct cx231xx *dev, struct urb *urb)
 
        return 0;
 }
-static inline int cx231xx_bulk_copy(struct cx231xx *dev, struct urb *urb)
-{
 
-       /*char *outp;*/
-       /*struct cx231xx_buffer *buf;*/
+static int cx231xx_bulk_copy(struct cx231xx *dev, struct urb *urb)
+{
        struct cx231xx_dmaqueue *dma_q = urb->context;
        unsigned char *p_buffer, *buffer;
        u32 buffer_size = 0;
@@ -1393,8 +1396,6 @@ static int bb_buf_prepare(struct videobuf_queue *q,
        int rc = 0, urb_init = 0;
        int size = fh->dev->ts1.ts_packet_size * fh->dev->ts1.ts_packet_count;
 
-       dma_qq = &dev->video_mode.vidq;
-
        if (0 != buf->vb.baddr  &&  buf->vb.bsize < size)
                return -EINVAL;
        buf->vb.width = fh->dev->ts1.ts_packet_size;
@@ -1482,36 +1483,6 @@ static struct videobuf_queue_ops cx231xx_qops = {
 
 /* ------------------------------------------------------------------ */
 
-static const u32 *ctrl_classes[] = {
-       cx2341x_mpeg_ctrls,
-       NULL
-};
-
-static int cx231xx_queryctrl(struct cx231xx *dev,
-       struct v4l2_queryctrl *qctrl)
-{
-       qctrl->id = v4l2_ctrl_next(ctrl_classes, qctrl->id);
-       if (qctrl->id == 0)
-               return -EINVAL;
-
-       /* MPEG V4L2 controls */
-       if (cx2341x_ctrl_query(&dev->mpeg_params, qctrl))
-               qctrl->flags |= V4L2_CTRL_FLAG_DISABLED;
-
-       return 0;
-}
-
-static int cx231xx_querymenu(struct cx231xx *dev,
-       struct v4l2_querymenu *qmenu)
-{
-       struct v4l2_queryctrl qctrl;
-
-       qctrl.id = qmenu->id;
-       cx231xx_queryctrl(dev, &qctrl);
-       return v4l2_ctrl_query_menu(qmenu, &qctrl,
-               cx2341x_ctrl_get_menu(&dev->mpeg_params, qmenu->id));
-}
-
 static int vidioc_g_std(struct file *file, void *fh0, v4l2_std_id *norm)
 {
        struct cx231xx_fh  *fh  = file->private_data;
@@ -1520,14 +1491,15 @@ static int vidioc_g_std(struct file *file, void *fh0, v4l2_std_id *norm)
        *norm = dev->encodernorm.id;
        return 0;
 }
-static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id *id)
+
+static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id id)
 {
        struct cx231xx_fh  *fh  = file->private_data;
        struct cx231xx *dev = fh->dev;
        unsigned int i;
 
        for (i = 0; i < ARRAY_SIZE(cx231xx_tvnorms); i++)
-               if (*id & cx231xx_tvnorms[i].id)
+               if (id & cx231xx_tvnorms[i].id)
                        break;
        if (i == ARRAY_SIZE(cx231xx_tvnorms))
                return -EINVAL;
@@ -1537,12 +1509,12 @@ static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id *id)
                dprintk(3, "encodernorm set to NTSC\n");
                dev->norm = V4L2_STD_NTSC;
                dev->ts1.height = 480;
-               dev->mpeg_params.is_50hz = 0;
+               cx2341x_handler_set_50hz(&dev->mpeg_ctrl_handler, false);
        } else {
                dprintk(3, "encodernorm set to PAL\n");
                dev->norm = V4L2_STD_PAL_B;
                dev->ts1.height = 576;
-               dev->mpeg_params.is_50hz = 1;
+               cx2341x_handler_set_50hz(&dev->mpeg_ctrl_handler, true);
        }
        call_all(dev, core, s_std, dev->norm);
        /* do mode control overrides */
@@ -1551,161 +1523,23 @@ static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id *id)
        dprintk(3, "exit vidioc_s_std() i=0x%x\n", i);
        return 0;
 }
-static int vidioc_g_audio(struct file *file, void *fh,
-                                       struct v4l2_audio *a)
-{
-               struct v4l2_audio *vin = a;
-
-               int ret = -EINVAL;
-               if (vin->index > 0)
-                       return ret;
-               strncpy(vin->name, "VideoGrabber Audio", 14);
-               vin->capability = V4L2_AUDCAP_STEREO;
-return 0;
-}
-static int vidioc_enumaudio(struct file *file, void *fh,
-                                       struct v4l2_audio *a)
-{
-               struct v4l2_audio *vin = a;
-
-               int ret = -EINVAL;
-
-               if (vin->index > 0)
-                       return ret;
-               strncpy(vin->name, "VideoGrabber Audio", 14);
-               vin->capability = V4L2_AUDCAP_STEREO;
-
-
-return 0;
-}
-static const char *iname[] = {
-       [CX231XX_VMUX_COMPOSITE1] = "Composite1",
-       [CX231XX_VMUX_SVIDEO]     = "S-Video",
-       [CX231XX_VMUX_TELEVISION] = "Television",
-       [CX231XX_VMUX_CABLE]      = "Cable TV",
-       [CX231XX_VMUX_DVB]        = "DVB",
-       [CX231XX_VMUX_DEBUG]      = "for debug only",
-};
-static int vidioc_enum_input(struct file *file, void *priv,
-                               struct v4l2_input *i)
-{
-       struct cx231xx_fh  *fh  = file->private_data;
-       struct cx231xx *dev = fh->dev;
-       struct cx231xx_input *input;
-       int n;
-       dprintk(3, "enter vidioc_enum_input()i->index=%d\n", i->index);
-
-       if (i->index >= 4)
-               return -EINVAL;
-
-
-       input = &cx231xx_boards[dev->model].input[i->index];
-
-       if (input->type == 0)
-               return -EINVAL;
-
-       /* FIXME
-        * strcpy(i->name, input->name); */
-
-       n = i->index;
-       strcpy(i->name, iname[INPUT(n)->type]);
-
-       if (input->type == CX231XX_VMUX_TELEVISION ||
-           input->type == CX231XX_VMUX_CABLE)
-               i->type = V4L2_INPUT_TYPE_TUNER;
-       else
-               i->type  = V4L2_INPUT_TYPE_CAMERA;
-
-
-       return 0;
-}
-
-static int vidioc_g_input(struct file *file, void *priv, unsigned int *i)
-{
-       *i = 0;
-       return  0;
-}
-
-static int vidioc_s_input(struct file *file, void *priv, unsigned int i)
-{
-       struct cx231xx_fh  *fh  = file->private_data;
-       struct cx231xx *dev = fh->dev;
-
-       dprintk(3, "enter vidioc_s_input() i=%d\n", i);
-
-       mutex_lock(&dev->lock);
-
-       video_mux(dev, i);
-
-       mutex_unlock(&dev->lock);
-
-       if (i >= 4)
-               return -EINVAL;
-       dev->input = i;
-       dprintk(3, "exit vidioc_s_input()\n");
-       return 0;
-}
-
-static int vidioc_g_tuner(struct file *file, void *priv,
-                               struct v4l2_tuner *t)
-{
-       return 0;
-}
-
-static int vidioc_s_tuner(struct file *file, void *priv,
-                               struct v4l2_tuner *t)
-{
-       return 0;
-}
-
-static int vidioc_g_frequency(struct file *file, void *priv,
-                               struct v4l2_frequency *f)
-{
-       return 0;
-}
-
-static int vidioc_s_frequency(struct file *file, void *priv,
-                               struct v4l2_frequency *f)
-{
-
-
-       return 0;
-}
 
 static int vidioc_s_ctrl(struct file *file, void *priv,
                                struct v4l2_control *ctl)
 {
        struct cx231xx_fh  *fh  = file->private_data;
        struct cx231xx *dev = fh->dev;
+
        dprintk(3, "enter vidioc_s_ctrl()\n");
        /* Update the A/V core */
        call_all(dev, core, s_ctrl, ctl);
        dprintk(3, "exit vidioc_s_ctrl()\n");
        return 0;
 }
-static struct v4l2_capability pvr_capability = {
-       .driver         = "cx231xx",
-       .card           = "VideoGrabber",
-       .bus_info       = "usb",
-       .version        = 1,
-       .capabilities   = (V4L2_CAP_VIDEO_CAPTURE |
-                          V4L2_CAP_TUNER | V4L2_CAP_AUDIO | V4L2_CAP_RADIO |
-                        V4L2_CAP_STREAMING | V4L2_CAP_READWRITE),
-};
-static int vidioc_querycap(struct file *file, void  *priv,
-                               struct v4l2_capability *cap)
-{
-
-
-
-               memcpy(cap, &pvr_capability, sizeof(struct v4l2_capability));
-       return 0;
-}
 
 static int vidioc_enum_fmt_vid_cap(struct file *file, void  *priv,
                                        struct v4l2_fmtdesc *f)
 {
-
        if (f->index != 0)
                return -EINVAL;
 
@@ -1720,17 +1554,18 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv,
 {
        struct cx231xx_fh  *fh  = file->private_data;
        struct cx231xx *dev = fh->dev;
+
        dprintk(3, "enter vidioc_g_fmt_vid_cap()\n");
-       f->fmt.pix.pixelformat  = V4L2_PIX_FMT_MPEG;
+       f->fmt.pix.pixelformat = V4L2_PIX_FMT_MPEG;
        f->fmt.pix.bytesperline = 0;
-       f->fmt.pix.sizeimage    =
-               dev->ts1.ts_packet_size * dev->ts1.ts_packet_count;
-       f->fmt.pix.colorspace   = 0;
-       f->fmt.pix.width        = dev->ts1.width;
-       f->fmt.pix.height       = dev->ts1.height;
-       f->fmt.pix.field        = fh->vidq.field;
-       dprintk(1, "VIDIOC_G_FMT: w: %d, h: %d, f: %d\n",
-               dev->ts1.width, dev->ts1.height, fh->vidq.field);
+       f->fmt.pix.sizeimage = mpeglines * mpeglinesize;
+       f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
+       f->fmt.pix.width = dev->ts1.width;
+       f->fmt.pix.height = dev->ts1.height;
+       f->fmt.pix.field = V4L2_FIELD_INTERLACED;
+       f->fmt.pix.priv = 0;
+       dprintk(1, "VIDIOC_G_FMT: w: %d, h: %d\n",
+               dev->ts1.width, dev->ts1.height);
        dprintk(3, "exit vidioc_g_fmt_vid_cap()\n");
        return 0;
 }
@@ -1740,25 +1575,20 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
 {
        struct cx231xx_fh  *fh  = file->private_data;
        struct cx231xx *dev = fh->dev;
+
        dprintk(3, "enter vidioc_try_fmt_vid_cap()\n");
-       f->fmt.pix.pixelformat  = V4L2_PIX_FMT_MPEG;
+       f->fmt.pix.pixelformat = V4L2_PIX_FMT_MPEG;
        f->fmt.pix.bytesperline = 0;
-       f->fmt.pix.sizeimage    =
-               dev->ts1.ts_packet_size * dev->ts1.ts_packet_count;
-       f->fmt.pix.colorspace   = 0;
-       dprintk(1, "VIDIOC_TRY_FMT: w: %d, h: %d, f: %d\n",
-               dev->ts1.width, dev->ts1.height, fh->vidq.field);
+       f->fmt.pix.sizeimage = mpeglines * mpeglinesize;
+       f->fmt.pix.field = V4L2_FIELD_INTERLACED;
+       f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
+       f->fmt.pix.priv = 0;
+       dprintk(1, "VIDIOC_TRY_FMT: w: %d, h: %d\n",
+               dev->ts1.width, dev->ts1.height);
        dprintk(3, "exit vidioc_try_fmt_vid_cap()\n");
        return 0;
 }
 
-static int vidioc_s_fmt_vid_cap(struct file *file, void *priv,
-                               struct v4l2_format *f)
-{
-
-       return 0;
-}
-
 static int vidioc_reqbufs(struct file *file, void *priv,
                                struct v4l2_requestbuffers *p)
 {
@@ -1795,22 +1625,22 @@ static int vidioc_streamon(struct file *file, void *priv,
                                enum v4l2_buf_type i)
 {
        struct cx231xx_fh  *fh  = file->private_data;
-
        struct cx231xx *dev = fh->dev;
+
        dprintk(3, "enter vidioc_streamon()\n");
-               cx231xx_set_alt_setting(dev, INDEX_TS1, 0);
-               cx231xx_set_mode(dev, CX231XX_DIGITAL_MODE);
-               if (dev->USE_ISO)
-                       cx231xx_init_isoc(dev, CX231XX_NUM_PACKETS,
-                                      CX231XX_NUM_BUFS,
-                                      dev->video_mode.max_pkt_size,
-                                      cx231xx_isoc_copy);
-               else {
-                       cx231xx_init_bulk(dev, 320,
-                                      5,
-                                      dev->ts1_mode.max_pkt_size,
-                                      cx231xx_bulk_copy);
-               }
+       cx231xx_set_alt_setting(dev, INDEX_TS1, 0);
+       cx231xx_set_mode(dev, CX231XX_DIGITAL_MODE);
+       if (dev->USE_ISO)
+               cx231xx_init_isoc(dev, CX231XX_NUM_PACKETS,
+                               CX231XX_NUM_BUFS,
+                               dev->video_mode.max_pkt_size,
+                               cx231xx_isoc_copy);
+       else {
+               cx231xx_init_bulk(dev, 320,
+                               5,
+                               dev->ts1_mode.max_pkt_size,
+                               cx231xx_bulk_copy);
+       }
        dprintk(3, "exit vidioc_streamon()\n");
        return videobuf_streamon(&fh->vidq);
 }
@@ -1822,117 +1652,25 @@ static int vidioc_streamoff(struct file *file, void *priv, enum v4l2_buf_type i)
        return videobuf_streamoff(&fh->vidq);
 }
 
-static int vidioc_g_ext_ctrls(struct file *file, void *priv,
-                               struct v4l2_ext_controls *f)
-{
-       struct cx231xx_fh  *fh  = priv;
-       struct cx231xx *dev = fh->dev;
-       dprintk(3, "enter vidioc_g_ext_ctrls()\n");
-       if (f->ctrl_class != V4L2_CTRL_CLASS_MPEG)
-               return -EINVAL;
-       dprintk(3, "exit vidioc_g_ext_ctrls()\n");
-       return cx2341x_ext_ctrls(&dev->mpeg_params, 0, f, VIDIOC_G_EXT_CTRLS);
-}
-
-static int vidioc_s_ext_ctrls(struct file *file, void *priv,
-                               struct v4l2_ext_controls *f)
-{
-       struct cx231xx_fh  *fh  = priv;
-       struct cx231xx *dev = fh->dev;
-       struct cx2341x_mpeg_params p;
-       int err;
-       dprintk(3, "enter vidioc_s_ext_ctrls()\n");
-       if (f->ctrl_class != V4L2_CTRL_CLASS_MPEG)
-               return -EINVAL;
-
-       p = dev->mpeg_params;
-       err = cx2341x_ext_ctrls(&p, 0, f, VIDIOC_TRY_EXT_CTRLS);
-       if (err == 0) {
-               err = cx2341x_update(dev, cx231xx_mbox_func,
-                       &dev->mpeg_params, &p);
-               dev->mpeg_params = p;
-       }
-
-       return err;
-
-
-return 0;
-}
-
-static int vidioc_try_ext_ctrls(struct file *file, void *priv,
-                               struct v4l2_ext_controls *f)
-{
-       struct cx231xx_fh  *fh  = priv;
-       struct cx231xx *dev = fh->dev;
-       struct cx2341x_mpeg_params p;
-       int err;
-       dprintk(3, "enter vidioc_try_ext_ctrls()\n");
-       if (f->ctrl_class != V4L2_CTRL_CLASS_MPEG)
-               return -EINVAL;
-
-       p = dev->mpeg_params;
-       err = cx2341x_ext_ctrls(&p, 0, f, VIDIOC_TRY_EXT_CTRLS);
-       dprintk(3, "exit vidioc_try_ext_ctrls() err=%d\n", err);
-       return err;
-}
-
 static int vidioc_log_status(struct file *file, void *priv)
 {
        struct cx231xx_fh  *fh  = priv;
        struct cx231xx *dev = fh->dev;
-       char name[32 + 2];
 
-       snprintf(name, sizeof(name), "%s/2", dev->name);
-       dprintk(3,
-               "%s/2: ============  START LOG STATUS  ============\n",
-              dev->name);
        call_all(dev, core, log_status);
-       cx2341x_log_status(&dev->mpeg_params, name);
-       dprintk(3,
-               "%s/2: =============  END LOG STATUS  =============\n",
-              dev->name);
-       return 0;
-}
-
-static int vidioc_querymenu(struct file *file, void *priv,
-                               struct v4l2_querymenu *a)
-{
-       struct cx231xx_fh  *fh  = priv;
-       struct cx231xx *dev = fh->dev;
-       dprintk(3, "enter vidioc_querymenu()\n");
-       dprintk(3, "exit vidioc_querymenu()\n");
-       return cx231xx_querymenu(dev, a);
-}
-
-static int vidioc_queryctrl(struct file *file, void *priv,
-                               struct v4l2_queryctrl *c)
-{
-       struct cx231xx_fh  *fh  = priv;
-       struct cx231xx *dev = fh->dev;
-       dprintk(3, "enter vidioc_queryctrl()\n");
-       dprintk(3, "exit vidioc_queryctrl()\n");
-       return cx231xx_queryctrl(dev, c);
+       return v4l2_ctrl_log_status(file, priv);
 }
 
 static int mpeg_open(struct file *file)
 {
-       int minor = video_devdata(file)->minor;
-       struct cx231xx *h, *dev = NULL;
-       /*struct list_head *list;*/
+       struct video_device *vdev = video_devdata(file);
+       struct cx231xx *dev = video_drvdata(file);
        struct cx231xx_fh *fh;
-       /*u32 value = 0;*/
 
        dprintk(2, "%s()\n", __func__);
 
-       list_for_each_entry(h, &cx231xx_devlist, devlist) {
-               if (h->v4l_device->minor == minor)
-                       dev = h;
-       }
-
-       if (dev == NULL)
-               return -ENODEV;
-
-       mutex_lock(&dev->lock);
+       if (mutex_lock_interruptible(&dev->lock))
+               return -ERESTARTSYS;
 
        /* allocate + initialize per filehandle data */
        fh = kzalloc(sizeof(*fh), GFP_KERNEL);
@@ -1942,29 +1680,30 @@ static int mpeg_open(struct file *file)
        }
 
        file->private_data = fh;
-       fh->dev      = dev;
+       v4l2_fh_init(&fh->fh, vdev);
+       fh->dev = dev;
 
 
        videobuf_queue_vmalloc_init(&fh->vidq, &cx231xx_qops,
                            NULL, &dev->video_mode.slock,
                            V4L2_BUF_TYPE_VIDEO_CAPTURE, V4L2_FIELD_INTERLACED,
-                           sizeof(struct cx231xx_buffer), fh, NULL);
+                           sizeof(struct cx231xx_buffer), fh, &dev->lock);
 /*
        videobuf_queue_sg_init(&fh->vidq, &cx231xx_qops,
                            &dev->udev->dev, &dev->ts1.slock,
                            V4L2_BUF_TYPE_VIDEO_CAPTURE,
                            V4L2_FIELD_INTERLACED,
                            sizeof(struct cx231xx_buffer),
-                           fh, NULL);
+                           fh, &dev->lock);
 */
 
-
        cx231xx_set_alt_setting(dev, INDEX_VANC, 1);
        cx231xx_set_gpio_value(dev, 2, 0);
 
        cx231xx_initialize_codec(dev);
 
        mutex_unlock(&dev->lock);
+       v4l2_fh_add(&fh->fh);
        cx231xx_start_TS1(dev);
 
        return 0;
@@ -1977,25 +1716,20 @@ static int mpeg_release(struct file *file)
 
        dprintk(3, "mpeg_release()! dev=0x%p\n", dev);
 
-       if (!dev) {
-               dprintk(3, "abort!!!\n");
-               return 0;
-       }
-
        mutex_lock(&dev->lock);
 
        cx231xx_stop_TS1(dev);
 
-               /* do this before setting alternate! */
-               if (dev->USE_ISO)
-                       cx231xx_uninit_isoc(dev);
-               else
-                       cx231xx_uninit_bulk(dev);
-               cx231xx_set_mode(dev, CX231XX_SUSPEND);
+       /* do this before setting alternate! */
+       if (dev->USE_ISO)
+               cx231xx_uninit_isoc(dev);
+       else
+               cx231xx_uninit_bulk(dev);
+       cx231xx_set_mode(dev, CX231XX_SUSPEND);
 
-               cx231xx_api_cmd(fh->dev, CX2341X_ENC_STOP_CAPTURE, 3, 0,
-                               CX231xx_END_NOW, CX231xx_MPEG_CAPTURE,
-                               CX231xx_RAW_BITS_NONE);
+       cx231xx_api_cmd(fh->dev, CX2341X_ENC_STOP_CAPTURE, 3, 0,
+                       CX231xx_END_NOW, CX231xx_MPEG_CAPTURE,
+                       CX231xx_RAW_BITS_NONE);
 
        /* FIXME: Review this crap */
        /* Shut device down on last close */
@@ -2015,7 +1749,8 @@ static int mpeg_release(struct file *file)
                videobuf_read_stop(&fh->vidq);
 
        videobuf_mmap_free(&fh->vidq);
-       file->private_data = NULL;
+       v4l2_fh_del(&fh->fh);
+       v4l2_fh_exit(&fh->fh);
        kfree(fh);
        mutex_unlock(&dev->lock);
        return 0;
@@ -2027,7 +1762,6 @@ static ssize_t mpeg_read(struct file *file, char __user *data,
        struct cx231xx_fh *fh = file->private_data;
        struct cx231xx *dev = fh->dev;
 
-
        /* Deal w/ A/V decoder * and mpeg encoder sync issues. */
        /* Start mpeg encoder on first read. */
        if (atomic_cmpxchg(&fh->v4l_reading, 0, 1) == 0) {
@@ -2044,12 +1778,23 @@ static ssize_t mpeg_read(struct file *file, char __user *data,
 static unsigned int mpeg_poll(struct file *file,
        struct poll_table_struct *wait)
 {
+       unsigned long req_events = poll_requested_events(wait);
        struct cx231xx_fh *fh = file->private_data;
-       /*struct cx231xx *dev = fh->dev;*/
+       struct cx231xx *dev = fh->dev;
+       unsigned int res = 0;
+
+       if (v4l2_event_pending(&fh->fh))
+               res |= POLLPRI;
+       else
+               poll_wait(file, &fh->fh.wait, wait);
 
-       /*dprintk(2, "%s\n", __func__);*/
+       if (!(req_events & (POLLIN | POLLRDNORM)))
+               return res;
 
-       return videobuf_poll_stream(file, &fh->vidq, wait);
+       mutex_lock(&dev->lock);
+       res |= videobuf_poll_stream(file, &fh->vidq, wait);
+       mutex_unlock(&dev->lock);
+       return res;
 }
 
 static int mpeg_mmap(struct file *file, struct vm_area_struct *vma)
@@ -2069,44 +1814,39 @@ static struct v4l2_file_operations mpeg_fops = {
        .read          = mpeg_read,
        .poll          = mpeg_poll,
        .mmap          = mpeg_mmap,
-       .ioctl         = video_ioctl2,
+       .unlocked_ioctl = video_ioctl2,
 };
 
 static const struct v4l2_ioctl_ops mpeg_ioctl_ops = {
        .vidioc_s_std            = vidioc_s_std,
        .vidioc_g_std            = vidioc_g_std,
-       .vidioc_enum_input       = vidioc_enum_input,
-       .vidioc_enumaudio        = vidioc_enumaudio,
-       .vidioc_g_audio          = vidioc_g_audio,
-       .vidioc_g_input          = vidioc_g_input,
-       .vidioc_s_input          = vidioc_s_input,
-       .vidioc_g_tuner          = vidioc_g_tuner,
-       .vidioc_s_tuner          = vidioc_s_tuner,
-       .vidioc_g_frequency      = vidioc_g_frequency,
-       .vidioc_s_frequency      = vidioc_s_frequency,
+       .vidioc_g_tuner          = cx231xx_g_tuner,
+       .vidioc_s_tuner          = cx231xx_s_tuner,
+       .vidioc_g_frequency      = cx231xx_g_frequency,
+       .vidioc_s_frequency      = cx231xx_s_frequency,
+       .vidioc_enum_input       = cx231xx_enum_input,
+       .vidioc_g_input          = cx231xx_g_input,
+       .vidioc_s_input          = cx231xx_s_input,
        .vidioc_s_ctrl           = vidioc_s_ctrl,
-       .vidioc_querycap         = vidioc_querycap,
+       .vidioc_querycap         = cx231xx_querycap,
        .vidioc_enum_fmt_vid_cap = vidioc_enum_fmt_vid_cap,
        .vidioc_g_fmt_vid_cap    = vidioc_g_fmt_vid_cap,
        .vidioc_try_fmt_vid_cap  = vidioc_try_fmt_vid_cap,
-       .vidioc_s_fmt_vid_cap    = vidioc_s_fmt_vid_cap,
+       .vidioc_s_fmt_vid_cap    = vidioc_try_fmt_vid_cap,
        .vidioc_reqbufs          = vidioc_reqbufs,
        .vidioc_querybuf         = vidioc_querybuf,
        .vidioc_qbuf             = vidioc_qbuf,
        .vidioc_dqbuf            = vidioc_dqbuf,
        .vidioc_streamon         = vidioc_streamon,
        .vidioc_streamoff        = vidioc_streamoff,
-       .vidioc_g_ext_ctrls      = vidioc_g_ext_ctrls,
-       .vidioc_s_ext_ctrls      = vidioc_s_ext_ctrls,
-       .vidioc_try_ext_ctrls    = vidioc_try_ext_ctrls,
        .vidioc_log_status       = vidioc_log_status,
-       .vidioc_querymenu        = vidioc_querymenu,
-       .vidioc_queryctrl        = vidioc_queryctrl,
-/*     .vidioc_g_chip_ident     = cx231xx_g_chip_ident,*/
+       .vidioc_g_chip_ident     = cx231xx_g_chip_ident,
 #ifdef CONFIG_VIDEO_ADV_DEBUG
-/*     .vidioc_g_register       = cx231xx_g_register,*/
-/*     .vidioc_s_register       = cx231xx_s_register,*/
+       .vidioc_g_register       = cx231xx_g_register,
+       .vidioc_s_register       = cx231xx_s_register,
 #endif
+       .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
+       .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
 };
 
 static struct video_device cx231xx_mpeg_template = {
@@ -2114,8 +1854,7 @@ static struct video_device cx231xx_mpeg_template = {
        .fops          = &mpeg_fops,
        .ioctl_ops     = &mpeg_ioctl_ops,
        .minor         = -1,
-       .tvnorms       = CX231xx_NORMS,
-       .current_norm  = V4L2_STD_NTSC_M,
+       .tvnorms       = V4L2_STD_ALL,
 };
 
 void cx231xx_417_unregister(struct cx231xx *dev)
@@ -2128,10 +1867,44 @@ void cx231xx_417_unregister(struct cx231xx *dev)
                        video_unregister_device(dev->v4l_device);
                else
                        video_device_release(dev->v4l_device);
+               v4l2_ctrl_handler_free(&dev->mpeg_ctrl_handler.hdl);
                dev->v4l_device = NULL;
        }
 }
 
+static int cx231xx_s_video_encoding(struct cx2341x_handler *cxhdl, u32 val)
+{
+       struct cx231xx *dev = container_of(cxhdl, struct cx231xx, mpeg_ctrl_handler);
+       int is_mpeg1 = val == V4L2_MPEG_VIDEO_ENCODING_MPEG_1;
+       struct v4l2_mbus_framefmt fmt;
+
+       /* fix videodecoder resolution */
+       fmt.width = cxhdl->width / (is_mpeg1 ? 2 : 1);
+       fmt.height = cxhdl->height;
+       fmt.code = V4L2_MBUS_FMT_FIXED;
+       v4l2_subdev_call(dev->sd_cx25840, video, s_mbus_fmt, &fmt);
+       return 0;
+}
+
+static int cx231xx_s_audio_sampling_freq(struct cx2341x_handler *cxhdl, u32 idx)
+{
+       static const u32 freqs[3] = { 44100, 48000, 32000 };
+       struct cx231xx *dev = container_of(cxhdl, struct cx231xx, mpeg_ctrl_handler);
+
+       /* The audio clock of the digitizer must match the codec sample
+          rate otherwise you get some very strange effects. */
+       if (idx < ARRAY_SIZE(freqs))
+               call_all(dev, audio, s_clock_freq, freqs[idx]);
+       return 0;
+}
+
+static struct cx2341x_handler_ops cx231xx_ops = {
+       /* needed for the video clock freq */
+       .s_audio_sampling_freq = cx231xx_s_audio_sampling_freq,
+       /* needed for setting up the video resolution */
+       .s_video_encoding = cx231xx_s_video_encoding,
+};
+
 static struct video_device *cx231xx_video_dev_alloc(
        struct cx231xx *dev,
        struct usb_device *usbdev,
@@ -2145,12 +1918,21 @@ static struct video_device *cx231xx_video_dev_alloc(
        if (NULL == vfd)
                return NULL;
        *vfd = *template;
-       vfd->minor = -1;
        snprintf(vfd->name, sizeof(vfd->name), "%s %s (%s)", dev->name,
                type, cx231xx_boards[dev->model].name);
 
        vfd->v4l2_dev = &dev->v4l2_dev;
+       vfd->lock = &dev->lock;
        vfd->release = video_device_release;
+       set_bit(V4L2_FL_USE_FH_PRIO, &vfd->flags);
+       vfd->ctrl_handler = &dev->mpeg_ctrl_handler.hdl;
+       video_set_drvdata(vfd, dev);
+       if (dev->tuner_type == TUNER_ABSENT) {
+               v4l2_disable_ioctl(vfd, VIDIOC_G_FREQUENCY);
+               v4l2_disable_ioctl(vfd, VIDIOC_S_FREQUENCY);
+               v4l2_disable_ioctl(vfd, VIDIOC_G_TUNER);
+               v4l2_disable_ioctl(vfd, VIDIOC_S_TUNER);
+       }
 
        return vfd;
 
@@ -2173,10 +1955,27 @@ int cx231xx_417_register(struct cx231xx *dev)
                tsport->height = 576;
 
        tsport->width = 720;
-       cx2341x_fill_defaults(&dev->mpeg_params);
+       err = cx2341x_handler_init(&dev->mpeg_ctrl_handler, 50);
+       if (err) {
+               dprintk(3, "%s: can't init cx2341x controls\n", dev->name);
+               return err;
+       }
+       dev->mpeg_ctrl_handler.func = cx231xx_mbox_func;
+       dev->mpeg_ctrl_handler.priv = dev;
+       dev->mpeg_ctrl_handler.ops = &cx231xx_ops;
+       if (dev->sd_cx25840)
+               v4l2_ctrl_add_handler(&dev->mpeg_ctrl_handler.hdl,
+                               dev->sd_cx25840->ctrl_handler, NULL);
+       if (dev->mpeg_ctrl_handler.hdl.error) {
+               err = dev->mpeg_ctrl_handler.hdl.error;
+               dprintk(3, "%s: can't add cx25840 controls\n", dev->name);
+               v4l2_ctrl_handler_free(&dev->mpeg_ctrl_handler.hdl);
+               return err;
+       }
        dev->norm = V4L2_STD_NTSC;
 
-       dev->mpeg_params.port = CX2341X_PORT_SERIAL;
+       dev->mpeg_ctrl_handler.port = CX2341X_PORT_SERIAL;
+       cx2341x_handler_set_50hz(&dev->mpeg_ctrl_handler, false);
 
        /* Allocate and initialize V4L video device */
        dev->v4l_device = cx231xx_video_dev_alloc(dev,
@@ -2185,6 +1984,7 @@ int cx231xx_417_register(struct cx231xx *dev)
                VFL_TYPE_GRABBER, -1);
        if (err < 0) {
                dprintk(3, "%s: can't register mpeg device\n", dev->name);
+               v4l2_ctrl_handler_free(&dev->mpeg_ctrl_handler.hdl);
                return err;
        }